From c578f90a41ddffff11db2a081fa407866adea6c4 Mon Sep 17 00:00:00 2001 From: Georgiana Dolocan Date: Mon, 17 Jul 2023 12:24:54 +0300 Subject: [PATCH] Make sure binderhub-service is dissabled by default --- helm-charts/basehub/values.schema.yaml | 8 ++++++++ helm-charts/basehub/values.yaml | 3 +++ 2 files changed, 11 insertions(+) diff --git a/helm-charts/basehub/values.schema.yaml b/helm-charts/basehub/values.schema.yaml index 488e7b3546..f62c04fa06 100644 --- a/helm-charts/basehub/values.schema.yaml +++ b/helm-charts/basehub/values.schema.yaml @@ -210,6 +210,14 @@ properties: binderhub-service: type: object additionalProperties: true + required: + - enabled + properties: + enabled: + type: boolean + # https://github.com/2i2c-org/binderhub-service + description: | + Enable image building with binderhub-service # jupyterhub is a dependent helm chart and we rely _mostly_ on its schema # validation for values passed to it and are not imposing restrictions on # most of them in this helm chart. diff --git a/helm-charts/basehub/values.yaml b/helm-charts/basehub/values.yaml index e76d6a0c90..3916d94bd7 100644 --- a/helm-charts/basehub/values.yaml +++ b/helm-charts/basehub/values.yaml @@ -5,6 +5,9 @@ userServiceAccount: enabled: true annotations: {} +binderhub-service: + enabled: false + ingressBasicAuth: enabled: false # Primarily here for validation to 'work',