-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle HighEntropyValues as evidence in on-premise solution #118
Comments
Hi! We haven't implemented HighEntropyValues in Node yet. Node would require an additional flow element to process the 51D_GHEV value at the start of the pipeline. Here's a link to the .NET version: https://github.com/51Degrees/device-detection-dotnet/tree/main/FiftyOne.DeviceDetection/FiftyOne.DeviceDetection/Uach So at the moment, this is a feature request (I'll change the label on this issue to reflect this). Alternatively, anyone can make PRs to add this feature to Node should they wish. We will update this issue with more information in due time, but we aren't able to look at adding this feature just yet. Are you able to successfully use the cloud solution in the meantime? |
Hi, |
Hi! Thanks for clarification. To answer your questions: Are you able to use .NET for your self-hosted solution? |
Thanks for the clarifications. We don't have .NET expertise in our company, so other SDKs are more preferred (e.g. node.js/python). |
Thanks for the quick response. Do let us know how you get on! If you are unable to submit a PR, let us know. Unfortunately, this feature is not part of our immediate scope, so it could take some time before we are able to look at it internally. If you require the feature sooner, we can put you in touch with an external organization who can help out for a fee. |
Hi, |
Hi @vpenyazkov The GetHighEntropyValues data needs to be converted before device detection takes place. We've already done this in .Net using a flow element called UACH Converter; this needs to be ported for Node: please see the link here I hope this helps! |
hi @Sara51D , as I can see, the Flow Element handles the conversion from The example of the response from the cloud solution showing the properties which I mean:
|
Hi @vpenyazkov. Thanks for providing this extra information! Can I confirm which on-premise data file are you using? If you are able to provide both the file name and the date it was published that would be helpful. Another thing to try might be to passing an empty |
Hi @kirstin51D, I'm currently using When I provide empty
|
Hi @vpenyazkov Apologies for not being clearer. Could you please try passing a null restricted Properties parameter and see what is returned? Thanks, |
hi @Sara51D, In the case
|
Hi @vpenyazkov |
Hi @vpenyazkov! I just wanted to let you know that GetHighEntropyValues has now been added to the V4 Enterprise file and the data file is now available. Hopefully this resolves the issue you were facing regarding the property not being returned by the engine. Do let us know if you encounter any other issues! Thanks. |
hi @kirstin51D, I can confirm that it's returned now, thanks |
Hi @vpenyazkov! Glad to hear that GetHighEntropyValues is returned. How have you been able to progress on raising a PR as mentioned above? Have you encountered any other issues or are we able to close this GitHub issue? Thanks! |
Hi @kirstin51D. we implemented that on our side, so we are not going to submit a PR into this repo |
this feature will be implemented as part of the C library, thus moved the issue here. |
I'm working on on-premise solution and I see that your code example does not handle HighEntropyValues similar to what cloud solution provides (e.g.
51D_GetHighEntropyValues
in request body).Am I missing something? Or, if this should be handle manually, what evidences should I set from the value of
getHighEntropyValues
method?The text was updated successfully, but these errors were encountered: