Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.6.0 no longer works for Angular 6 or 7 #51

Open
lichtin opened this issue Jul 15, 2020 · 2 comments
Open

Version 0.6.0 no longer works for Angular 6 or 7 #51

lichtin opened this issue Jul 15, 2020 · 2 comments

Comments

@lichtin
Copy link

lichtin commented Jul 15, 2020

node_modules/ngx-text-diff/lib/ngx-text-diff.component.d.ts(20,9): error TS1086: An accessor cannot be declared in an ambient context.
node_modules/ngx-text-diff/lib/ngx-text-diff.component.d.ts(21,9): error TS1086: An accessor cannot be declared in an ambient context.

I was hoping ngx-text-diff would work with Angular >= 6.

@govindthakur25
Copy link

@lichtin 0.6.0 was released to support Angular 9 upgrade if you are still using Angular 6/7, then it would be better to stay at version 0.5.0.
And yes, the 'peerDependencies' should be updated to reflect the same, I have opened an issue for it #49.

@lichtin
Copy link
Author

lichtin commented Jul 15, 2020

I don't see this as a solution imho.
ngx-text-diff should support Angular 6 and higher, there's no reason to restrict support to Angular 9 only.
ngx-text-diff does not require any particular features specific to Angular 9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants