Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 10 Ivy #56

Open
Dovernh opened this issue Oct 28, 2020 · 6 comments
Open

Angular 10 Ivy #56

Dovernh opened this issue Oct 28, 2020 · 6 comments

Comments

@Dovernh
Copy link

Dovernh commented Oct 28, 2020

This likely means that the library (ngx-text-diff/lib/ngx-text-diff.module) which declares NgxTextDiffModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy

@Dovernh
Copy link
Author

Dovernh commented Oct 29, 2020

So i created a new Angular 10 project, copied parts of the code and i got things to work.

@gethari
Copy link

gethari commented Nov 12, 2020

So i created a new Angular 10 project, copied parts of the code and i got things to work.

Would you mind sharing what you did ?

@lauramgran
Copy link

Hello!
I am also having problems with this component when updating it to angular 10.
I have disabled ivy to avoid problems and they are still incompatible
Have you managed to use this component in angular 10?

Thanks

@Dovernh
Copy link
Author

Dovernh commented Nov 17, 2020 via email

@gethari
Copy link

gethari commented Nov 23, 2020

So not the best solution, but it enabled to use the functionality. If you look at the code in GitHub you will see code that is 2 years old (it is the code which does the diff’ing). That code is good (synchronize scroll doesn’t work for me). The newer code which is a wrapper around the diff code has some issues I think. So what I did was removed the wrapper code and pointed my angular code at the old code angular selectors. I have made other code adjustments that are specific to my requirements. Also I made the diff code on its own module so it is no longer a npm lib. I was hoping the author would eventually fix the code so I could toss my temp solution and go back to the npm module

On Nov 17, 2020, 11:32 AM -0500, lauramgran @.***>, wrote: Hello! I am also having problems with this component when updating it to angular 10. I have disabled ivy to avoid problems and they are still incompatible Have you managed to use this component in angular 10? Thanks — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

I did the same for angular 10

@ABenassi87
Copy link
Owner

Hi, I apologize for the delay, but I don't have time to update the library because I'm so busy. If anyone wants to update the library and create a pull request I would really appreciate it.
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants