Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare result may change lines ordering? #60

Open
ericxbenoit opened this issue Dec 22, 2020 · 11 comments
Open

Compare result may change lines ordering? #60

ericxbenoit opened this issue Dec 22, 2020 · 11 comments
Labels
bug Something isn't working

Comments

@ericxbenoit
Copy link

Hello,

We are using ngx-text-diff in an Angular app and we encountered an issue with the order of the comparison results.

For example, if we have these 5 lines in the left content:

- name: DDD
- name: CCC
- name: BBB
- name: AAA
- name: EEE

And these 5 lines in the right content:

- name: EEE
- name: DDD
- name: AAA
- name: BBB
- name: CCC

The compare result in the right side is:

- name: EEE
- name: DDD
- name: AAA
- name: CCC
- name: BBB

For some unknown reason it inverts the lines BBB and CCC..

Is there a way to fix this problem quickly?

Thanks

@ericxbenoit
Copy link
Author

More visual example:
NgxTextDiffApp

@jonathan-fortin
Copy link

Hi,

I have the same problem. Anyone have a suggestion or a quick solution to this problem?

Thanks

@ABenassi87
Copy link
Owner

Hi, @ericxbenoit and @jonathan-fortin thank you so much for creating the issue. I will try to review it soon and I will push the fix.

@ericxbenoit
Copy link
Author

@ABenassi87 thanks, your help is really appreciated and I will wait for your fix. Thank you

@jonathan-fortin
Copy link

Wow, quick reply, thanks @ABenassi87 !

@ABenassi87 ABenassi87 added the bug Something isn't working label Dec 25, 2020
@jonathan-fortin
Copy link

Hi @ABenassi87 do you have any update on this issue ? Do you think it will be possible to have a fixed soon? Thank you!

@ABenassi87
Copy link
Owner

Hi @jonathan-fortin I'm still working on it. Right now, I hope to have the fix soon.

@jonathan-fortin
Copy link

@ABenassi87 Thanks for the update!

@ericxbenoit
Copy link
Author

Hello,
@ABenassi87 Any update with the fix?
Thanks

@jonathan-fortin
Copy link

Hi @ABenassi87

Your library is amazing, easy to integrate, good UX etc. But, this bug is a blocker in our case. Do you think it will be possible to solve it?

And thank you again for your work!

@jonathan-fortin
Copy link

Hi @ABenassi87,

Hope you are feeling well!

I noticed that you have branched out to resolve this issue. Do you have any idea when you will be releasing a new version with this fix?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants