Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC change introduced between v6.0.3 and v6.0.9 #145

Open
TristanPouliquen opened this issue Nov 22, 2024 · 0 comments
Open

BC change introduced between v6.0.3 and v6.0.9 #145

TristanPouliquen opened this issue Nov 22, 2024 · 0 comments

Comments

@TristanPouliquen
Copy link
Contributor

Hello,

Just to inform you that you introduced a BC change in a bugfix version.

We switched from v6.0.3 to v6.0.9 as our constraint does not fix the bugfix version, and this resulted in issues in our app.

PostmarkClient::getSuppressions saw its return type change from PostmarkSuppressionRequestList to PostmarkSuppressionList, which internally creates PostmarkSuppression and not PostmarkSuppressionRequestResult anymore.

Type-hinting we had in place failed, and properties of these objects are not the same, even if we only relied on the emailAddress, so changing the type-hint allowed us to easily fix the issue.

Are you following a semver policy or can any release on your end include other BCs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant