Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a model for storing the various bookmarks that are to be "remembered" #451

Open
krschacht opened this issue Jul 8, 2024 · 0 comments
Milestone

Comments

@krschacht
Copy link
Contributor

From this Discussion #450

  • Some model such as Post (or whatever we settle on)
  • langchainrb_rails added and linked to this new model
  • pg_search added and linked to this model
  • All the search methods for this model in a concern (e.g. include Searchable for posts/searchable.rb)

I think success for this PR will be fixtures that create some Post and successfully search for them. Basically:

concerns/searchable_test.rb
Unit tests that call the various search methods (e.g. via keyword and via vector search)

One notable thing is that I believe generating the vectors will require calling the OpenAI API, and they probably get stored in some extra database table that langchainrb_rails creates. We should probably pre-create these vectors as fixtures since we won't want the tests to call the APIs.

@krschacht krschacht added this to the 0.8 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant