Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipse fitting #9

Open
James-Ilosta opened this issue Oct 21, 2022 · 2 comments
Open

Ellipse fitting #9

James-Ilosta opened this issue Oct 21, 2022 · 2 comments

Comments

@James-Ilosta
Copy link

Hi, I wanted to implement this script into a bigger script. On the hyper least squares paper cited, the approach is applied to ellipses. I wanted to apply it too for ellispes. The process might well work for an ellipse using the code provided, however, it won't output the correct radius and doesn't include the eccentricity of the ellipse. Do you have any ideas for implementing this into the script?

@AlliedToasters
Copy link
Owner

I don't have any plans for this. Strictly speaking, this is a circle-fitting library.. but I do see why ellipses would be helpful for a lot of users.
Please feel free to make some changes and open a pull request! This would be a big new feature for the library. I'm open to it but unfortunately I don't have time to implement this.

@James-Ilosta
Copy link
Author

Thanks for the reply. It's probably beyond me at this point in time, as I don't really have the time at the moment. Maybe down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants