From 613c6bf4da2540a20700d90436ed1fbc9ec00ffc Mon Sep 17 00:00:00 2001 From: Jan Murre Date: Tue, 23 Jan 2024 08:45:57 +0100 Subject: [PATCH] Fix storing the display_field on the datasettable (#540) A stringified tuple was saved to the database. Seems to be some kind of copy/paste error. --- CHANGES.md | 5 +++++ setup.cfg | 2 +- src/schematools/contrib/django/models.py | 1 - 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 2943de56..dcde05cd 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,3 +1,8 @@ +# 2024-01-22 (5.23.1) + +* Fix the storage of datasettables.display_field + (an old copy/paste error in the codebase) + # 2024-01-12 (5.23.0) * Modified create_views functions to support materialized views diff --git a/setup.cfg b/setup.cfg index 7d82b260..f1fbc8ee 100644 --- a/setup.cfg +++ b/setup.cfg @@ -1,6 +1,6 @@ [metadata] name = amsterdam-schema-tools -version = 5.23.0 +version = 5.23.1 url = https://github.com/amsterdam/schema-tools license = Mozilla Public 2.0 author = Team Data Diensten, van het Dataplatform onder de Directie Digitale Voorzieningen (Gemeente Amsterdam) diff --git a/src/schematools/contrib/django/models.py b/src/schematools/contrib/django/models.py index a3702f99..c332c561 100644 --- a/src/schematools/contrib/django/models.py +++ b/src/schematools/contrib/django/models.py @@ -406,7 +406,6 @@ def save_for_schema(self, table_schema: DatasetTableSchema): self.db_table = table_schema.db_name self.auth = " ".join(table_schema.auth) self.display_field = display_field.db_name if display_field is not None else None - self.display_field = ((display_field.db_name if display_field is not None else None),) self.geometry_field, self.geometry_field_type = self._get_geometry_field(table_schema) self.is_temporal = table_schema.is_temporal self.enable_geosearch = (