Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble chart text min value #29

Open
cescoferraro opened this issue Mar 1, 2017 · 4 comments
Open

Bubble chart text min value #29

cescoferraro opened this issue Mar 1, 2017 · 4 comments

Comments

@cescoferraro
Copy link

The bubble chart needs to have a value bigger than 15 to display text. This value is too random, should not this be a prop?

https://github.com/AnSavvides/d3act/blob/master/src/components/BubbleChart.js#L15

@sghgh1996
Copy link

I had this problem too. I just added 15 to all my values. It may not be the right way but it helped me.

@AnSavvides
Copy link
Owner

Good point! If you've got time to, a PR to address this would be great!

@sghgh1996
Copy link

Actually I really like to do that. Do I remove grater than 15 restriction or make it as a prop? I think removing grater than 15 restriction would be good.

@AnSavvides
Copy link
Owner

I believe I set a limit because smaller bubbles having text would have the text spilling over - as long as we can add an ellipsis or something like that to ensure it doesn't spill out, sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants