Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timing attack vulnerability for admin secret #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TimDaub
Copy link

@TimDaub TimDaub commented Oct 25, 2021

Direct comparisons of strings in node.js should be avoided given that an
attacker could brute force their way to the key, given a timing attack
strategy. The node.js docs recommend using timingSafeEqual from the
crypto standard lib.

fixes #10

Direct comparisons of strings in node.js should be avoided given that an
attacker could brute force their way to the key, given a timing attack
strategy. The node.js docs recommend using `timingSafeEqual` from the
`crypto` standard lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret key check allows for timing attacks
1 participant