Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQUEST] Switch to using Intl.DisplayNames class for language names #573

Closed
paulwarren-wk opened this issue Oct 11, 2023 · 0 comments · Fixed by #640
Closed

[REQUEST] Switch to using Intl.DisplayNames class for language names #573

paulwarren-wk opened this issue Oct 11, 2023 · 0 comments · Fixed by #640
Labels
request New feature or request

Comments

@paulwarren-wk
Copy link
Contributor

What should we change and why?

Spun out of #568 (comment)

We currently embed names for languages used in the report in the JSON data block, and do not support i18n for these names.

Modern browsers support the Intl.DisplayNames class which will give us language names with i18n support.
@paulwarren-wk paulwarren-wk added the request New feature or request label Oct 11, 2023
@paulwarren-wk paulwarren-wk mentioned this issue Oct 11, 2023
Merged
paulwarren-wk pushed a commit to paulwarren-wk/ixbrl-viewer that referenced this issue Mar 9, 2024
Switch to using Intl.DisplayNames
25b0afe 
Use built-in JS support for multi-lingual labels for languages, rather
than including them in the viewer JSON.

Fixes Arelle#573
@paulwarren-wk paulwarren-wk mentioned this issue Mar 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to using Intl.DisplayNames paulwarren-wk/ixbrl-viewer
1 participant
@paulwarren-wk