From 08e84e44bb9ac227ff6b3022462a3b36669f80e2 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 18 Sep 2023 22:22:09 +0100
Subject: [PATCH 01/32] Generation-side support for multi-documents.

---
 iXBRLViewerPlugin/__init__.py    |   9 +-
 iXBRLViewerPlugin/iXBRLViewer.py | 197 +++++++++++++++++--------------
 2 files changed, 115 insertions(+), 91 deletions(-)

diff --git a/iXBRLViewerPlugin/__init__.py b/iXBRLViewerPlugin/__init__.py
index 8e9a84490..bde388706 100644
--- a/iXBRLViewerPlugin/__init__.py
+++ b/iXBRLViewerPlugin/__init__.py
@@ -81,6 +81,7 @@ def iXBRLViewerCommandLineOptionExtender(parser, *args, **kwargs):
                       default=False,
                       dest="zipViewerOutput",
                       help="Converts the viewer output into a self contained zip")
+    parser.add_option("--keepOpen", dest="keepOpen", default=True, action="store_true", help=argparse.SUPPRESS)
     featureGroup = OptionGroup(parser, "Viewer Features",
                             "See viewer README for information on enabling/disabling features.")
     for featureConfig in FEATURE_CONFIGS:
@@ -110,7 +111,9 @@ def generateViewer(
     :param features: List of feature names to enable via generated JSON data.
     """
     # extend XBRL-loaded run processing for this option
-    if cntlr.modelManager is None or cntlr.modelManager.modelXbrl is None or not cntlr.modelManager.modelXbrl.modelDocument:
+    if (cntlr.modelManager is None 
+        or len(cntlr.modelManager.loadedModelXbrls) == 0 
+        or any(not mx.modelDocument for mx in cntlr.modelManager.loadedModelXbrls)):
         cntlr.addToLog("No taxonomy loaded.")
         return
     modelXbrl = cntlr.modelManager.modelXbrl
@@ -137,7 +140,7 @@ def generateViewer(
     try:
         out = saveViewerDest
         if out:
-            viewerBuilder = IXBRLViewerBuilder(modelXbrl)
+            viewerBuilder = IXBRLViewerBuilder(cntlr.modelManager.loadedModelXbrls)
             if features:
                 for feature in features:
                     viewerBuilder.enableFeature(feature)
@@ -306,7 +309,7 @@ def load_plugin_url():
     'author': 'Paul Warren',
     'copyright': 'Copyright :: Workiva Inc. :: 2019',
     'CntlrCmdLine.Options': commandLineOptionExtender,
-    'CntlrCmdLine.Xbrl.Run': commandLineRun,
+    'CntlrCmdLine.Filing.End': commandLineRun,
     'CntlrWinMain.Menu.Tools': toolsMenuExtender,
     'CntlrWinMain.Xbrl.Loaded': guiRun,
 }
diff --git a/iXBRLViewerPlugin/iXBRLViewer.py b/iXBRLViewerPlugin/iXBRLViewer.py
index 3915b8c8f..5f7ed4a4e 100644
--- a/iXBRLViewerPlugin/iXBRLViewer.py
+++ b/iXBRLViewerPlugin/iXBRLViewer.py
@@ -82,17 +82,15 @@ class IXBRLViewerBuilderError(Exception):
 
 class IXBRLViewerBuilder:
 
-    def __init__(self, dts: ModelXbrl, basenameSuffix: str = ''):
+    def __init__(self, reports: List[ModelXbrl], basenameSuffix: str = ''):
         self.nsmap = NamespaceMap()
         self.roleMap = NamespaceMap()
-        self.dts = dts
+        self.reports = reports
         self.taxonomyData = {
-            "concepts": {},
-            "languages": {},
-            "facts": {},
+            "reports": [],
             "features": [],
+            "languages": {},
         }
-        self.footnoteRelationshipSet = ModelRelationshipSet(dts, "XBRL-footnotes")
         self.basenameSuffix = basenameSuffix
 
     def enableFeature(self, featureName: str):
@@ -146,22 +144,26 @@ def makeLanguageName(self, langCode):
     def addLanguage(self, langCode):
         if langCode not in self.taxonomyData["languages"]:
             self.taxonomyData["languages"][langCode] = self.makeLanguageName(langCode)
+
+    @property
+    def currentReportData(self):
+        return self.taxonomyData["reports"][-1]
             
-    def addELR(self, elr):
+    def addELR(self, report: ModelXbrl, elr):
         prefix = self.roleMap.getPrefix(elr)
-        if self.taxonomyData.setdefault("roleDefs",{}).get(prefix, None) is None:
-            rts = self.dts.roleTypes.get(elr, [])
+        if self.currentReportData.setdefault("roleDefs",{}).get(prefix, None) is None:
+            rts = report.roleTypes.get(elr, [])
             label = next((rt.definition for rt in rts if rt.definition is not None), None)
             if label is not None:
-                self.taxonomyData["roleDefs"].setdefault(prefix,{})["en"] = label
+                self.currentReportData["roleDefs"].setdefault(prefix,{})["en"] = label
 
-    def addConcept(self, concept, dimensionType = None):
+    def addConcept(self, report: ModelXbrl, concept, dimensionType = None):
         if concept is None:
             return
-        labelsRelationshipSet = self.dts.relationshipSet(XbrlConst.conceptLabel)
+        labelsRelationshipSet = report.relationshipSet(XbrlConst.conceptLabel)
         labels = labelsRelationshipSet.fromModelObject(concept)
         conceptName = self.nsmap.qname(concept.qname)
-        if conceptName not in self.taxonomyData["concepts"]:
+        if conceptName not in self.currentReportData["concepts"]:
             conceptData = {
                 "labels": {  }
             }
@@ -194,24 +196,24 @@ def addConcept(self, concept, dimensionType = None):
                 if typedDomainElement is not None:
                     typedDomainName = self.nsmap.qname(typedDomainElement.qname)
                     conceptData['td'] = typedDomainName
-                    self.addConcept(typedDomainElement)
+                    self.addConcept(report, typedDomainElement)
 
-            self.taxonomyData["concepts"][conceptName] = conceptData
+            self.currentReportData["concepts"][conceptName] = conceptData
 
     def treeWalk(self, rels, item, indent = 0):
         for r in rels.fromModelObject(item):
             if r.toModelObject is not None:
                 self.treeWalk(rels, r.toModelObject, indent + 1)
 
-    def getRelationships(self):
+    def getRelationships(self, report: ModelXbrl):
         rels = {}
 
-        for baseSetKey, baseSetModelLinks  in self.dts.baseSets.items():
+        for baseSetKey, baseSetModelLinks  in report.baseSets.items():
             arcrole, ELR, linkqname, arcqname = baseSetKey
             if arcrole in (XbrlConst.summationItem, WIDER_NARROWER_ARCROLE, XbrlConst.parentChild, XbrlConst.dimensionDefault) and ELR is not None:
-                self.addELR(ELR)
+                self.addELR(report, ELR)
                 rr = dict()
-                relSet = self.dts.relationshipSet(arcrole, ELR)
+                relSet = report.relationshipSet(arcrole, ELR)
                 for r in relSet.modelRelationships:
                     if r.fromModelObject is not None and r.toModelObject is not None:
                         fromKey = self.nsmap.qname(r.fromModelObject.qname)
@@ -221,8 +223,8 @@ def getRelationships(self):
                         if r.weight is not None:
                             rel['w'] = r.weight
                         rr.setdefault(fromKey, []).append(rel)
-                        self.addConcept(r.toModelObject)
-                        self.addConcept(r.fromModelObject)
+                        self.addConcept(report, r.toModelObject)
+                        self.addConcept(report, r.fromModelObject)
 
                 rels.setdefault(self.roleMap.getPrefix(arcrole),{})[self.roleMap.getPrefix(ELR)] = rr
         return rels
@@ -245,7 +247,7 @@ def validationErrors(self):
 
         return errors
 
-    def addFact(self, f):
+    def addFact(self, report: ModelXbrl, f):
         if f.id is None:
             f.set("id","ixv-%d" % (self.idGen))
 
@@ -270,7 +272,7 @@ def addFact(self, f):
                 qnEnums = (qnEnums,)
             factData["v"] = " ".join(self.nsmap.qname(qn) for qn in qnEnums)
             for qn in qnEnums:
-                self.addConcept(self.dts.qnameConcepts.get(qn))
+                self.addConcept(report, report.qnameConcepts.get(qn))
         else:
             factData["v"] = f.value 
             if f.value == INVALIDixVALUE:
@@ -295,11 +297,11 @@ def addFact(self, f):
         for d, v in f.context.qnameDims.items():
             if v.memberQname is not None:
                 aspects[self.nsmap.qname(v.dimensionQname)] = self.nsmap.qname(v.memberQname)
-                self.addConcept(v.member)
-                self.addConcept(v.dimension, dimensionType = "e")
+                self.addConcept(report, v.member)
+                self.addConcept(report, v.dimension, dimensionType = "e")
             elif v.typedMember is not None:
                 aspects[self.nsmap.qname(v.dimensionQname)] = v.typedMember.text
-                self.addConcept(v.dimension, dimensionType = "t")
+                self.addConcept(report, v.dimension, dimensionType = "t")
 
         if f.context.isForeverPeriod:
             aspects["p"] = "f"
@@ -317,8 +319,8 @@ def addFact(self, f):
                 if frel.toModelObject is not None:
                     factData.setdefault("fn", []).append(frel.toModelObject.id)
 
-        self.taxonomyData["facts"][f.id] = factData
-        self.addConcept(f.concept)
+        self.currentReportData["facts"][f.id] = factData
+        self.addConcept(report, f.concept)
 
     def oimUnitString(self, unit):
         """
@@ -384,8 +386,8 @@ def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool
         :param showValidations: True if validation errors should be included in output taxonomy data.
         :return: An iXBRLViewer instance that is ready to be saved.
         """
-        dts = self.dts
-        iv = iXBRLViewer(dts)
+        # This "dts" is only used for logging
+        iv = iXBRLViewer(self.reports[0])
         self.idGen = 0
         self.roleMap.getPrefix(XbrlConst.standardLabel, "std")
         self.roleMap.getPrefix(XbrlConst.documentationLabel, "doc")
@@ -394,79 +396,98 @@ def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool
         self.roleMap.getPrefix(XbrlConst.dimensionDefault, "d-d")
         self.roleMap.getPrefix(WIDER_NARROWER_ARCROLE, "w-n")
 
-        docSetFiles = None
+        # This is the document that we will embed the JSON taxonomy data in.
+        # This will be either the first document processed, or the stub document
+        xmlDocument = None
+
+        for n, report in enumerate(self.reports):
+            self.footnoteRelationshipSet = ModelRelationshipSet(report, "XBRL-footnotes")
+            self.taxonomyData["reports"].append({
+                "concepts": {},
+                "facts": {},
+            })
+            for f in report.facts:
+                self.addFact(report, f)
+            self.currentReportData["rels"] = self.getRelationships(report)
+
+            docSetFiles = None
+            report.info("viewer:info", "Creating iXBRL viewer (%d of %d)" % (n+1, len(self.reports)))
+            if report.modelDocument.type == Type.INLINEXBRLDOCUMENTSET:
+                # Sort by object index to preserve order in which files were specified.
+                xmlDocsByFilename = {
+                    os.path.basename(self.outputFilename(doc.filepath)): deepcopy(doc.xmlDocument)
+                    for doc in sorted(report.modelDocument.referencesDocument.keys(), key=lambda x: x.objectIndex)
+                }
+                docSetFiles = list(xmlDocsByFilename.keys())
+
+                if xmlDocument is None:
+                    if useStubViewer:
+                        xmlDocument = self.getStubDocument()
+                        iv.addFile(iXBRLViewerFile(DEFAULT_OUTPUT_NAME, xmlDocument))
+                    else:
+                        xmlDocument = next(iter(xmlDocsByFilename.values()))
+
+                for filename, docSetXMLDoc in xmlDocsByFilename.items():
+                    iv.addFile(iXBRLViewerFile(filename, docSetXMLDoc))
+
+            elif useStubViewer:
+                if xmlDocument is None:
+                    xmlDocument = self.getStubDocument()
+                    iv.addFile(iXBRLViewerFile(DEFAULT_OUTPUT_NAME, xmlDocument))
+                filename = self.outputFilename(os.path.basename(report.modelDocument.filepath))
+                docSetFiles = [ filename ]
+                iv.addFile(iXBRLViewerFile(filename, report.modelDocument.xmlDocument))
 
-        for f in dts.facts:
-            self.addFact(f)
+            else:
+                if len(self.reports) == 1:
+                    filename = "xbrlviewer.html"
+                else:
+                    filename = self.outputFilename(os.path.basename(report.modelDocument.filepath))
+                if xmlDocument is None:
+                    xmlDocument = deepcopy(report.modelDocument.xmlDocument)
+                    iv.addFile(iXBRLViewerFile(filename, xmlDocument))
+                else:
+                    iv.addFile(iXBRLViewerFile(filename, report.modelDocument.xmlDocument))
+
+            localDocs = defaultdict(set)
+            for path, doc in report.urlDocs.items():
+                if isHttpUrl(path):
+                    continue
+                if doc.type in (Type.INLINEXBRL, Type.INLINEXBRLDOCUMENTSET):
+                    localDocs[doc.basename].add('inline')
+                elif doc.type == Type.SCHEMA:
+                    localDocs[doc.basename].add('schema')
+                elif doc.type == Type.LINKBASE:
+                    linkbaseIdentifed = False
+                    for child in doc.xmlRootElement.iterchildren():
+                        linkbaseLocalDocumentsKey = LINK_QNAME_TO_LOCAL_DOCUMENTS_LINKBASE_TYPE.get(child.qname)
+                        if linkbaseLocalDocumentsKey is not None:
+                            localDocs[doc.basename].add(linkbaseLocalDocumentsKey)
+                            linkbaseIdentifed = True
+                    if not linkbaseIdentifed:
+                        localDocs[doc.basename].add(UNRECOGNIZED_LINKBASE_LOCAL_DOCUMENTS_TYPE)
+            self.currentReportData["localDocs"] = {
+                localDoc: sorted(docTypes)
+                for localDoc, docTypes in localDocs.items()
+            }
+
+        if docSetFiles is not None:
+            self.currentReportData["docSetFiles"] = list(urllib.parse.quote(f) for f in docSetFiles)
 
         self.taxonomyData["prefixes"] = self.nsmap.prefixmap
         self.taxonomyData["roles"] = self.roleMap.prefixmap
-        self.taxonomyData["rels"] = self.getRelationships()
 
         if showValidations:
             self.taxonomyData["validation"] = self.validationErrors()
 
-        dts.info("viewer:info", "Creating iXBRL viewer")
-        if dts.modelDocument.type == Type.INLINEXBRLDOCUMENTSET:
-            # Sort by object index to preserve order in which files were specified.
-            xmlDocsByFilename = {
-                os.path.basename(self.outputFilename(doc.filepath)): deepcopy(doc.xmlDocument)
-                for doc in sorted(dts.modelDocument.referencesDocument.keys(), key=lambda x: x.objectIndex)
-            }
-            docSetFiles = list(xmlDocsByFilename.keys())
-
-            if useStubViewer:
-                xmlDocument = self.getStubDocument()
-                iv.addFile(iXBRLViewerFile(DEFAULT_OUTPUT_NAME, xmlDocument))
-            else:
-                xmlDocument = next(iter(xmlDocsByFilename.values()))
-
-            for filename, docSetXMLDoc in xmlDocsByFilename.items():
-                iv.addFile(iXBRLViewerFile(filename, docSetXMLDoc))
-
-        elif useStubViewer:
-            xmlDocument = self.getStubDocument()
-            filename = self.outputFilename(os.path.basename(dts.modelDocument.filepath))
-            docSetFiles = [ filename ]
-            iv.addFile(iXBRLViewerFile(DEFAULT_OUTPUT_NAME, xmlDocument))
-            iv.addFile(iXBRLViewerFile(filename, dts.modelDocument.xmlDocument))
-
-        else:
-            xmlDocument = deepcopy(dts.modelDocument.xmlDocument)
-            iv.addFile(iXBRLViewerFile('xbrlviewer.html', xmlDocument))
-
         if packageDownloadURL is not None:
             self.taxonomyData["filingDocuments"] = packageDownloadURL
-        elif os.path.dirname(self.dts.modelDocument.filepath).endswith('.zip'):
+        elif len(self.reports) == 1 and os.path.dirname(self.reports[0].modelDocument.filepath).endswith('.zip'):
             filingDocZipPath = os.path.dirname(self.dts.modelDocument.filepath)
             filingDocZipName = os.path.basename(filingDocZipPath)
             iv.addFilingDoc(filingDocZipPath)
             self.taxonomyData["filingDocuments"] = filingDocZipName
 
-        localDocs = defaultdict(set)
-        for path, doc in dts.urlDocs.items():
-            if isHttpUrl(path):
-                continue
-            if doc.type in (Type.INLINEXBRL, Type.INLINEXBRLDOCUMENTSET):
-                localDocs[doc.basename].add('inline')
-            elif doc.type == Type.SCHEMA:
-                localDocs[doc.basename].add('schema')
-            elif doc.type == Type.LINKBASE:
-                linkbaseIdentifed = False
-                for child in doc.xmlRootElement.iterchildren():
-                    linkbaseLocalDocumentsKey = LINK_QNAME_TO_LOCAL_DOCUMENTS_LINKBASE_TYPE.get(child.qname)
-                    if linkbaseLocalDocumentsKey is not None:
-                        localDocs[doc.basename].add(linkbaseLocalDocumentsKey)
-                        linkbaseIdentifed = True
-                if not linkbaseIdentifed:
-                    localDocs[doc.basename].add(UNRECOGNIZED_LINKBASE_LOCAL_DOCUMENTS_TYPE)
-        self.taxonomyData["localDocs"] = {
-            localDoc: sorted(docTypes)
-            for localDoc, docTypes in localDocs.items()
-        }
-
-        if docSetFiles is not None:
-            self.taxonomyData["docSetFiles"] = list(urllib.parse.quote(f) for f in docSetFiles)
 
         if not self.addViewerToXMLDocument(xmlDocument, scriptUrl):
             return None

From 730bdf9fa77244d5b4e7c8a5926af2bf350d73c3 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Tue, 19 Sep 2023 23:47:19 +0100
Subject: [PATCH 02/32] Multi-report - WIP

---
 iXBRLViewerPlugin/iXBRLViewer.py              |  5 ++-
 iXBRLViewerPlugin/viewer/src/js/fact.js       |  4 +-
 .../viewer/src/js/ixbrlviewer.js              |  6 ++-
 iXBRLViewerPlugin/viewer/src/js/report.js     | 35 +++++++++-------
 iXBRLViewerPlugin/viewer/src/js/util.js       |  7 ++++
 iXBRLViewerPlugin/viewer/src/js/viewer.js     | 40 ++++++++++---------
 6 files changed, 59 insertions(+), 38 deletions(-)

diff --git a/iXBRLViewerPlugin/iXBRLViewer.py b/iXBRLViewerPlugin/iXBRLViewer.py
index 5f7ed4a4e..dc4c7a1e8 100644
--- a/iXBRLViewerPlugin/iXBRLViewer.py
+++ b/iXBRLViewerPlugin/iXBRLViewer.py
@@ -443,6 +443,7 @@ def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool
                     filename = "xbrlviewer.html"
                 else:
                     filename = self.outputFilename(os.path.basename(report.modelDocument.filepath))
+                    docSetFiles = [ filename ]
                 if xmlDocument is None:
                     xmlDocument = deepcopy(report.modelDocument.xmlDocument)
                     iv.addFile(iXBRLViewerFile(filename, xmlDocument))
@@ -471,8 +472,8 @@ def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool
                 for localDoc, docTypes in localDocs.items()
             }
 
-        if docSetFiles is not None:
-            self.currentReportData["docSetFiles"] = list(urllib.parse.quote(f) for f in docSetFiles)
+            if docSetFiles is not None:
+                self.currentReportData["docSetFiles"] = list(urllib.parse.quote(f) for f in docSetFiles)
 
         self.taxonomyData["prefixes"] = self.nsmap.prefixmap
         self.taxonomyData["roles"] = self.roleMap.prefixmap
diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.js b/iXBRLViewerPlugin/viewer/src/js/fact.js
index 685937ab7..c5d66bcf6 100644
--- a/iXBRLViewerPlugin/viewer/src/js/fact.js
+++ b/iXBRLViewerPlugin/viewer/src/js/fact.js
@@ -9,8 +9,8 @@ import Decimal from "decimal.js";
 
 export class Fact {
     
-    constructor(report, factId) {
-        this.f = report.data.facts[factId];
+    constructor(report, factId, factData) {
+        this.f = factData;
         this.ixNode = report.getIXNodeForItemId(factId);
         this._report = report;
         this.id = factId;
diff --git a/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js b/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
index e3d709cfe..d92bcb019 100644
--- a/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
+++ b/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
@@ -137,7 +137,9 @@ iXBRLViewer.prototype._loadInspectorHTML = function () {
 iXBRLViewer.prototype._reparentDocument = function () {
     var iframeContainer = $('#ixv #iframe-container');
 
-    var iframe = $('<iframe title="iXBRL document view"/>').appendTo(iframeContainer)[0];
+    var iframe = $('<iframe title="iXBRL document view"/>')
+        .data("report-index", 0)
+        .appendTo(iframeContainer)[0];
 
     var doc = iframe.contentDocument || iframe.contentWindow.document;
     doc.open();
@@ -221,7 +223,7 @@ iXBRLViewer.prototype.load = function () {
         const ds = report.documentSetFiles();
         var hasExternalIframe = false;
         for (var i = stubViewer ? 0 : 1; i < ds.length; i++) {
-            const iframe = $("<iframe />").attr("src", ds[i]).appendTo("#ixv #iframe-container");
+            const iframe = $("<iframe />").attr("src", ds[i].file).data("report-index", ds[i].index).appendTo("#ixv #iframe-container");
             iframes = iframes.add(iframe);
             hasExternalIframe = true;
         }
diff --git a/iXBRLViewerPlugin/viewer/src/js/report.js b/iXBRLViewerPlugin/viewer/src/js/report.js
index c8b3ed080..36dffc667 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.js
@@ -6,7 +6,7 @@ import { QName } from "./qname.js"
 import { Concept } from "./concept.js";
 import { Unit } from "./unit";
 import { ViewerOptions } from "./viewerOptions.js";
-import { setDefault, titleCase } from "./util.js";
+import { setDefault, titleCase, viewerUniqueId } from "./util.js";
 import $ from 'jquery'
 import i18next from "i18next";
 
@@ -35,8 +35,11 @@ iXBRLReport.prototype._initialize = function () {
     fnorder.sort((a,b) => this._ixNodeMap[a].docOrderindex - this._ixNodeMap[b].docOrderindex);
 
     // Create Fact objects for all facts.
-    for (const id in this.data.facts) {
-        this._items[id] = new Fact(this, id);
+    for (const [reportIndex, report] of this.reportsData().entries()) {
+        for (const [id, factData] of Object.entries(report.facts)) {
+            const vuid = viewerUniqueId(reportIndex, id);
+            this._items[vuid] = new Fact(this, vuid, factData);
+        }
     }
 
     // Now resolve footnote references, creating footnote objects for "normal"
@@ -44,17 +47,17 @@ iXBRLReport.prototype._initialize = function () {
     //
     // Associate source facts with target footnote/facts to allow two way
     // navigation.
-    for (const id in this.data.facts) {
-        const f = this._items[id];
-        const fns = this.data.facts[id].fn || [];
+    for (const [id, fact] of Object.entries(this._items)) {
+        const fns = fact.fn || [];
         fns.forEach((fnid) => {
-            var fn = this._items[fnid];
+            const fnvuid = viewerUniqueId(fnid);
+            var fn = this._items[fnvuid];
             if (fn === undefined) {
-                fn = new Footnote(this, fnid, "Footnote " + (fnorder.indexOf(fnid) + 1));
-                this._items[fnid] = fn;
+                fn = new Footnote(this, fnid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
+                this._items[fnvuid] = fn;
             }
             // Associate fact with footnote
-            fn.addLinkedFact(f);
+            fn.addLinkedFact(fact);
         });
     }
 }
@@ -314,6 +317,7 @@ iXBRLReport.prototype.relationshipGroupRoots = function(arcrole, elr) {
 }
 
 iXBRLReport.prototype.getAlignedFacts = function(f, coveredAspects) {
+    // XXX this.facts() call
     var all = this.facts();
     var aligned = [];
     if (!coveredAspects) {
@@ -349,6 +353,7 @@ iXBRLReport.prototype.setViewerOptions = function (vo) {
 
 iXBRLReport.prototype.namespaceGroups = function () {
     var counts = {};
+    // XXX this.facts() call
     $.each(this.facts(), function (i, f) {
         counts[f.conceptQName().prefix] = counts[f.conceptQName().prefix] || 0;
         counts[f.conceptQName().prefix]++;
@@ -388,11 +393,13 @@ iXBRLReport.prototype.localDocuments = function() {
     return this.data.localDocs;
 }
 
+iXBRLReport.prototype.reportsData = function() {
+    return this.data.reports ?? [ this.data ];
+}
+
+// Returns an array (one per report) of arrays (one per document set file)
 iXBRLReport.prototype.documentSetFiles = function() {
-    if (this.data.docSetFiles === undefined) {
-        return []
-    }
-    return this.data.docSetFiles;
+    return this.reportsData().map((x, n) => (x.docSetFiles ?? []).map(file => ({ index: n, file: file }))).flat();
 }
 
 iXBRLReport.prototype.isDocumentSet = function() {
diff --git a/iXBRLViewerPlugin/viewer/src/js/util.js b/iXBRLViewerPlugin/viewer/src/js/util.js
index c571b590d..21ffebef6 100644
--- a/iXBRLViewerPlugin/viewer/src/js/util.js
+++ b/iXBRLViewerPlugin/viewer/src/js/util.js
@@ -160,3 +160,10 @@ export function isTransparent(rgba) {
     const val = parseFloat(rgba.split(",")[3]);
     return !isNaN(val) && val < 0.1;
 }
+
+export function viewerUniqueId(reportIndex, id) {
+    if (id === null) {
+        return null;
+    }
+    return reportIndex.toString() + "-" + id;
+}
diff --git a/iXBRLViewerPlugin/viewer/src/js/viewer.js b/iXBRLViewerPlugin/viewer/src/js/viewer.js
index 891ebf832..47a4afe50 100644
--- a/iXBRLViewerPlugin/viewer/src/js/viewer.js
+++ b/iXBRLViewerPlugin/viewer/src/js/viewer.js
@@ -3,7 +3,7 @@
 import $ from 'jquery'
 import { numberMatchSearch, fullDateMatch } from './number-matcher.js'
 import { TableExport } from './tableExport.js'
-import { escapeRegex } from './util.js'
+import { escapeRegex, viewerUniqueId } from './util.js'
 import { IXNode } from './ixnode.js';
 import { setDefault, runGenerator } from './util.js';
 import { DocOrderIndex } from './docOrderIndex.js';
@@ -65,7 +65,8 @@ export class Viewer {
 
                     viewer._iframes.each(function (docIndex) { 
                         $(this).data("selected", docIndex == viewer._currentDocumentIndex);
-                        viewer._preProcessiXBRL($(this).contents().find("body").get(0), docIndex);
+                        const reportIndex = $(this).data("report-index");
+                        viewer._preProcessiXBRL($(this).contents().find("body").get(0), reportIndex, docIndex);
                     });
 
                     /* Call plugin promise for each document in turn */
@@ -299,18 +300,21 @@ export class Viewer {
         const nextContinuationMap = {};
         // map of items in default target document to all their continuations
         const itemContinuationMap = {};
-        this._iframes.contents().find("body *").each(function () {
-            const name = localName(this.nodeName).toUpperCase();
-            if (['NONNUMERIC', 'NONFRACTION', 'FOOTNOTE', 'CONTINUATION'].includes(name)) {
-                const nodeId = this.getAttribute('id');
-                const continuedAtId = this.getAttribute("continuedAt");
-                if (continuedAtId !== null) {
-                    nextContinuationMap[nodeId] = continuedAtId;
-                }
-                if (name != 'CONTINUATION' && !this.hasAttribute('target')) {
-                    itemContinuationMap[nodeId] = [];
+        this._iframes.each((n, iframe) => {
+            const reportIndex = $(iframe).data("report-index");
+            $(iframe).contents().find("body *").each((m, node) => {
+                const name = localName(node.nodeName).toUpperCase();
+                if (['NONNUMERIC', 'NONFRACTION', 'FOOTNOTE', 'CONTINUATION'].includes(name)) {
+                    const nodeId = viewerUniqueId(reportIndex, node.getAttribute('id'));
+                    const continuedAtId = viewerUniqueId(reportIndex, node.getAttribute("continuedAt"));
+                    if (continuedAtId !== null) {
+                        nextContinuationMap[nodeId] = continuedAtId;
+                    }
+                    if (name != 'CONTINUATION' && !node.hasAttribute('target')) {
+                        itemContinuationMap[nodeId] = [];
+                    }
                 }
-            }
+            });
         });
 
         // Map of continuation IDs to list of (default target doc) items that
@@ -359,7 +363,7 @@ export class Viewer {
     // Viewer._docOrderItemIndex is a DocOrderIndex object that maintains a list of
     // fact and footnotes in document order.
     //
-    _preProcessiXBRL(n, docIndex, inHidden) {
+    _preProcessiXBRL(n, reportIndex, docIndex, inHidden) {
         const name = localName(n.nodeName).toUpperCase();
         const isFootnote = name === 'FOOTNOTE';
         const isContinuation = name === 'CONTINUATION';
@@ -370,7 +374,7 @@ export class Viewer {
             // Ignore iXBRL elements that are not in the default target document, as
             // the viewer builder does not handle these, and the builder does not
             // ensure that they have ID attributes.
-            const id = n.getAttribute("id");
+            const id = viewerUniqueId(reportIndex, n.getAttribute("id"));
             if (((isFact || isFootnote) && !n.hasAttribute("target"))
                 || (isContinuation && this.continuationOfMap[id] !== undefined)) {
                 var nodes;
@@ -449,7 +453,7 @@ export class Viewer {
                 }
             }
         }
-        this._preProcessChildNodes(n, docIndex, inHidden);
+        this._preProcessChildNodes(n, reportIndex, docIndex, inHidden);
     }
 
     _getIXHiddenLinkStyle(domNode) {
@@ -463,9 +467,9 @@ export class Viewer {
         return null;
     }
 
-    _preProcessChildNodes(domNode, docIndex, inHidden) {
+    _preProcessChildNodes(domNode, reportIndex, docIndex, inHidden) {
         for (const childNode of domNode.childNodes) {
-            this._preProcessiXBRL(childNode, docIndex, inHidden);
+            this._preProcessiXBRL(childNode, reportIndex, docIndex, inHidden);
         }
     }
 

From a6b50926344643a74a303bc8c75ad9a267b112c9 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Wed, 20 Sep 2023 21:39:18 +0100
Subject: [PATCH 03/32] Further WIP

---
 iXBRLViewerPlugin/viewer/src/js/concept.js |  3 ++-
 iXBRLViewerPlugin/viewer/src/js/report.js  | 29 +++++++++++++---------
 iXBRLViewerPlugin/viewer/src/js/viewer.js  |  4 +--
 3 files changed, 21 insertions(+), 15 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/concept.js b/iXBRLViewerPlugin/viewer/src/js/concept.js
index 4a59f55a5..e322549d1 100644
--- a/iXBRLViewerPlugin/viewer/src/js/concept.js
+++ b/iXBRLViewerPlugin/viewer/src/js/concept.js
@@ -4,7 +4,8 @@ import $ from 'jquery'
 
 export class Concept {
     constructor(report, name) {
-        this._c = report.data.concepts[name] || {};
+        // XXX hard coded to first report
+        this._c = report.reportsData()[0].concepts[name] || {};
     }
 
     /*
diff --git a/iXBRLViewerPlugin/viewer/src/js/report.js b/iXBRLViewerPlugin/viewer/src/js/report.js
index 36dffc667..55378f6e4 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.js
@@ -93,7 +93,8 @@ iXBRLReport.prototype.isCalculationSummation = function(c) {
 iXBRLReport.prototype.getLabel = function(c, rolePrefix, showPrefix) {
     rolePrefix = rolePrefix || 'std';
     var lang = this._viewerOptions.language;
-    const concept = this.data.concepts[c];
+    // XXX hard coded to first report
+    const concept = this.reportsData()[0].concepts[c];
     if (concept === undefined) {
         console.log("Attempt to get label for undefined concept: " + c);
         return "<no label>";
@@ -160,7 +161,7 @@ iXBRLReport.prototype.getIXNodeForItemId = function(id) {
 }
 
 iXBRLReport.prototype.facts = function() {
-    return Object.keys(this.data.facts).map(id => this.getItemById(id));
+    return Object.values(this._items).filter(i => i instanceof Fact);
 }
 
 iXBRLReport.prototype.filingDocuments = function() {
@@ -241,7 +242,8 @@ iXBRLReport.prototype.qname = function(v) {
 
 iXBRLReport.prototype.getChildRelationships = function(conceptName, arcrole) {
     var rels = {}
-    const elrs = this.data.rels[arcrole] || {};
+    //  XXX hard-coded to first report
+    const elrs = this.reportsData()[0].rels[arcrole] || {};
     for (const elr in elrs) {
         if (conceptName in elrs[elr]) {
             rels[elr] = elrs[elr][conceptName];
@@ -261,7 +263,8 @@ iXBRLReport.prototype.getChildRelationships = function(conceptName, arcrole) {
 iXBRLReport.prototype._reverseRelationships = function(arcrole) {
     if (!(arcrole in this._reverseRelationshipCache)) {
         const rrc = {};
-        const elrs = this.data.rels[arcrole] || {};
+        // XXX hard-coded to first report
+        const elrs = this.reportsData()[0].rels[arcrole] || {};
         for (const [elr, relSet] of Object.entries(elrs)) {
             for (const [src, rels] of Object.entries(relSet)) {
                 for (const r of rels) {
@@ -294,7 +297,8 @@ iXBRLReport.prototype.getParentRelationshipsInGroup = function(conceptName, arcr
 iXBRLReport.prototype.dimensionDefault = function(dimensionName) {
     // ELR is irrelevant for dimension-default relationships, so check all of
     // them, and return the first (illegal for there to be more than one
-    for (const rel of Object.values(this.data.rels["d-d"] || {})) {
+    // XXX hard coded to first report
+    for (const rel of Object.values(this.reportsData()[0].rels["d-d"] || {})) {
         if (dimensionName in rel) {
             return rel[dimensionName][0].t;
         }
@@ -303,12 +307,14 @@ iXBRLReport.prototype.dimensionDefault = function(dimensionName) {
 }
 
 iXBRLReport.prototype.relationshipGroups = function(arcrole) {
-    return Object.keys(this.data.rels[arcrole] || {});
+    // XXX hard coded to first document
+    return Object.keys(this.reportsData()[0].rels[arcrole] || {});
 }
 
 iXBRLReport.prototype.relationshipGroupRoots = function(arcrole, elr) {
     var roots = [];
-    for (const conceptName in this.data.rels[arcrole][elr]) {
+    // XXX hard-coded to first report
+    for (const conceptName in this.reportsData()[0].rels[arcrole][elr]) {
         if (!(elr in this.getParentRelationships(conceptName, arcrole))) {
             roots.push(conceptName);
         }
@@ -317,7 +323,6 @@ iXBRLReport.prototype.relationshipGroupRoots = function(arcrole, elr) {
 }
 
 iXBRLReport.prototype.getAlignedFacts = function(f, coveredAspects) {
-    // XXX this.facts() call
     var all = this.facts();
     var aligned = [];
     if (!coveredAspects) {
@@ -353,7 +358,6 @@ iXBRLReport.prototype.setViewerOptions = function (vo) {
 
 iXBRLReport.prototype.namespaceGroups = function () {
     var counts = {};
-    // XXX this.facts() call
     $.each(this.facts(), function (i, f) {
         counts[f.conceptQName().prefix] = counts[f.conceptQName().prefix] || 0;
         counts[f.conceptQName().prefix]++;
@@ -374,7 +378,8 @@ iXBRLReport.prototype.getRoleLabel = function(rolePrefix, viewerOptions) {
      *
      * Returns the ELR URI if there is no label
      */
-    const labels = this.data.roleDefs[rolePrefix];
+    // XXX hard-coded to first report
+    const labels = this.reportsData()[0].roleDefs[rolePrefix];
     if (labels !== undefined) {
         const label = labels["en"];
         // Earlier versions of the generator added a "null" label if no labels
@@ -397,7 +402,6 @@ iXBRLReport.prototype.reportsData = function() {
     return this.data.reports ?? [ this.data ];
 }
 
-// Returns an array (one per report) of arrays (one per document set file)
 iXBRLReport.prototype.documentSetFiles = function() {
     return this.reportsData().map((x, n) => (x.docSetFiles ?? []).map(file => ({ index: n, file: file }))).flat();
 }
@@ -407,7 +411,8 @@ iXBRLReport.prototype.isDocumentSet = function() {
 }
 
 iXBRLReport.prototype.usesAnchoring = function() {
-    return this.data.rels["w-n"] !== undefined;
+    // XXX hard-coded to first report
+    return this.reportsData()[0].rels["w-n"] !== undefined;
 }
 
 iXBRLReport.prototype.hasValidationErrors = function() {
diff --git a/iXBRLViewerPlugin/viewer/src/js/viewer.js b/iXBRLViewerPlugin/viewer/src/js/viewer.js
index 47a4afe50..3db677b7c 100644
--- a/iXBRLViewerPlugin/viewer/src/js/viewer.js
+++ b/iXBRLViewerPlugin/viewer/src/js/viewer.js
@@ -110,8 +110,8 @@ export class Viewer {
             $('#ixv .ixds-tabs').show();
             for (const [i, doc] of this._report.documentSetFiles().entries()) {
                 $('<div class="tab">')
-                    .text(doc)
-                    .prop('title', doc)
+                    .text(doc.file)
+                    .prop('title', doc.file)
                     .data('ix-doc-id', i)
                     .click(() => this.selectDocument(i))
                     .appendTo($('#ixv #viewer-pane .ixds-tabs .tab-area'));

From 8dd177a0187c78107ab672a6aee4ef2c81960c48 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Fri, 22 Sep 2023 23:22:21 +0100
Subject: [PATCH 04/32] Introduce ReportSet class

---
 iXBRLViewerPlugin/viewer/src/js/concept.js    |   3 +-
 iXBRLViewerPlugin/viewer/src/js/fact.js       |   4 +-
 iXBRLViewerPlugin/viewer/src/js/inspector.js  |  67 ++--
 .../viewer/src/js/ixbrlviewer.js              |  10 +-
 iXBRLViewerPlugin/viewer/src/js/outline.js    |  37 +-
 iXBRLViewerPlugin/viewer/src/js/report.js     | 345 ++++--------------
 iXBRLViewerPlugin/viewer/src/js/reportset.js  | 231 ++++++++++++
 iXBRLViewerPlugin/viewer/src/js/search.js     |  18 +-
 iXBRLViewerPlugin/viewer/src/js/summary.js    |  12 +-
 .../viewer/src/js/tableExport.js              |  12 +-
 iXBRLViewerPlugin/viewer/src/js/viewer.js     |  18 +-
 11 files changed, 399 insertions(+), 358 deletions(-)
 create mode 100644 iXBRLViewerPlugin/viewer/src/js/reportset.js

diff --git a/iXBRLViewerPlugin/viewer/src/js/concept.js b/iXBRLViewerPlugin/viewer/src/js/concept.js
index e322549d1..fddbf4afd 100644
--- a/iXBRLViewerPlugin/viewer/src/js/concept.js
+++ b/iXBRLViewerPlugin/viewer/src/js/concept.js
@@ -4,8 +4,7 @@ import $ from 'jquery'
 
 export class Concept {
     constructor(report, name) {
-        // XXX hard coded to first report
-        this._c = report.reportsData()[0].concepts[name] || {};
+        this._c = report.concepts()[name] || {};
     }
 
     /*
diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.js b/iXBRLViewerPlugin/viewer/src/js/fact.js
index c5d66bcf6..f0eb329d5 100644
--- a/iXBRLViewerPlugin/viewer/src/js/fact.js
+++ b/iXBRLViewerPlugin/viewer/src/js/fact.js
@@ -11,7 +11,7 @@ export class Fact {
     
     constructor(report, factId, factData) {
         this.f = factData;
-        this.ixNode = report.getIXNodeForItemId(factId);
+        this.ixNode = report.reportSet.getIXNodeForItemId(factId);
         this._report = report;
         this.id = factId;
         this.linkedFacts = [];
@@ -323,7 +323,7 @@ export class Fact {
     }
 
     footnotes() {
-        return (this.f.fn || []).map((fn, i) => this._report.getItemById(fn));
+        return (this.f.fn || []).map((fn, i) => this._report.reportSet.getItemById(fn));
     }
 
     isHidden() {
diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index 649900696..d84018bb3 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -61,12 +61,12 @@ export class Inspector {
         });
     }
 
-    initialize(report, viewer) {
+    initialize(reportSet, viewer) {
         const inspector = this;
         this._viewer = viewer;
         return new Promise(function (resolve, reject) {
             inspector._chart = new IXBRLChart();
-            inspector._report = report;
+            inspector._reportSet = reportSet;
             inspector.i18nInit().then((t) => {
                 
                 $(".collapsible-header").on("click", function () { 
@@ -112,13 +112,13 @@ export class Inspector {
 
                 // Listen to messages posted to this window
                 $(window).on("message", (e) => inspector.handleMessage(e));
-                report.setViewerOptions(inspector._viewerOptions);
-                inspector.summary = new DocumentSummary(report);
+                reportSet.setViewerOptions(inspector._viewerOptions);
+                inspector.summary = new DocumentSummary(reportSet);
                 inspector.createSummary()
-                inspector.outline = new DocumentOutline(report);
+                inspector.outline = new DocumentOutline(reportSet);
                 inspector.createOutline();
                 inspector._iv.setProgress(i18next.t("inspector.initializing")).then(() => {
-                    inspector._search = new ReportSearch(report);
+                    inspector._search = new ReportSearch(reportSet);
                     inspector.buildDisplayOptionsMenu();
                     inspector.buildToolbarHighlightMenu();
                     inspector.buildHighlightKey();
@@ -183,12 +183,12 @@ export class Inspector {
 
     buildDisplayOptionsMenu() {
         this._optionsMenu.reset();
-        if (this._report) {
+        if (this._reportSet) {
             const dl = this.selectDefaultLanguage();
-            this._optionsMenu.addCheckboxGroup(this._report.availableLanguages(), this._report.languageNames(), dl, (lang) => { this.setLanguage(lang); this.update() }, "select-language");
+            this._optionsMenu.addCheckboxGroup(this._reportSet.availableLanguages(), this._reportSet.languageNames(), dl, (lang) => { this.setLanguage(lang); this.update() }, "select-language");
             this.setLanguage(dl);
-            if (this._report.filingDocuments()) {
-                this._optionsMenu.addDownloadButton("Download filing documents", this._report.filingDocuments())
+            if (this._reportSet.filingDocuments()) {
+                this._optionsMenu.addDownloadButton("Download filing documents", this._reportSet.filingDocuments())
             }
         }
         this._iv.callPluginMethod("extendDisplayOptionsMenu", this._optionsMenu);
@@ -232,7 +232,7 @@ export class Inspector {
                 "Untagged Dates",
             ]
         } else {
-            key = this._report.namespaceGroups();
+            key = this._reportSet.namespaceGroups();
         }
         this._iv.callPluginMethod("extendHighlightKey", key);
 
@@ -246,7 +246,7 @@ export class Inspector {
     }
 
     highlightAllTags(checked) {
-        this._viewer.highlightAllTags(checked, this._report.namespaceGroups());
+        this._viewer.highlightAllTags(checked, this._reportSet.namespaceGroups());
     }
 
     factListRow(f) {
@@ -343,16 +343,16 @@ export class Inspector {
                 .text(this._search.periods[key])
                 .appendTo('#search-filter-period select');
         }
-        for (const prefix of this._report.getUsedPrefixes()) {
+        for (const prefix of this._reportSet.getUsedPrefixes()) {
             $("<option>")
                 .attr("value", prefix)
-                .text(`${prefix} (${this._report.prefixMap()[prefix]})`)
+                .text(`${prefix} (${this._reportSet.prefixMap()[prefix]})`)
                 .appendTo('#search-filter-namespaces select');
         }
-        for (const unit of this._report.getUsedUnits()) {
+        for (const unit of this._reportSet.getUsedUnits()) {
             $("<option>")
                     .attr("value", unit)
-                    .text(`${this._report.getUnit(unit)?.label()} (${unit})`)
+                    .text(`${this._reportSet.getUnit(unit)?.label()} (${unit})`)
                     .appendTo('#search-filter-units select');
         }
         const scalesOptions = this._getScalesOptions();
@@ -366,7 +366,7 @@ export class Inspector {
 
     _getScalesOptions() {
         const scalesOptions = {}
-        const usedScalesMap = this._report.getUsedScalesMap();
+        const usedScalesMap = this._reportSet.getUsedScalesMap();
         Object.keys(usedScalesMap).sort().forEach(scale => {
             const labels = Array.from(usedScalesMap[scale]).sort();
             if (labels.length > 0) {
@@ -561,7 +561,8 @@ export class Inspector {
             const container = $('<div class="fact-list"></div>').appendTo($('.outline .body'));
             for (const elr of this.outline.sortedSections()) {
                 $('<div class="fact-list-item"></div>')
-                    .text(this._report.getRoleLabel(elr))
+                    // XXX hard-coded to first report
+                    .text(this._reportSet.reports[0].getRoleLabel(elr))
                     .click(() => this.selectItem(this.outline.sections[elr].id))
                     .dblclick(() => $('#inspector').removeClass("outline-mode"))
                     .mousedown((e) => {
@@ -579,7 +580,7 @@ export class Inspector {
         $('.fact-groups').empty();
         for (const elr of this.outline.groupsForFact(cf)) {
             $('<div class="fact-list-item"></div>')
-                .text(this._report.getRoleLabel(elr))
+                .text(cf.report().getRoleLabel(elr))
                 .click(() => this.selectItem(this.outline.sections[elr].id))
                 .appendTo($('.fact-groups'));
         }
@@ -608,8 +609,8 @@ export class Inspector {
         const html = $("<ul></ul>");
         if (anchors.length > 0) {
             for (const c of anchors) {
-                const otherFacts = this._report.getAlignedFacts(fact, { "c": c });
-                const label = this._report.getLabel(c, "std", true);
+                const otherFacts = fact.report().getAlignedFacts(fact, { "c": c });
+                const label = fact.report().getLabel(c, "std", true);
 
                 $("<li></li>")
                     .appendTo(html)
@@ -625,7 +626,7 @@ export class Inspector {
     }
 
     updateAnchoring(fact) {
-        if (!this._report.usesAnchoring()) {
+        if (!this._reportSet.usesAnchoring()) {
             $('.anchoring').hide();
         }
         else {
@@ -673,7 +674,7 @@ export class Inspector {
         if (!elr) {
             elr = calc.bestELRForFactSet(tableFacts);
         }
-        const report = this._report;
+        const report = fact.report();
         const inspector = this;
         const a = new Accordian();
 
@@ -775,7 +776,7 @@ export class Inspector {
     getPeriodIncrease(fact) {
         let s = "";
         if (fact.isNumeric()) {
-            const otherFacts = this._report.getAlignedFacts(fact, {"p":null });
+            const otherFacts = fact.report().getAlignedFacts(fact, {"p":null });
             var mostRecent;
             if (fact.periodTo()) {
                 for (const other of otherFacts) {
@@ -785,7 +786,7 @@ export class Inspector {
                 }
             }
             if (mostRecent) {
-                const allMostRecent = this._report.getAlignedFacts(mostRecent);
+                const allMostRecent = fact.report().getAlignedFacts(mostRecent);
                 s = $("<span></span>")
                         .text(this.describeChange(mostRecent, fact))
                         .append(this.factLinkHTML(mostRecent.periodString(), allMostRecent));
@@ -1027,12 +1028,12 @@ export class Inspector {
      */
     selectItem(id, itemIdList, noScroll) {
         if (itemIdList === undefined) {
-            this._currentItemList = [ this._report.getItemById(id) ];
+            this._currentItemList = [ this._reportSet.getItemById(id) ];
         }
         else {
             this._currentItemList = [];
             for (const itemId of itemIdList) {
-                this._currentItemList.push(this._report.getItemById(itemId));
+                this._currentItemList.push(this._reportSet.getItemById(itemId));
             }
         }
         this.switchItem(id, noScroll);
@@ -1048,7 +1049,7 @@ export class Inspector {
      */
     switchItem(id, noScroll) {
         if (id !== null) {
-            this._currentItem = this._report.getItemById(id);
+            this._currentItem = this._reportSet.getItemById(id);
             if (!noScroll) {
                 this._viewer.showItemById(id);
             }
@@ -1074,7 +1075,7 @@ export class Inspector {
     }
 
     selectDefaultLanguage() {
-        const al = this._report.availableLanguages();
+        const al = this._reportSet.availableLanguages();
         for (const pl of this.preferredLanguages()) {
             for (const l of al) {
                 if (l.toLowerCase() == pl.toLowerCase()) {
@@ -1082,7 +1083,7 @@ export class Inspector {
                 }
             }
         }
-        return this._report.availableLanguages()[0];
+        return this._reportSet.availableLanguages()[0];
     }
 
     setLanguage(lang) {
@@ -1091,18 +1092,18 @@ export class Inspector {
 
     showValidationReport() {
         const vr = new ValidationReportDialog();
-        vr.displayErrors(this._report.data.validation);
+        vr.displayErrors(this._reportSet.validation());
         vr.show();
     }
 
     setupValidationReportIcon() {
-        if (this._report.hasValidationErrors()) {
+        if (this._reportSet.hasValidationErrors()) {
             $("#ixv .validation-warning").show().on("click", () => this.showValidationReport());
         }
     }
 
     showValidationWarning() {
-        if (this._report.hasValidationErrors()) {
+        if (this._reportSet.hasValidationErrors()) {
             const message = $("<div></div>").append("<p>This report contains <b>XBRL validation errors</b>.  These errors may prevent this document from opening correctly in other XBRL software.</p>");
             const mb = new MessageBox("Validation errors", message, "View Details", "Dismiss");
             mb.show(() => this.showValidationReport());
diff --git a/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js b/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
index d92bcb019..76f1187a6 100644
--- a/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
+++ b/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
@@ -2,7 +2,7 @@
 
 import interact from 'interactjs'
 import $ from 'jquery'
-import { iXBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 import { Viewer, DocumentTooLargeError } from "./viewer.js";
 import { Inspector } from "./inspector.js";
 
@@ -219,8 +219,8 @@ iXBRLViewer.prototype.load = function () {
             $('#ixv .loader').removeClass("loading");
             return;
         }
-        const report = new iXBRLReport(parsedTaxonomyData);
-        const ds = report.documentSetFiles();
+        const reportSet = new ReportSet(parsedTaxonomyData);
+        const ds = reportSet.documentSetFiles();
         var hasExternalIframe = false;
         for (var i = stubViewer ? 0 : 1; i < ds.length; i++) {
             const iframe = $("<iframe />").attr("src", ds[i].file).data("report-index", ds[i].index).appendTo("#ixv #iframe-container");
@@ -246,10 +246,10 @@ iXBRLViewer.prototype.load = function () {
                 if (complete) {
                     clearInterval(timer);
 
-                    var viewer = iv.viewer = new Viewer(iv, iframes, report);
+                    var viewer = iv.viewer = new Viewer(iv, iframes, reportSet);
 
                     viewer.initialize()
-                        .then(() => inspector.initialize(report, viewer))
+                        .then(() => inspector.initialize(reportSet, viewer))
                         .then(() => {
                             interact('#viewer-pane').resizable({
                                 edges: { left: false, right: ".resize", bottom: false, top: false},
diff --git a/iXBRLViewerPlugin/viewer/src/js/outline.js b/iXBRLViewerPlugin/viewer/src/js/outline.js
index 8e6326429..eb163f79d 100644
--- a/iXBRLViewerPlugin/viewer/src/js/outline.js
+++ b/iXBRLViewerPlugin/viewer/src/js/outline.js
@@ -7,15 +7,16 @@ import $ from 'jquery'
 // fact participates in (see factInGroup()) and then finding the longest
 // continuous run of facts in document order that participate in each ELR.
 export class DocumentOutline {
-    constructor(report) {
-        this._report = report;
-        const facts = report.facts().sort((a, b) => a.ixNode.docOrderindex - b.ixNode.docOrderindex);
+    constructor(reportSet) {
+        this._reportSet = reportSet;
+        const facts = reportSet.facts().sort((a, b) => a.ixNode.docOrderindex - b.ixNode.docOrderindex);
         const runLength = {};
         const runStart = {};
         const longestRun = {};
         const longestRunStart = {};
         this._buildDimensionMap();
-        const elrs = report.relationshipGroups("pres");
+        // XXX Hard coded to first report
+        const elrs = reportSet.reports[0].relationshipGroups("pres");
         for (const f of facts) {
             if (f.isHidden()) {
                 continue;
@@ -57,7 +58,9 @@ export class DocumentOutline {
     factInGroup(fact, elr) {
         // Roots are abstract so no need to check for concepts with outgoing
         // relationships only.
-        if (this._report.getParentRelationshipsInGroup(fact.conceptName(), "pres", elr).length == 0) {
+
+        // XXX
+        if (this._reportSet.reports[0].getParentRelationshipsInGroup(fact.conceptName(), "pres", elr).length == 0) {
             return false;
         }
         const fd = fact.dimensions();
@@ -97,18 +100,21 @@ export class DocumentOutline {
     //   between presentation and dimensional ELRs.
     //
     _buildDimensionMap() {
-        const groups = this._report.relationshipGroups("pres");
+        // XXX hard-coded to first report
+        const groups = this._reportSet.reports[0].relationshipGroups("pres");
         this.dimensionMap = {};
         for (const elr of groups) {
             this.dimensionMap[elr] = {};
-            for (const root of this._report.relationshipGroupRoots("pres", elr)) {
+            // XXX
+            for (const root of this._reportSet.reports[0].relationshipGroupRoots("pres", elr)) {
                 this.buildDimensionMapFromSubTree("pres", elr, null, root);
             }
         }
     }
 
     buildDimensionMapFromSubTree(arcrole, elr, dimension, conceptName) {
-        const c = this._report.getConcept(conceptName);
+        // XXX
+        const c = this._reportSet.reports[0].getConcept(conceptName);
         if (c.isTypedDimension()) {
             this.dimensionMap[elr][conceptName] = { typed: true };
             return
@@ -117,13 +123,15 @@ export class DocumentOutline {
             dimension = conceptName;
             this.dimensionMap[elr][dimension] = { members: {}, allowDefault: false};
         }
-        var children = this._report.getChildRelationships(conceptName, arcrole);
+        // XXX
+        var children = this._reportSet.reports[0].getChildRelationships(conceptName, arcrole);
         if (!(elr in children)) {
             return
         }
         for (var rel of children[elr]) {
             if (dimension) {
-                if (this._report.dimensionDefault(dimension) == rel.t) {
+                // XXX
+                if (this._reportSet.reports[0].dimensionDefault(dimension) == rel.t) {
                     this.dimensionMap[elr][dimension].allowDefault = true;
                 }
                 else {
@@ -137,7 +145,8 @@ export class DocumentOutline {
     // Returns a list of presentation groups that this fact participates in
     groupsForFact(fact) {
         var factGroups = [];
-        for (const group of this._report.relationshipGroups("pres")) {
+        // XXX
+        for (const group of this._reportSet.reports[0].relationshipGroups("pres")) {
             if (this.factInGroup(fact, group)) {
                 factGroups.push(group);
             }
@@ -152,7 +161,9 @@ export class DocumentOutline {
     sortedSections() {
         const sections = Object.keys(this.sections);
         const re = /\(parenthetical\)\s*$/i;
-        const filteredSections = sections.filter(s => !re.test(this._report.getRoleLabel(s)));
-        return filteredSections.sort((a, b) => this._report.getRoleLabel(a).localeCompare(this._report.getRoleLabel(b)));
+        // XXX
+        const filteredSections = sections.filter(s => !re.test(this._reportSet.reports[0].getRoleLabel(s)));
+        // XXX
+        return filteredSections.sort((a, b) => this._reportSet.reports[0].getRoleLabel(a).localeCompare(this._reportSet.reports[0].getRoleLabel(b)));
     }
 }
diff --git a/iXBRLViewerPlugin/viewer/src/js/report.js b/iXBRLViewerPlugin/viewer/src/js/report.js
index 55378f6e4..5337deb4c 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.js
@@ -4,246 +4,36 @@ import { Fact } from "./fact.js"
 import { Footnote } from "./footnote.js"
 import { QName } from "./qname.js"
 import { Concept } from "./concept.js";
-import { Unit } from "./unit";
 import { ViewerOptions } from "./viewerOptions.js";
-import { setDefault, titleCase, viewerUniqueId } from "./util.js";
+import { setDefault, viewerUniqueId } from "./util.js";
 import $ from 'jquery'
 import i18next from "i18next";
 
-export function iXBRLReport (data) {
-    this.data = data;
+export function iXBRLReport(reportSet, reportData) {
+    this.reportSet = reportSet;
+    this._reportData = reportData;
     // A map of IDs to Fact and Footnote objects
-    this._items = {};
-    this._ixNodeMap = {};
     this._viewerOptions = new ViewerOptions();
     this._reverseRelationshipCache = {};
 }
 
-/*
- * Set additional information about facts obtained from parsing the iXBRL.
- */
-iXBRLReport.prototype.setIXNodeMap = function(ixData) {
-    this._ixNodeMap = ixData;
-    this._initialize();
-}
-
-iXBRLReport.prototype._initialize = function () {
-
-    // Build an array of footnotes IDs in document order so that we can assign
-    // numbers to foonotes
-    var fnorder = Object.keys(this._ixNodeMap).filter((id) => this._ixNodeMap[id].footnote);
-    fnorder.sort((a,b) => this._ixNodeMap[a].docOrderindex - this._ixNodeMap[b].docOrderindex);
-
-    // Create Fact objects for all facts.
-    for (const [reportIndex, report] of this.reportsData().entries()) {
-        for (const [id, factData] of Object.entries(report.facts)) {
-            const vuid = viewerUniqueId(reportIndex, id);
-            this._items[vuid] = new Fact(this, vuid, factData);
-        }
-    }
-
-    // Now resolve footnote references, creating footnote objects for "normal"
-    // footnotes, and finding Fact objects for fact->fact footnotes.  
-    //
-    // Associate source facts with target footnote/facts to allow two way
-    // navigation.
-    for (const [id, fact] of Object.entries(this._items)) {
-        const fns = fact.fn || [];
-        fns.forEach((fnid) => {
-            const fnvuid = viewerUniqueId(fnid);
-            var fn = this._items[fnvuid];
-            if (fn === undefined) {
-                fn = new Footnote(this, fnid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
-                this._items[fnvuid] = fn;
-            }
-            // Associate fact with footnote
-            fn.addLinkedFact(fact);
-        });
-    }
-}
-
-iXBRLReport.prototype.isCalculationContributor = function(c) {
-    if (this._calculationContributors === undefined) {
-        if (this.data.rels?.calc) {
-            this._calculationContributors = new Set(Object.values(this.data.rels.calc).flatMap(calculations => {
-                return Object.values(calculations).flatMap(contributors => {
-                    return contributors.map(c => c.t);
-                });
-            }));
-        } else {
-            this._calculationContributors = new Set();
-        }
-    }
-    return this._calculationContributors.has(c);
-}
-
-iXBRLReport.prototype.isCalculationSummation = function(c) {
-    if (this._calculationSummations === undefined) {
-        if (this.data.rels?.calc) {
-            this._calculationSummations = new Set(Object.values(this.data.rels.calc).flatMap(calculations => {
-                return Object.keys(calculations);
-            }));
-        } else {
-            this._calculationSummations = new Set();
-        }
-    }
-    return this._calculationSummations.has(c);
-}
-
-iXBRLReport.prototype.getLabel = function(c, rolePrefix, showPrefix) {
-    rolePrefix = rolePrefix || 'std';
-    var lang = this._viewerOptions.language;
-    // XXX hard coded to first report
-    const concept = this.reportsData()[0].concepts[c];
-    if (concept === undefined) {
-        console.log("Attempt to get label for undefined concept: " + c);
-        return "<no label>";
-    }
-    const labels = concept.labels[rolePrefix]
-    if (labels === undefined || Object.keys(labels).length == 0) {
-        return undefined;
-    }
-    else {
-        var label;
-        if (lang && labels[lang]) {
-            label = labels[lang];
-        }
-        else {
-            // Fall back on English, then any label deterministically.
-            label = labels["en"] || labels["en-us"] || labels[Object.keys(labels).sort()[0]];
-        }
-        if (label === undefined) {
-            return undefined;
-        }
-        var s = '';
-        if (showPrefix && this._viewerOptions.showPrefixes) {
-            s = "(" + this.qname(c).prefix + ") ";
-        }
-        s += label;
-        return s;
-    }
-}
-
-iXBRLReport.prototype.getLabelOrName = function(c, rolePrefix, showPrefix) {
-    const label = this.getLabel(c, rolePrefix, showPrefix);
-    if (label === undefined) {
-        return c;
-    }
-    return label;
-}
-
 iXBRLReport.prototype.availableLanguages = function() {
     if (!this._availableLanguages) {
-        var map = {};
-        $.each(this.data.concepts, function (k,v) {
-            $.each(v.labels, function (rolePrefx, ll) {
-                $.each(ll, function (lang, v) {
-                    map[lang] = 1;
-                });
-            });
-        });
-        this._availableLanguages = Object.keys(map);
-
-    }
-    return this._availableLanguages;
-}
-
-iXBRLReport.prototype.languageNames = function() {
-    return this.data.languages;
-}
-
-iXBRLReport.prototype.getItemById = function(id) {
-    return this._items[id];
-}
-
-iXBRLReport.prototype.getIXNodeForItemId = function(id) {
-    return this._ixNodeMap[id] || {};
-}
-
-iXBRLReport.prototype.facts = function() {
-    return Object.values(this._items).filter(i => i instanceof Fact);
-}
-
-iXBRLReport.prototype.filingDocuments = function() {
-    return this.data.filingDocuments;
-}
-
-iXBRLReport.prototype.prefixMap = function() {
-    return this.data.prefixes;
-}
-
-iXBRLReport.prototype.getUsedPrefixes = function() {
-    if (this._usedPrefixes === undefined) {
-        this._usedPrefixes = new Set(Object.values(this._items)
-                .filter(f => f instanceof Fact)
-                .map(f => f.getConceptPrefix()));
-    }
-    return this._usedPrefixes;
-}
-
-/**
- * Returns a set of OIM format unit strings used by facts on this report. Lazy-loaded.
- * @return {Set[String]} Set of OIM format unit strings
- */
-iXBRLReport.prototype.getUsedUnits = function() {
-    if (this._usedUnits === undefined) {
-        this._usedUnits = new Set(Object.values(this._items)
-                .filter(f => f instanceof Fact)
-                .map(f => f.unit()?.value())
-                .filter(f => f)
-                .sort());
-    }
-    return this._usedUnits;
-}
-
-/**
- * Returns details about the provided unit. Lazy-loaded once per unit.
- * @param  {String} unitKey  Unit in OIM format
- * @return {Unit}  Unit instance corresponding with provided key
- */
-iXBRLReport.prototype.getUnit = function(unitKey) {
-    if (this._unitsMap === undefined) {
-        this._unitsMap = {};
-    }
-    if (this._unitsMap[unitKey] === undefined) {
-        this._unitsMap[unitKey] = new Unit(this, unitKey)
-    }
-    return this._unitsMap[unitKey];
-}
-
-iXBRLReport.prototype.getUsedScalesMap = function() {
-    // Do not lazy load. This is language-dependent so needs to re-evaluate after language changes.
-    const usedScalesMap = {};
-    Object.values(this._items)
-        .filter(f => f instanceof Fact)
-        .forEach(fact => {
-            const scale = fact.scale();
-            if (scale !== null && scale !== undefined) {
-                if (!(scale in usedScalesMap)) {
-                    usedScalesMap[scale] = new Set();
-                }
-                const labels = usedScalesMap[scale];
-                const label = titleCase(fact.getScaleLabel(scale));
-                if (label && !labels.has(label)) {
-                    labels.add(label);
+        this._availableLanguages = new Set()
+        for (const c of Object.values(this._reportData.concepts)) {
+            for (const ll of Object.values(c.labels)) {
+                for (const lang of Object.keys(ll)) {
+                    this._availableLanguages.add(lang);
                 }
             }
-        });
-    return usedScalesMap;
-}
-
-iXBRLReport.prototype.roleMap = function() {
-    return this.data.roles;
-}
-
-iXBRLReport.prototype.qname = function(v) {
-    return new QName(this.prefixMap(), v);
+        }
+    }
+    return this._availableLanguages;
 }
 
 iXBRLReport.prototype.getChildRelationships = function(conceptName, arcrole) {
     var rels = {}
-    //  XXX hard-coded to first report
-    const elrs = this.reportsData()[0].rels[arcrole] || {};
+    const elrs = this._reportData.rels[arcrole] || {};
     for (const elr in elrs) {
         if (conceptName in elrs[elr]) {
             rels[elr] = elrs[elr][conceptName];
@@ -263,8 +53,7 @@ iXBRLReport.prototype.getChildRelationships = function(conceptName, arcrole) {
 iXBRLReport.prototype._reverseRelationships = function(arcrole) {
     if (!(arcrole in this._reverseRelationshipCache)) {
         const rrc = {};
-        // XXX hard-coded to first report
-        const elrs = this.reportsData()[0].rels[arcrole] || {};
+        const elrs = this._reportData.rels[arcrole] || {};
         for (const [elr, relSet] of Object.entries(elrs)) {
             for (const [src, rels] of Object.entries(relSet)) {
                 for (const r of rels) {
@@ -279,7 +68,7 @@ iXBRLReport.prototype._reverseRelationships = function(arcrole) {
 }
 
 iXBRLReport.prototype.getParentRelationships = function(conceptName, arcrole) {
-    var rels = {}
+    const rels = {}
     for (const [elr, relSet] of Object.entries(this._reverseRelationships(arcrole))) {
         if (conceptName in relSet) {
             rels[elr] = relSet[conceptName];
@@ -289,7 +78,6 @@ iXBRLReport.prototype.getParentRelationships = function(conceptName, arcrole) {
 }
 
 iXBRLReport.prototype.getParentRelationshipsInGroup = function(conceptName, arcrole, elr) {
-    var rels = {}
     const relSet = this._reverseRelationships(arcrole)[elr] || {};
     return relSet[conceptName] || [];
 }
@@ -297,8 +85,7 @@ iXBRLReport.prototype.getParentRelationshipsInGroup = function(conceptName, arcr
 iXBRLReport.prototype.dimensionDefault = function(dimensionName) {
     // ELR is irrelevant for dimension-default relationships, so check all of
     // them, and return the first (illegal for there to be more than one
-    // XXX hard coded to first report
-    for (const rel of Object.values(this.reportsData()[0].rels["d-d"] || {})) {
+    for (const rel of Object.values(this._reportData.rels["d-d"] || {})) {
         if (dimensionName in rel) {
             return rel[dimensionName][0].t;
         }
@@ -307,14 +94,12 @@ iXBRLReport.prototype.dimensionDefault = function(dimensionName) {
 }
 
 iXBRLReport.prototype.relationshipGroups = function(arcrole) {
-    // XXX hard coded to first document
-    return Object.keys(this.reportsData()[0].rels[arcrole] || {});
+    return Object.keys(this._reportData.rels[arcrole] || {});
 }
 
 iXBRLReport.prototype.relationshipGroupRoots = function(arcrole, elr) {
-    var roots = [];
-    // XXX hard-coded to first report
-    for (const conceptName in this.reportsData()[0].rels[arcrole][elr]) {
+    const roots = [];
+    for (const conceptName in this._reportData.rels[arcrole][elr]) {
         if (!(elr in this.getParentRelationships(conceptName, arcrole))) {
             roots.push(conceptName);
         }
@@ -323,7 +108,8 @@ iXBRLReport.prototype.relationshipGroupRoots = function(arcrole, elr) {
 }
 
 iXBRLReport.prototype.getAlignedFacts = function(f, coveredAspects) {
-    var all = this.facts();
+    // XXX should filter to current report facts?
+    var all = this.reportSet.facts();
     var aligned = [];
     if (!coveredAspects) {
         coveredAspects = {};
@@ -337,7 +123,7 @@ iXBRLReport.prototype.getAlignedFacts = function(f, coveredAspects) {
 }
 
 iXBRLReport.prototype.deduplicate = function (facts) {
-    var ff = [];
+    const ff = [];
     $.each(facts, function (i, f) {
         var dupe = false;
         $.each(ff, function (j, of) {
@@ -352,20 +138,6 @@ iXBRLReport.prototype.deduplicate = function (facts) {
     return ff;
 }
 
-iXBRLReport.prototype.setViewerOptions = function (vo) {
-    this._viewerOptions = vo;
-}
-
-iXBRLReport.prototype.namespaceGroups = function () {
-    var counts = {};
-    $.each(this.facts(), function (i, f) {
-        counts[f.conceptQName().prefix] = counts[f.conceptQName().prefix] || 0;
-        counts[f.conceptQName().prefix]++;
-    });
-    var prefixes = Object.keys(counts);
-    prefixes.sort(function (a, b) { return counts[b] - counts[a] });
-    return prefixes;
-}
 
 iXBRLReport.prototype.getConcept = function(name) {
     return new Concept(this, name);
@@ -378,8 +150,7 @@ iXBRLReport.prototype.getRoleLabel = function(rolePrefix, viewerOptions) {
      *
      * Returns the ELR URI if there is no label
      */
-    // XXX hard-coded to first report
-    const labels = this.reportsData()[0].roleDefs[rolePrefix];
+    const labels = this._reportData.roleDefs[rolePrefix];
     if (labels !== undefined) {
         const label = labels["en"];
         // Earlier versions of the generator added a "null" label if no labels
@@ -392,31 +163,14 @@ iXBRLReport.prototype.getRoleLabel = function(rolePrefix, viewerOptions) {
 }
 
 iXBRLReport.prototype.localDocuments = function() {
-    if (this.data.localDocs === undefined) {
+    if (this._reportData.localDocs === undefined) {
         return {}
     }
-    return this.data.localDocs;
-}
-
-iXBRLReport.prototype.reportsData = function() {
-    return this.data.reports ?? [ this.data ];
+    return this._reportData.localDocs;
 }
 
-iXBRLReport.prototype.documentSetFiles = function() {
-    return this.reportsData().map((x, n) => (x.docSetFiles ?? []).map(file => ({ index: n, file: file }))).flat();
-}
-
-iXBRLReport.prototype.isDocumentSet = function() {
-    return this.documentSetFiles().length > 1;
-}
-
-iXBRLReport.prototype.usesAnchoring = function() {
-    // XXX hard-coded to first report
-    return this.reportsData()[0].rels["w-n"] !== undefined;
-}
-
-iXBRLReport.prototype.hasValidationErrors = function() {
-    return this.data.validation !== undefined && this.data.validation.length > 0;
+iXBRLReport.prototype.qname = function(v) {
+    return this.reportSet.qname(v);
 }
 
 iXBRLReport.prototype.getScaleLabel = function(scale, isMonetaryValue, currency=null) {
@@ -429,3 +183,48 @@ iXBRLReport.prototype.getScaleLabel = function(scale, isMonetaryValue, currency=
     }
     return label;
 }
+
+iXBRLReport.prototype.concepts = function() {
+    return this._reportData.concepts;
+}
+
+iXBRLReport.prototype.getLabel = function(c, rolePrefix, showPrefix) {
+    rolePrefix = rolePrefix || 'std';
+    const lang = this._viewerOptions.language;
+    const concept = this._reportData.concepts[c];
+    if (concept === undefined) {
+        console.log("Attempt to get label for undefined concept: " + c);
+        return "<no label>";
+    }
+    const labels = concept.labels[rolePrefix]
+    if (labels === undefined || Object.keys(labels).length == 0) {
+        return undefined;
+    }
+    else {
+        var label;
+        if (lang && labels[lang]) {
+            label = labels[lang];
+        }
+        else {
+            // Fall back on English, then any label deterministically.
+            label = labels["en"] || labels["en-us"] || labels[Object.keys(labels).sort()[0]];
+        }
+        if (label === undefined) {
+            return undefined;
+        }
+        var s = '';
+        if (showPrefix && this._viewerOptions.showPrefixes) {
+            s = "(" + this.qname(c).prefix + ") ";
+        }
+        s += label;
+        return s;
+    }
+}
+
+iXBRLReport.prototype.getLabelOrName = function(c, rolePrefix, showPrefix) {
+    const label = this.getLabel(c, rolePrefix, showPrefix);
+    if (label === undefined) {
+        return c;
+    }
+    return label;
+}
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
new file mode 100644
index 000000000..df9cb5f73
--- /dev/null
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -0,0 +1,231 @@
+// See COPYRIGHT.md for copyright information
+
+import { iXBRLReport } from './report.js';
+import { Fact } from "./fact.js"
+import { Footnote } from "./footnote.js"
+import { Unit } from "./unit";
+import { titleCase, viewerUniqueId } from "./util.js";
+import { QName } from "./qname.js"
+import $ from 'jquery'
+
+export class ReportSet {
+    constructor(data) {
+        this._data = data;
+        this._ixNodeMap = {};
+    }
+
+    /*
+     * Set additional information about facts obtained from parsing the iXBRL.
+     */
+    setIXNodeMap(ixData) {
+        this._ixNodeMap = ixData;
+        this._initialize();
+    }
+
+    _initialize() {
+        this._items = {};
+        this.reports = [];
+        // Build an array of footnotes IDs in document order so that we can assign
+        // numbers to foonotes
+        const fnorder = Object.keys(this._ixNodeMap).filter((id) => this._ixNodeMap[id].footnote);
+        fnorder.sort((a,b) => this._ixNodeMap[a].docOrderindex - this._ixNodeMap[b].docOrderindex);
+
+        // Create Fact objects for all facts.
+        for (const [reportIndex, reportData] of this.reportsData().entries()) {
+            const report = new iXBRLReport(this, reportData);
+            this.reports.push(report);
+            for (const [id, factData] of Object.entries(reportData.facts)) {
+                const vuid = viewerUniqueId(reportIndex, id);
+                this._items[vuid] = new Fact(report, vuid, factData);
+            }
+        }
+
+        // Now resolve footnote references, creating footnote objects for "normal"
+        // footnotes, and finding Fact objects for fact->fact footnotes.  
+        //
+        // Associate source facts with target footnote/facts to allow two way
+        // navigation.
+        for (const [id, fact] of Object.entries(this._items)) {
+            const fns = fact.fn || [];
+            fns.forEach((fnid) => {
+                const fnvuid = viewerUniqueId(fnid);
+                var fn = this._items[fnvuid];
+                if (fn === undefined) {
+                    fn = new Footnote(fact.report(), fnid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
+                    this._items[fnvuid] = fn;
+                }
+                // Associate fact with footnote
+                fn.addLinkedFact(fact);
+            });
+        }
+    }
+
+    isCalculationContributor(c) {
+        if (this._calculationContributors === undefined) {
+            if (this._data.rels?.calc) {
+                this._calculationContributors = new Set(Object.values(this._data.rels.calc).flatMap(calculations => {
+                    return Object.values(calculations).flatMap(contributors => {
+                        return contributors.map(c => c.t);
+                    });
+                }));
+            } else {
+                this._calculationContributors = new Set();
+            }
+        }
+        return this._calculationContributors.has(c);
+    }
+
+    isCalculationSummation(c) {
+        if (this._calculationSummations === undefined) {
+            if (this._data.rels?.calc) {
+                this._calculationSummations = new Set(Object.values(this._data.rels.calc).flatMap(calculations => {
+                    return Object.keys(calculations);
+                }));
+            } else {
+                this._calculationSummations = new Set();
+            }
+        }
+        return this._calculationSummations.has(c);
+    }
+
+
+    availableLanguages() {
+        return this.reports.reduce(
+            (langs, report) => new Set([...langs, ...report.availableLanguages()]), 
+            new Set()
+        );
+    }
+
+    getItemById(id) {
+        return this._items[id];
+    }
+
+    getIXNodeForItemId(id) {
+        return this._ixNodeMap[id] || {};
+    }
+
+    facts() {
+        return Object.values(this._items).filter(i => i instanceof Fact);
+    }
+
+    filingDocuments() {
+        return this._data.filingDocuments;
+    }
+
+    prefixMap() {
+        return this._data.prefixes;
+    }
+
+    namespaceGroups() {
+        const counts = {};
+        $.each(this.facts(), function (i, f) {
+            counts[f.conceptQName().prefix] = counts[f.conceptQName().prefix] || 0;
+            counts[f.conceptQName().prefix]++;
+        });
+        const prefixes = Object.keys(counts);
+        prefixes.sort(function (a, b) { return counts[b] - counts[a] });
+        return prefixes;
+    }
+
+    getUsedPrefixes() {
+        if (this._usedPrefixes === undefined) {
+            this._usedPrefixes = new Set(Object.values(this._items)
+                    .filter(f => f instanceof Fact)
+                    .map(f => f.getConceptPrefix()));
+        }
+        return this._usedPrefixes;
+    }
+
+    /**
+     * Returns a set of OIM format unit strings used by facts on this report. Lazy-loaded.
+     * @return {Set[String]} Set of OIM format unit strings
+     */
+    getUsedUnits() {
+        if (this._usedUnits === undefined) {
+            this._usedUnits = new Set(Object.values(this._items)
+                    .filter(f => f instanceof Fact)
+                    .map(f => f.unit()?.value())
+                    .filter(f => f)
+                    .sort());
+        }
+        return this._usedUnits;
+    }
+
+    /**
+     * Returns details about the provided unit. Lazy-loaded once per unit.
+     * @param  {String} unitKey  Unit in OIM format
+     * @return {Unit}  Unit instance corresponding with provided key
+     */
+    getUnit(unitKey) {
+        if (this._unitsMap === undefined) {
+            this._unitsMap = {};
+        }
+        if (this._unitsMap[unitKey] === undefined) {
+            this._unitsMap[unitKey] = new Unit(this, unitKey)
+        }
+        return this._unitsMap[unitKey];
+    }
+
+    getUsedScalesMap() {
+        // Do not lazy load. This is language-dependent so needs to re-evaluate after language changes.
+        const usedScalesMap = {};
+        Object.values(this._items)
+            .filter(f => f instanceof Fact)
+            .forEach(fact => {
+                const scale = fact.scale();
+                if (scale !== null && scale !== undefined) {
+                    if (!(scale in usedScalesMap)) {
+                        usedScalesMap[scale] = new Set();
+                    }
+                    const labels = usedScalesMap[scale];
+                    const label = titleCase(fact.getScaleLabel(scale));
+                    if (label && !labels.has(label)) {
+                        labels.add(label);
+                    }
+                }
+            });
+        return usedScalesMap;
+    }
+
+    languageNames() {
+        return this._data.languages;
+    }
+
+    roleMap() {
+        return this._data.roles;
+    }
+
+    qname(v) {
+        return new QName(this.prefixMap(), v);
+    }
+
+    reportsData() {
+        return this._data.reports ?? [ this._data ];
+    }
+
+    documentSetFiles() {
+        return this.reportsData().map((x, n) => (x.docSetFiles ?? []).map(file => ({ index: n, file: file }))).flat();
+    }
+
+    isDocumentSet() {
+        return this.documentSetFiles().length > 1;
+    }
+
+    usesAnchoring() {
+        // XXX hard-coded to first report
+        return this.reportsData()[0].rels["w-n"] !== undefined;
+    }
+
+    hasValidationErrors() {
+        return this._data.validation !== undefined && this._data.validation.length > 0;
+    }
+
+    validation() {
+        return this._data.validation;
+    }
+    
+    setViewerOptions(vo) {
+        this._viewerOptions = vo;
+    }
+
+}
diff --git a/iXBRLViewerPlugin/viewer/src/js/search.js b/iXBRLViewerPlugin/viewer/src/js/search.js
index 4078883f4..481b33b24 100644
--- a/iXBRLViewerPlugin/viewer/src/js/search.js
+++ b/iXBRLViewerPlugin/viewer/src/js/search.js
@@ -5,15 +5,15 @@ import $ from 'jquery'
 import Decimal from "decimal.js";
 
 export class ReportSearch {
-    constructor(report) {
-        this._report = report;
+    constructor(reportSet) {
+        this._reportSet = reportSet;
         this.ready = false;
     }
 
     * buildSearchIndex(doneCallback) {
         var docs = [];
         var dims = {};
-        var facts = this._report.facts();
+        var facts = this._reportSet.facts();
         this.periods = {};
         for (var i = 0; i < facts.length; i++) {
             var f = facts[i];
@@ -25,22 +25,22 @@ export class ReportSearch {
             doc.startDate = f.periodFrom();
             var dims = f.dimensions();
             for (var d in dims) {
-                if (this._report.getConcept(d).isTypedDimension()) {
+                if (f.report().getConcept(d).isTypedDimension()) {
                     if (dims[d] !== null) {
                         l += " " + dims[d];
                     }
                 }
                 else {
-                    l += " " + this._report.getLabel(dims[d], "std");
+                    l += " " + f.report().getLabel(dims[d], "std");
                 }
             }
             doc.label = l;
             doc.ref = f.concept().referenceValuesAsString();
             const wider = f.widerConcepts();
             if (wider.length > 0) {
-                doc.widerConcept = this._report.qname(wider[0]).localname;
-                doc.widerLabel = this._report.getLabel(wider[0], "std");
-                doc.widerDoc = this._report.getLabel(wider[0], "doc");
+                doc.widerConcept = f.report().qname(wider[0]).localname;
+                doc.widerLabel = f.report().getLabel(wider[0], "std");
+                doc.widerDoc = f.report().getLabel(wider[0], "doc");
             }
             docs.push(doc);
 
@@ -175,7 +175,7 @@ export class ReportSearch {
         ];
 
         rr.forEach((r,_) => {
-                const item = searchIndex._report.getItemById(r.ref);
+                const item = searchIndex._reportSet.getItemById(r.ref);
                 if (filters.every(f => f(s, item))) {
                     results.push({
                         "fact": item,
diff --git a/iXBRLViewerPlugin/viewer/src/js/summary.js b/iXBRLViewerPlugin/viewer/src/js/summary.js
index 581e71f9b..99ab5be17 100644
--- a/iXBRLViewerPlugin/viewer/src/js/summary.js
+++ b/iXBRLViewerPlugin/viewer/src/js/summary.js
@@ -68,8 +68,8 @@ class LocalDocuments {
 }
 
 export class DocumentSummary {
-    constructor(report) {
-        this._report = report;
+    constructor(reportSet) {
+        this._reportSet = reportSet;
     }
 
     _getTagCounter(tagCounts, element) {
@@ -86,14 +86,14 @@ export class DocumentSummary {
 
     _buildTagCounts() {
         const tagCounts = new Map();
-        for (const fact of this._report.facts()) {
+        for (const fact of this._reportSet.facts()) {
             let counter = this._getTagCounter(tagCounts, fact.conceptName());
             counter.addPrimaryItem(fact.conceptName());
             for (const [dimension, member] of Object.entries(fact.dimensions())) {
                 counter = this._getTagCounter(tagCounts, dimension);
                 counter.addDimension(dimension);
 
-                const dimensionConcept = this._report.getConcept(dimension);
+                const dimensionConcept = fact.report().getConcept(dimension);
                 if (dimensionConcept.isTypedDimension()) {
                     const typedDomainElement = dimensionConcept.typedDomainElement();
                     if (typedDomainElement) {
@@ -113,14 +113,14 @@ export class DocumentSummary {
 
     _buildLocalFileSummary() {
         this._localFileSummary = new LocalDocuments();
-        for (const [document, documentTypes] of Object.entries(this._report.localDocuments())) {
+        for (const [document, documentTypes] of this._reportSet.reports.flatMap(r => Object.entries(r.localDocuments()))) {
             this._localFileSummary.addDocument(document, documentTypes);
         }
     }
 
     totalFacts() {
         if (this._totalFacts === undefined) {
-            this._totalFacts = this._report.facts().length;
+            this._totalFacts = this._reportSet.facts().length;
         }
         return this._totalFacts;
     }
diff --git a/iXBRLViewerPlugin/viewer/src/js/tableExport.js b/iXBRLViewerPlugin/viewer/src/js/tableExport.js
index 272ef3f61..d8486ea63 100644
--- a/iXBRLViewerPlugin/viewer/src/js/tableExport.js
+++ b/iXBRLViewerPlugin/viewer/src/js/tableExport.js
@@ -7,17 +7,17 @@ import { Fact } from './fact.js';
 
 
 export class TableExport {
-    constructor(table, report) {
+    constructor(table, reportSet) {
         this._table = table;
-        this._report = report;
+        this._reportSet = reportSet;
     } 
 
-    static addHandles(iframe, report) {
+    static addHandles(iframe, reportSet) {
         $('table', iframe).each(function () {
             const table = $(this);
             if (table.find(".ixbrl-element").length > 0) {
                 table.css("position", "relative");
-                const exporter = new TableExport(table, report);
+                const exporter = new TableExport(table, reportSet);
                 $('<div class="ixbrl-table-handle"><span>Export table</span></div>')
                     .appendTo(table)
                     .click(() => exporter.exportTable());
@@ -27,7 +27,7 @@ export class TableExport {
 
     _getRawTable() {
         const table = this._table;
-        const report = this._report;
+        const reportSet = this._reportSet;
         let maxRowLength = 0;
         const rows = [];
         table.find("tr").each(function () {
@@ -44,7 +44,7 @@ export class TableExport {
                 let fact = null;
                 if (facts.length > 0) {
                     const id = facts.first().data('ivids');
-                    fact = report.getItemById(id);
+                    fact = reportSet.getItemById(id);
                 }
                 if (fact instanceof Fact) {
                     const cell = { type: "fact", fact: fact};
diff --git a/iXBRLViewerPlugin/viewer/src/js/viewer.js b/iXBRLViewerPlugin/viewer/src/js/viewer.js
index 3db677b7c..f29fc1457 100644
--- a/iXBRLViewerPlugin/viewer/src/js/viewer.js
+++ b/iXBRLViewerPlugin/viewer/src/js/viewer.js
@@ -22,9 +22,9 @@ function localName(e) {
 
 
 export class Viewer {
-    constructor(iv, iframes, report) {
+    constructor(iv, iframes, reportSet) {
         this._iv = iv;
-        this._report = report;
+        this._reportSet = reportSet;
         this._iframes = iframes;
         this._contents = iframes.contents();
         this.onSelect = $.Callbacks();
@@ -92,7 +92,7 @@ export class Viewer {
                     })()
                         .then(() => viewer._iv.setProgress("Preparing document") )
                         .then(() => {
-                            this._report.setIXNodeMap(this._ixNodeMap);
+                            this._reportSet.setIXNodeMap(this._ixNodeMap);
                             this._applyStyles();
                             this._bindHandlers();
                             this.scale = 1;
@@ -106,9 +106,9 @@ export class Viewer {
     }
 
     _addDocumentSetTabs() {
-        if (this._report.isDocumentSet()) {
+        if (this._reportSet.isDocumentSet()) {
             $('#ixv .ixds-tabs').show();
-            for (const [i, doc] of this._report.documentSetFiles().entries()) {
+            for (const [i, doc] of this._reportSet.documentSetFiles().entries()) {
                 $('<div class="tab">')
                     .text(doc.file)
                     .prop('title', doc.file)
@@ -231,7 +231,7 @@ export class Viewer {
         const url = $(n).attr("href");
         if (url !== undefined) {
             const [file, fragment] = url.split('#', 2);
-            const docIndex = this._report.documentSetFiles().indexOf(file);
+            const docIndex = this._reportSet.documentSetFiles().indexOf(file);
             if (!url.includes('/') && docIndex != -1) {
                 $(n).click((e) => { 
                     this._showDocumentAndElement(docIndex, fragment);
@@ -529,7 +529,7 @@ export class Viewer {
         $('#iframe-container .zoom-out').click(() => this.zoomOut());
         $('#iframe-container .print').click(() => this.currentDocument().get(0).contentWindow.print());
 
-        TableExport.addHandles(this._contents, this._report);
+        TableExport.addHandles(this._contents, this._reportSet);
     }
 
     selectNextTag(currentFact) {
@@ -739,7 +739,7 @@ export class Viewer {
         $.each(namespaceGroups, function (i, ns) {
             groups[ns] = i;
         });
-        const report = this._report;
+        const reportSet = this._reportSet;
         const viewer = this;
         if (on) {
             $(".ixbrl-element", this._contents)
@@ -752,7 +752,7 @@ export class Viewer {
                     const ixn = $(this).data('ivids').map(id => viewer._ixNodeMap[id]).filter(ixn => !ixn.footnote)[0];
                     if (ixn != undefined) {
                         const elements = viewer.elementsForItemIds(ixn.chainIXIds());
-                        const i = groups[report.getItemById(ixn.id).conceptQName().prefix];
+                        const i = groups[reportSet.getItemById(ixn.id).conceptQName().prefix];
                         if (i !== undefined) {
                             elements.addClass("ixbrl-highlight-" + i);
                         }

From 281339b43a71b3e0538b2f9cb1eaf0d93de08e24 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Sat, 23 Sep 2023 11:11:00 +0100
Subject: [PATCH 05/32] Fix footnotes.

---
 iXBRLViewerPlugin/viewer/src/js/fact.js      |  7 +++-
 iXBRLViewerPlugin/viewer/src/js/footnote.js  |  2 +-
 iXBRLViewerPlugin/viewer/src/js/reportset.js | 39 +++++++++++---------
 3 files changed, 28 insertions(+), 20 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.js b/iXBRLViewerPlugin/viewer/src/js/fact.js
index f0eb329d5..238110d49 100644
--- a/iXBRLViewerPlugin/viewer/src/js/fact.js
+++ b/iXBRLViewerPlugin/viewer/src/js/fact.js
@@ -15,6 +15,7 @@ export class Fact {
         this._report = report;
         this.id = factId;
         this.linkedFacts = [];
+        this._footnotes = [];
     }
 
     report() {
@@ -322,8 +323,12 @@ export class Fact {
         return this.concept().isEnumeration();
     }
 
+    addFootnote(fn) {
+        this._footnotes.push(fn);
+    }
+
     footnotes() {
-        return (this.f.fn || []).map((fn, i) => this._report.reportSet.getItemById(fn));
+        return this._footnotes;
     }
 
     isHidden() {
diff --git a/iXBRLViewerPlugin/viewer/src/js/footnote.js b/iXBRLViewerPlugin/viewer/src/js/footnote.js
index 5f1376010..e5371b2ec 100644
--- a/iXBRLViewerPlugin/viewer/src/js/footnote.js
+++ b/iXBRLViewerPlugin/viewer/src/js/footnote.js
@@ -5,7 +5,7 @@ export class Footnote {
         this.id = footnoteId;
         this.linkedFacts = [];
         this.title = title;
-        this.ixNode = report.getIXNodeForItemId(footnoteId);
+        this.ixNode = report.reportSet.getIXNodeForItemId(footnoteId);
     }
 
     // Facts that are the source of relationships to this fact.
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index df9cb5f73..952b63e6c 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -38,25 +38,28 @@ export class ReportSet {
                 const vuid = viewerUniqueId(reportIndex, id);
                 this._items[vuid] = new Fact(report, vuid, factData);
             }
-        }
 
-        // Now resolve footnote references, creating footnote objects for "normal"
-        // footnotes, and finding Fact objects for fact->fact footnotes.  
-        //
-        // Associate source facts with target footnote/facts to allow two way
-        // navigation.
-        for (const [id, fact] of Object.entries(this._items)) {
-            const fns = fact.fn || [];
-            fns.forEach((fnid) => {
-                const fnvuid = viewerUniqueId(fnid);
-                var fn = this._items[fnvuid];
-                if (fn === undefined) {
-                    fn = new Footnote(fact.report(), fnid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
-                    this._items[fnvuid] = fn;
-                }
-                // Associate fact with footnote
-                fn.addLinkedFact(fact);
-            });
+            // Now resolve footnote references, creating footnote objects for "normal"
+            // footnotes, and finding Fact objects for fact->fact footnotes.  
+            //
+            // Associate source facts with target footnote/facts to allow two way
+            // navigation.
+            for (const [id, factData] of Object.entries(reportData.facts)) {
+                const vuid = viewerUniqueId(reportIndex, id);
+                const fact = this._items[vuid];
+                const fns = factData.fn || [];
+                fns.forEach((fnid) => {
+                    const fnvuid = viewerUniqueId(reportIndex, fnid);
+                    var fn = this._items[fnvuid];
+                    if (fn === undefined) {
+                        fn = new Footnote(fact.report(), fnvuid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
+                        this._items[fnvuid] = fn;
+                    }
+                    // Associate fact with footnote
+                    fn.addLinkedFact(fact);
+                    fact.addFootnote(fn);
+                });
+            }
         }
     }
 

From fd1fee1110e396b189b257e8571fa8f29f1232fb Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Sat, 23 Sep 2023 11:24:26 +0100
Subject: [PATCH 06/32] Rename iXBRLReport to XBRLReport.

---
 iXBRLViewerPlugin/viewer/src/js/report.js    | 41 +++++++++++---------
 iXBRLViewerPlugin/viewer/src/js/reportset.js |  9 ++++-
 2 files changed, 29 insertions(+), 21 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/report.js b/iXBRLViewerPlugin/viewer/src/js/report.js
index 5337deb4c..f973eb7cf 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.js
@@ -9,7 +9,10 @@ import { setDefault, viewerUniqueId } from "./util.js";
 import $ from 'jquery'
 import i18next from "i18next";
 
-export function iXBRLReport(reportSet, reportData) {
+// Class to represent the XBRL data from a single target document in a single
+// Inline XBRL Document or Document Set.
+
+export function XBRLReport(reportSet, reportData) {
     this.reportSet = reportSet;
     this._reportData = reportData;
     // A map of IDs to Fact and Footnote objects
@@ -17,7 +20,7 @@ export function iXBRLReport(reportSet, reportData) {
     this._reverseRelationshipCache = {};
 }
 
-iXBRLReport.prototype.availableLanguages = function() {
+XBRLReport.prototype.availableLanguages = function() {
     if (!this._availableLanguages) {
         this._availableLanguages = new Set()
         for (const c of Object.values(this._reportData.concepts)) {
@@ -31,7 +34,7 @@ iXBRLReport.prototype.availableLanguages = function() {
     return this._availableLanguages;
 }
 
-iXBRLReport.prototype.getChildRelationships = function(conceptName, arcrole) {
+XBRLReport.prototype.getChildRelationships = function(conceptName, arcrole) {
     var rels = {}
     const elrs = this._reportData.rels[arcrole] || {};
     for (const elr in elrs) {
@@ -50,7 +53,7 @@ iXBRLReport.prototype.getChildRelationships = function(conceptName, arcrole) {
  *
  * "rel" is modified to have a "src" property with the source concept.
  */
-iXBRLReport.prototype._reverseRelationships = function(arcrole) {
+XBRLReport.prototype._reverseRelationships = function(arcrole) {
     if (!(arcrole in this._reverseRelationshipCache)) {
         const rrc = {};
         const elrs = this._reportData.rels[arcrole] || {};
@@ -67,7 +70,7 @@ iXBRLReport.prototype._reverseRelationships = function(arcrole) {
     return this._reverseRelationshipCache[arcrole];
 }
 
-iXBRLReport.prototype.getParentRelationships = function(conceptName, arcrole) {
+XBRLReport.prototype.getParentRelationships = function(conceptName, arcrole) {
     const rels = {}
     for (const [elr, relSet] of Object.entries(this._reverseRelationships(arcrole))) {
         if (conceptName in relSet) {
@@ -77,12 +80,12 @@ iXBRLReport.prototype.getParentRelationships = function(conceptName, arcrole) {
     return rels;
 }
 
-iXBRLReport.prototype.getParentRelationshipsInGroup = function(conceptName, arcrole, elr) {
+XBRLReport.prototype.getParentRelationshipsInGroup = function(conceptName, arcrole, elr) {
     const relSet = this._reverseRelationships(arcrole)[elr] || {};
     return relSet[conceptName] || [];
 }
 
-iXBRLReport.prototype.dimensionDefault = function(dimensionName) {
+XBRLReport.prototype.dimensionDefault = function(dimensionName) {
     // ELR is irrelevant for dimension-default relationships, so check all of
     // them, and return the first (illegal for there to be more than one
     for (const rel of Object.values(this._reportData.rels["d-d"] || {})) {
@@ -93,11 +96,11 @@ iXBRLReport.prototype.dimensionDefault = function(dimensionName) {
     return undefined;
 }
 
-iXBRLReport.prototype.relationshipGroups = function(arcrole) {
+XBRLReport.prototype.relationshipGroups = function(arcrole) {
     return Object.keys(this._reportData.rels[arcrole] || {});
 }
 
-iXBRLReport.prototype.relationshipGroupRoots = function(arcrole, elr) {
+XBRLReport.prototype.relationshipGroupRoots = function(arcrole, elr) {
     const roots = [];
     for (const conceptName in this._reportData.rels[arcrole][elr]) {
         if (!(elr in this.getParentRelationships(conceptName, arcrole))) {
@@ -107,7 +110,7 @@ iXBRLReport.prototype.relationshipGroupRoots = function(arcrole, elr) {
     return roots;
 }
 
-iXBRLReport.prototype.getAlignedFacts = function(f, coveredAspects) {
+XBRLReport.prototype.getAlignedFacts = function(f, coveredAspects) {
     // XXX should filter to current report facts?
     var all = this.reportSet.facts();
     var aligned = [];
@@ -122,7 +125,7 @@ iXBRLReport.prototype.getAlignedFacts = function(f, coveredAspects) {
     return aligned; 
 }
 
-iXBRLReport.prototype.deduplicate = function (facts) {
+XBRLReport.prototype.deduplicate = function (facts) {
     const ff = [];
     $.each(facts, function (i, f) {
         var dupe = false;
@@ -139,11 +142,11 @@ iXBRLReport.prototype.deduplicate = function (facts) {
 }
 
 
-iXBRLReport.prototype.getConcept = function(name) {
+XBRLReport.prototype.getConcept = function(name) {
     return new Concept(this, name);
 }
 
-iXBRLReport.prototype.getRoleLabel = function(rolePrefix, viewerOptions) {
+XBRLReport.prototype.getRoleLabel = function(rolePrefix, viewerOptions) {
     /* This is currently hard-coded to "en" as the generator does not yet
      * support generic labels, and instead provides the (non-localisable) role
      * definition as a single "en" label.
@@ -162,18 +165,18 @@ iXBRLReport.prototype.getRoleLabel = function(rolePrefix, viewerOptions) {
     return this.roleMap()[rolePrefix];
 }
 
-iXBRLReport.prototype.localDocuments = function() {
+XBRLReport.prototype.localDocuments = function() {
     if (this._reportData.localDocs === undefined) {
         return {}
     }
     return this._reportData.localDocs;
 }
 
-iXBRLReport.prototype.qname = function(v) {
+XBRLReport.prototype.qname = function(v) {
     return this.reportSet.qname(v);
 }
 
-iXBRLReport.prototype.getScaleLabel = function(scale, isMonetaryValue, currency=null) {
+XBRLReport.prototype.getScaleLabel = function(scale, isMonetaryValue, currency=null) {
     var label = i18next.t(`scale.${scale}`, {defaultValue:"noName"});
     if (isMonetaryValue && scale === -2) {
         label = i18next.t(`currencies:cents${currency}`, {defaultValue: label});
@@ -184,11 +187,11 @@ iXBRLReport.prototype.getScaleLabel = function(scale, isMonetaryValue, currency=
     return label;
 }
 
-iXBRLReport.prototype.concepts = function() {
+XBRLReport.prototype.concepts = function() {
     return this._reportData.concepts;
 }
 
-iXBRLReport.prototype.getLabel = function(c, rolePrefix, showPrefix) {
+XBRLReport.prototype.getLabel = function(c, rolePrefix, showPrefix) {
     rolePrefix = rolePrefix || 'std';
     const lang = this._viewerOptions.language;
     const concept = this._reportData.concepts[c];
@@ -221,7 +224,7 @@ iXBRLReport.prototype.getLabel = function(c, rolePrefix, showPrefix) {
     }
 }
 
-iXBRLReport.prototype.getLabelOrName = function(c, rolePrefix, showPrefix) {
+XBRLReport.prototype.getLabelOrName = function(c, rolePrefix, showPrefix) {
     const label = this.getLabel(c, rolePrefix, showPrefix);
     if (label === undefined) {
         return c;
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index 952b63e6c..b67ef5045 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -1,6 +1,6 @@
 // See COPYRIGHT.md for copyright information
 
-import { iXBRLReport } from './report.js';
+import { XBRLReport } from './report.js';
 import { Fact } from "./fact.js"
 import { Footnote } from "./footnote.js"
 import { Unit } from "./unit";
@@ -8,6 +8,11 @@ import { titleCase, viewerUniqueId } from "./util.js";
 import { QName } from "./qname.js"
 import $ from 'jquery'
 
+
+// Class represents the set of XBRL "target" reports shown in the viewer.
+// Each contained report represents the data from a single target document in a
+// single iXBRL Document or iXBRL Document Set
+
 export class ReportSet {
     constructor(data) {
         this._data = data;
@@ -32,7 +37,7 @@ export class ReportSet {
 
         // Create Fact objects for all facts.
         for (const [reportIndex, reportData] of this.reportsData().entries()) {
-            const report = new iXBRLReport(this, reportData);
+            const report = new XBRLReport(this, reportData);
             this.reports.push(report);
             for (const [id, factData] of Object.entries(reportData.facts)) {
                 const vuid = viewerUniqueId(reportIndex, id);

From 68acbec2cc07b5af835b017a0f8a36eac028a9ce Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Sat, 23 Sep 2023 22:35:16 +0100
Subject: [PATCH 07/32] Fix tests.

---
 .../viewer/src/js/aspect.test.js              |  4 +-
 iXBRLViewerPlugin/viewer/src/js/chart.test.js |  4 +-
 .../viewer/src/js/concept.test.js             |  4 +-
 iXBRLViewerPlugin/viewer/src/js/fact.js       |  6 +-
 iXBRLViewerPlugin/viewer/src/js/fact.test.js  | 10 +--
 .../viewer/src/js/factset.test.js             |  4 +-
 .../viewer/src/js/inspector.test.js           |  4 +-
 .../viewer/src/js/outline.test.js             |  4 +-
 iXBRLViewerPlugin/viewer/src/js/report.js     | 28 +++++++++
 .../viewer/src/js/report.test.js              | 13 ++--
 iXBRLViewerPlugin/viewer/src/js/reportset.js  | 27 --------
 .../viewer/src/js/search.test.js              | 62 ++++++++++---------
 iXBRLViewerPlugin/viewer/src/js/unit.test.js  |  7 ++-
 13 files changed, 92 insertions(+), 85 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/aspect.test.js b/iXBRLViewerPlugin/viewer/src/js/aspect.test.js
index 945a91869..03815166a 100644
--- a/iXBRLViewerPlugin/viewer/src/js/aspect.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/aspect.test.js
@@ -1,7 +1,7 @@
 // See COPYRIGHT.md for copyright information
 
 import { Aspect, AspectSet } from "./aspect.js";
-import { iXBRLReport } from "./report.js";
+import { XBRLReport } from "./report.js";
 import { TestInspector } from "./test-utils.js";
 
 var testReportData = {
@@ -48,7 +48,7 @@ beforeAll(() => {
     return insp.i18nInit();
 });
 
-var testReport = new iXBRLReport(testReportData);
+var testReport = new XBRLReport(testReportData);
 
 test("Concept aspect labels", () => {
     var conceptAspect = new Aspect("c", "eg:Concept1", testReport);
diff --git a/iXBRLViewerPlugin/viewer/src/js/chart.test.js b/iXBRLViewerPlugin/viewer/src/js/chart.test.js
index 5fdf48048..da176e325 100644
--- a/iXBRLViewerPlugin/viewer/src/js/chart.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/chart.test.js
@@ -2,7 +2,7 @@
 
 import { Fact } from "./fact.js";
 import { IXBRLChart } from "./chart.js";
-import { iXBRLReport } from "./report.js";
+import { XBRLReport } from "./report.js";
 import { TestInspector } from "./test-utils.js";
 
 var testReportData = {
@@ -76,7 +76,7 @@ function testReport(facts, ixData) {
     // Deep copy of standing data
     var data = JSON.parse(JSON.stringify(testReportData));
     data.facts = facts;
-    var report = new iXBRLReport(data);
+    var report = new XBRLReport(data);
     report.setIXNodeMap(ixData);
     return report;
 }
diff --git a/iXBRLViewerPlugin/viewer/src/js/concept.test.js b/iXBRLViewerPlugin/viewer/src/js/concept.test.js
index 464f4a10d..624d3a5e5 100644
--- a/iXBRLViewerPlugin/viewer/src/js/concept.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/concept.test.js
@@ -1,6 +1,6 @@
 // See COPYRIGHT.md for copyright information
 
-import { iXBRLReport } from "./report.js";
+import { XBRLReport } from "./report.js";
 
 var testReportData = {
     "prefixes": {
@@ -48,7 +48,7 @@ var testReportData = {
 };
 
 describe("Concept references", () => {
-    var r = new iXBRLReport(testReportData);
+    var r = new XBRLReport(testReportData);
     test("Absent reference", () => {
         var c1 = r.getConcept("eg:Concept1");
         expect(c1.referenceValuesAsString()).toEqual("");
diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.js b/iXBRLViewerPlugin/viewer/src/js/fact.js
index 238110d49..2ce374b9a 100644
--- a/iXBRLViewerPlugin/viewer/src/js/fact.js
+++ b/iXBRLViewerPlugin/viewer/src/js/fact.js
@@ -18,6 +18,10 @@ export class Fact {
         this._footnotes = [];
     }
 
+    localId() {
+        return this.id.replace(/^\d+-/,"");
+    }
+
     report() {
         return this._report;
     }
@@ -134,7 +138,7 @@ export class Fact {
             if (!unitKey) {
                 return undefined;
             }
-            this._unit = this.report().getUnit(unitKey);
+            this._unit = this.report().reportSet.getUnit(unitKey);
         }
         return this._unit;
     }
diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.test.js b/iXBRLViewerPlugin/viewer/src/js/fact.test.js
index 9dfc4ebc7..9d09ede59 100644
--- a/iXBRLViewerPlugin/viewer/src/js/fact.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/fact.test.js
@@ -1,7 +1,7 @@
 // See COPYRIGHT.md for copyright information
 
 import { Fact } from "./fact.js";
-import { iXBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 import { TestInspector } from "./test-utils.js";
 
 var testReportData = {
@@ -75,16 +75,16 @@ function testReport(facts, ixData) {
     // Deep copy of standing data
     var data = JSON.parse(JSON.stringify(testReportData));
     data.facts = facts;
-    var report = new iXBRLReport(data);
-    report.setIXNodeMap(ixData);
-    return report;
+    var reportSet = new ReportSet(data);
+    reportSet.setIXNodeMap(ixData);
+    return reportSet.reports[0];
 }
 
 function testFact(factData, ixData) {
     factData.a = factData.a || {};
     factData.a.c = factData.a.c || 'eg:Concept1';
     ixData = ixData || {};
-    return new Fact(testReport({"f1": factData}, {"f1": ixData }), "f1");
+    return new Fact(testReport({"f1": factData}, {"f1": ixData }), "f1", factData);
 }
 
 var insp = new TestInspector();
diff --git a/iXBRLViewerPlugin/viewer/src/js/factset.test.js b/iXBRLViewerPlugin/viewer/src/js/factset.test.js
index 63ad56f28..781b745a9 100644
--- a/iXBRLViewerPlugin/viewer/src/js/factset.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/factset.test.js
@@ -2,7 +2,7 @@
 
 import { Fact } from "./fact.js";
 import { FactSet } from "./factset.js";
-import { iXBRLReport } from "./report.js";
+import { XBRLReport } from "./report.js";
 
 var i = 0;
 
@@ -75,7 +75,7 @@ function testReport(facts) {
     // Deep copy of standing data
     var data = JSON.parse(JSON.stringify(testReportData));
     data.facts = facts;
-    var report = new iXBRLReport(data);
+    var report = new XBRLReport(data);
     return report;
 }
 
diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.test.js b/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
index 4c5c13a4b..25ba7bd04 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
@@ -1,7 +1,7 @@
 // See COPYRIGHT.md for copyright information
 
 import { Fact } from "./fact.js";
-import { iXBRLReport } from "./report.js";
+import { XBRLReport } from "./report.js";
 import { TestInspector } from "./test-utils.js";
 
 
@@ -46,7 +46,7 @@ function testReport(facts, ixData) {
     // Deep copy of standing data
     var data = JSON.parse(JSON.stringify(testReportData));
     data.facts = facts;
-    var report = new iXBRLReport(data);
+    var report = new XBRLReport(data);
     report.setIXNodeMap(ixData);
     return report;
 }
diff --git a/iXBRLViewerPlugin/viewer/src/js/outline.test.js b/iXBRLViewerPlugin/viewer/src/js/outline.test.js
index 2329d45df..055c22960 100644
--- a/iXBRLViewerPlugin/viewer/src/js/outline.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/outline.test.js
@@ -1,7 +1,7 @@
 // See COPYRIGHT.md for copyright information
 
 import $ from 'jquery'
-import { iXBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 import { DocumentOutline } from "./outline.js";
 import { IXNode } from "./ixnode.js";
 
@@ -175,7 +175,7 @@ function testReport(factList) {
         data.facts[f] = testFacts[f];
         ixNodeMap[f] = new IXNode(f, $('<span></span>'), i++);
     }
-    var report = new iXBRLReport(data);
+    var report = new ReportSet(data);
     report.setIXNodeMap(ixNodeMap);
     return report;
 }
diff --git a/iXBRLViewerPlugin/viewer/src/js/report.js b/iXBRLViewerPlugin/viewer/src/js/report.js
index f973eb7cf..367176828 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.js
@@ -231,3 +231,31 @@ XBRLReport.prototype.getLabelOrName = function(c, rolePrefix, showPrefix) {
     }
     return label;
 }
+
+XBRLReport.prototype.isCalculationContributor = function(c) {
+    if (this._calculationContributors === undefined) {
+        if (this._reportData.rels?.calc) {
+            this._calculationContributors = new Set(Object.values(this._reportData.rels.calc).flatMap(calculations => {
+                return Object.values(calculations).flatMap(contributors => {
+                    return contributors.map(c => c.t);
+                });
+            }));
+        } else {
+            this._calculationContributors = new Set();
+        }
+    }
+    return this._calculationContributors.has(c);
+}
+
+XBRLReport.prototype.isCalculationSummation = function(c) {
+    if (this._calculationSummations === undefined) {
+        if (this._reportData.rels?.calc) {
+            this._calculationSummations = new Set(Object.values(this._reportData.rels.calc).flatMap(calculations => {
+                return Object.keys(calculations);
+            }));
+        } else {
+            this._calculationSummations = new Set();
+        }
+    }
+    return this._calculationSummations.has(c);
+}
diff --git a/iXBRLViewerPlugin/viewer/src/js/report.test.js b/iXBRLViewerPlugin/viewer/src/js/report.test.js
index 9bd0e4083..3880ab5c8 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.test.js
@@ -1,6 +1,6 @@
 // See COPYRIGHT.md for copyright information
 
-import { iXBRLReport } from "./report.js";
+import { XBRLReport } from "./report.js";
 import { ViewerOptions } from "./viewerOptions.js";
 
 var testReportData = {
@@ -66,8 +66,7 @@ var testReportData = {
 
 
 describe("Language options", () => {
-    var testReport = new iXBRLReport(testReportData);
-    testReport._initialize();
+    var testReport = new XBRLReport(testReportData);
     test("Available languages", () => {
         var al = testReport.availableLanguages();
         expect(al).toHaveLength(6);
@@ -83,12 +82,10 @@ describe("Language options", () => {
 });
 
 describe("Fetching facts", () => {
-    var testReport = new iXBRLReport(testReportData);
-    testReport._initialize();
+    var testReport = new XBRLReport(testReportData);
 
     test("Successful", () => {
         var f = testReport.getItemById("f1");
-        testReport._initialize();
         expect(f).not.toBeNull();
         expect(f.decimals()).toEqual(-3);
     });
@@ -100,7 +97,7 @@ describe("Fetching facts", () => {
 });
 
 describe("Concept labels", () => {
-    var testReport = new iXBRLReport(testReportData);
+    var testReport = new XBRLReport(testReportData);
     var vo = new ViewerOptions();
     testReport.setViewerOptions(vo);
     test("Label fallback", () => {
@@ -132,7 +129,7 @@ describe("Concept labels", () => {
 });
 
 describe("ELR labels", () => {
-    const testReport = new iXBRLReport(testReportData);
+    const testReport = new XBRLReport(testReportData);
     test("Present", () => {
         expect(testReport.getRoleLabel("role1")).toBe("Role 1 Label");
     });
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index b67ef5045..22b9a4267 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -68,33 +68,6 @@ export class ReportSet {
         }
     }
 
-    isCalculationContributor(c) {
-        if (this._calculationContributors === undefined) {
-            if (this._data.rels?.calc) {
-                this._calculationContributors = new Set(Object.values(this._data.rels.calc).flatMap(calculations => {
-                    return Object.values(calculations).flatMap(contributors => {
-                        return contributors.map(c => c.t);
-                    });
-                }));
-            } else {
-                this._calculationContributors = new Set();
-            }
-        }
-        return this._calculationContributors.has(c);
-    }
-
-    isCalculationSummation(c) {
-        if (this._calculationSummations === undefined) {
-            if (this._data.rels?.calc) {
-                this._calculationSummations = new Set(Object.values(this._data.rels.calc).flatMap(calculations => {
-                    return Object.keys(calculations);
-                }));
-            } else {
-                this._calculationSummations = new Set();
-            }
-        }
-        return this._calculationSummations.has(c);
-    }
 
 
     availableLanguages() {
diff --git a/iXBRLViewerPlugin/viewer/src/js/search.test.js b/iXBRLViewerPlugin/viewer/src/js/search.test.js
index baa4a297e..8e11bfff4 100644
--- a/iXBRLViewerPlugin/viewer/src/js/search.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/search.test.js
@@ -1,7 +1,8 @@
 // See COPYRIGHT.md for copyright information
 
 import { ReportSearch } from "./search.js"
-import {iXBRLReport} from "./report";
+import { ReportSet } from "./reportset.js";
+import { viewerUniqueId } from "./util.js";
 
 const testReportData = {
     "concepts": {},
@@ -83,7 +84,10 @@ function testReport(ixData, testData) {
             ixData[id] = {};
         }
     })
-    const report = new iXBRLReport(data);
+    ixData = Object.fromEntries(
+        Object.entries(ixData).map(([id, v]) => [viewerUniqueId(0,id), v])
+    );
+    const report = new ReportSet(data);
     report.setIXNodeMap(ixData);
     return report;
 }
@@ -129,7 +133,7 @@ describe("Search fact value filter", () => {
         spec.factValueFilter = 'negative'
         const results = reportSearch.search(spec);
         expect(results.length).toEqual(1)
-        expect(results[0]["fact"]["id"]).toEqual("negative")
+        expect(results[0]["fact"].localId()).toEqual("negative")
     });
 
     test("Fact Value Negative filter works with other filter", () => {
@@ -138,7 +142,7 @@ describe("Search fact value filter", () => {
         spec.periodFilter = ['2018-01-01/2019-01-01']
         const results = reportSearch.search(spec);
         expect(results.length).toEqual(1)
-        expect(results[0]["fact"]["id"]).toEqual("negative")
+        expect(results[0]["fact"].localId()).toEqual("negative")
     });
 
     test("Fact Value Positive filter works", () => {
@@ -146,7 +150,7 @@ describe("Search fact value filter", () => {
         spec.factValueFilter = 'positive'
         const results = reportSearch.search(spec);
         expect(results.length).toEqual(1)
-        expect(results[0]["fact"]["id"]).toEqual("positive")
+        expect(results[0]["fact"].localId()).toEqual("positive")
     });
 
     test("Fact Value Positive filter works with other filter", () => {
@@ -155,7 +159,7 @@ describe("Search fact value filter", () => {
         spec.periodFilter = ['2018-01-01/2019-01-01']
         const results = reportSearch.search(spec);
         expect(results.length).toEqual(1)
-        expect(results[0]["fact"]["id"]).toEqual("positive")
+        expect(results[0]["fact"].localId()).toEqual("positive")
     });
 });
 
@@ -192,28 +196,28 @@ describe("Search calculation filter", () => {
     test("Calculations 'all' filter works", () => {
         const spec = testSearchSpec();
         spec.calculationsFilter = [];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['item1', 'item2', 'other', 'summation']);
     });
 
     test("Calculations 'contributor' filter works", () => {
         const spec = testSearchSpec();
         spec.calculationsFilter = ['contributor'];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['item1', 'item2']);
     });
 
     test("Calculations 'summation' filter works", () => {
         const spec = testSearchSpec();
         spec.calculationsFilter = ['summation'];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['summation']);
     });
 
     test("Calculations 'summation' and 'contributor' filter works", () => {
         const spec = testSearchSpec();
         spec.calculationsFilter = ['summation', 'contributor'];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['item1', 'item2', 'summation']);
     });
     const emptyReport = testReport(
@@ -232,7 +236,7 @@ describe("Search calculation filter", () => {
     test("Calculations filter works on empty report", () => {
         const spec = testSearchSpec();
         spec.calculationsFilter = ['summation', 'contributor'];
-        const results = emptyReportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = emptyReportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual([]);
     });
 });
@@ -271,31 +275,31 @@ describe("Search namespaces filter", () => {
     test("Namespaces filter works without selection", () => {
         const spec = testSearchSpec();
         spec.namespacesFilter = [];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['itemA1', 'itemA2', 'itemB1', 'itemC1']);
     });
 
     test("Namespaces filter works with single selection", () => {
         const spec = testSearchSpec();
         spec.namespacesFilter = ['a'];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['itemA1', 'itemA2']);
     });
 
     test("Namespaces filter works with multiple selections", () => {
         const spec = testSearchSpec();
         spec.namespacesFilter = ['a', 'b'];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['itemA1', 'itemA2', 'itemB1']);
     });
 
     test("Namespaces filter works with all selections", () => {
         const spec1 = testSearchSpec();
         spec1.namespacesFilter = Array.from(report.getUsedPrefixes());
-        const results1 = reportSearch.search(spec1).map(r => r.fact.id).sort();
+        const results1 = reportSearch.search(spec1).map(r => r.fact.localId()).sort();
         const spec2 = testSearchSpec();
         spec2.namespacesFilter = [];
-        const results2 = reportSearch.search(spec2).map(r => r.fact.id).sort();
+        const results2 = reportSearch.search(spec2).map(r => r.fact.localId()).sort();
         expect(results1).toEqual(results2);
         expect(results1).toEqual(['itemA1', 'itemA2', 'itemB1', 'itemC1'])
     });
@@ -343,31 +347,31 @@ describe("Search units filter", () => {
     test("Units filter works without selection", () => {
         const spec = testSearchSpec();
         spec.unitsFilter = [];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['itemA', 'itemAB', 'itemB', 'itemBA', 'other']);
     });
 
     test("Units filter works with single selection", () => {
         const spec = testSearchSpec();
         spec.unitsFilter = [cashShareUnit];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['itemAB']);
     });
 
     test("Units filter works with multiple selections", () => {
         const spec = testSearchSpec();
         spec.unitsFilter = [cashUnit, cashShareUnit];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['itemA', 'itemAB']);
     });
 
     test("Units filter with all selections matches numeric filter", () => {
         const spec1 = testSearchSpec();
         spec1.unitsFilter = Array.from(report.getUsedUnits());
-        const results1 = reportSearch.search(spec1).map(r => r.fact.id).sort();
+        const results1 = reportSearch.search(spec1).map(r => r.fact.localId()).sort();
         const spec2 = testSearchSpec()
         spec2.conceptTypeFilter = 'numeric';
-        const results2 = reportSearch.search(spec2).map(r => r.fact.id).sort();
+        const results2 = reportSearch.search(spec2).map(r => r.fact.localId()).sort();
         expect(results1).toEqual(results2);
         expect(results1).toEqual(['itemA', 'itemAB', 'itemB', 'itemBA'])
     });
@@ -403,28 +407,28 @@ describe("Search dimension type filter", () => {
     test("Dimension 'all' filter works", () => {
         const spec = testSearchSpec();
         spec.dimensionTypeFilter = [];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['explicit', 'explicit2', 'explicitAndTyped', 'explicitAndTyped2', 'simple', 'simple2', 'typed', 'typed2']);
     });
 
     test("Dimension 'explicit' filter works", () => {
         const spec = testSearchSpec();
         spec.dimensionTypeFilter = ['explicit'];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['explicit', 'explicit2', 'explicitAndTyped', 'explicitAndTyped2']);
     });
 
     test("Dimension 'typed' filter works", () => {
         const spec = testSearchSpec();
         spec.dimensionTypeFilter = ['typed'];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['explicitAndTyped', 'explicitAndTyped2', 'typed', 'typed2']);
     });
 
     test("Dimension 'explicit' and 'typed' filter works", () => {
         const spec = testSearchSpec();
         spec.dimensionTypeFilter = ['explicit', 'typed'];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['explicit', 'explicit2', 'explicitAndTyped', 'explicitAndTyped2', 'typed', 'typed2']);
     });
 
@@ -444,7 +448,7 @@ describe("Search dimension type filter", () => {
     test("Dimension filter works on empty report", () => {
         const spec = testSearchSpec();
         spec.dimensionTypeFilter = ['explicit'];
-        const results = emptyReportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = emptyReportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual([]);
     });
 });
@@ -499,21 +503,21 @@ describe("Search scales filter", () => {
     test("Scales filter works without selection", () => {
         const spec = testSearchSpec();
         spec.scalesFilter = [];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['item-1', 'item-2', 'item-3', 'item0', 'item1', 'item12', 'item2', 'item3', 'item6', 'item9', 'itemOther']);
     });
 
     test("Scales filter works with single selection", () => {
         const spec = testSearchSpec();
         spec.scalesFilter = [-2];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['item-2']);
     });
 
     test("Scales filter works with multiple selections", () => {
         const spec = testSearchSpec();
         spec.scalesFilter = [-2, 2];
-        const results = reportSearch.search(spec).map(r => r.fact.id).sort();
+        const results = reportSearch.search(spec).map(r => r.fact.localId()).sort();
         expect(results).toEqual(['item-2', 'item2']);
     });
 });
diff --git a/iXBRLViewerPlugin/viewer/src/js/unit.test.js b/iXBRLViewerPlugin/viewer/src/js/unit.test.js
index 6bd1f17d2..ac1062c62 100644
--- a/iXBRLViewerPlugin/viewer/src/js/unit.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/unit.test.js
@@ -1,7 +1,7 @@
 // See COPYRIGHT.md for copyright information
 
 import { Unit } from "./unit.js";
-import { iXBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 import { TestInspector } from "./test-utils.js";
 
 var testReportData = {
@@ -9,13 +9,14 @@ var testReportData = {
         "eg": "http://www.example.com",
         "iso4217": "http://www.xbrl.org/2003/iso4217",
         "e": "http://example.com/entity",
-    }
+    },
+    "facts": {}
 };
 
 function testReport() {
     // Deep copy of standing data
     const data = JSON.parse(JSON.stringify(testReportData));
-    const report = new iXBRLReport(data);
+    const report = new ReportSet(data);
     report.setIXNodeMap({});
     return report;
 }

From da82fa53250450ca9ee77b337913eb50d33f9ad9 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Sun, 24 Sep 2023 19:43:56 +0100
Subject: [PATCH 08/32] Test fixes.

---
 iXBRLViewerPlugin/viewer/src/js/inspector.js  |  4 +--
 iXBRLViewerPlugin/viewer/src/js/report.js     | 10 +++----
 .../viewer/src/js/report.test.js              | 28 +++++++++++--------
 iXBRLViewerPlugin/viewer/src/js/reportset.js  | 12 ++++----
 4 files changed, 28 insertions(+), 26 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index d84018bb3..c5925edae 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -112,7 +112,7 @@ export class Inspector {
 
                 // Listen to messages posted to this window
                 $(window).on("message", (e) => inspector.handleMessage(e));
-                reportSet.setViewerOptions(inspector._viewerOptions);
+                reportSet.viewerOptions = inspector._viewerOptions;
                 inspector.summary = new DocumentSummary(reportSet);
                 inspector.createSummary()
                 inspector.outline = new DocumentOutline(reportSet);
@@ -679,7 +679,7 @@ export class Inspector {
         const a = new Accordian();
 
         for (const [e, rolePrefix] of Object.entries(calc.elrs())) {
-            const label = report.getRoleLabel(rolePrefix, inspector._viewerOptions);
+            const label = report.getRoleLabel(rolePrefix);
 
             const rCalc = calc.resolvedCalculation(e);
             const calcBody = $('<div></div>');
diff --git a/iXBRLViewerPlugin/viewer/src/js/report.js b/iXBRLViewerPlugin/viewer/src/js/report.js
index 367176828..d10a793b7 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.js
@@ -4,7 +4,6 @@ import { Fact } from "./fact.js"
 import { Footnote } from "./footnote.js"
 import { QName } from "./qname.js"
 import { Concept } from "./concept.js";
-import { ViewerOptions } from "./viewerOptions.js";
 import { setDefault, viewerUniqueId } from "./util.js";
 import $ from 'jquery'
 import i18next from "i18next";
@@ -16,7 +15,6 @@ export function XBRLReport(reportSet, reportData) {
     this.reportSet = reportSet;
     this._reportData = reportData;
     // A map of IDs to Fact and Footnote objects
-    this._viewerOptions = new ViewerOptions();
     this._reverseRelationshipCache = {};
 }
 
@@ -146,7 +144,7 @@ XBRLReport.prototype.getConcept = function(name) {
     return new Concept(this, name);
 }
 
-XBRLReport.prototype.getRoleLabel = function(rolePrefix, viewerOptions) {
+XBRLReport.prototype.getRoleLabel = function(rolePrefix) {
     /* This is currently hard-coded to "en" as the generator does not yet
      * support generic labels, and instead provides the (non-localisable) role
      * definition as a single "en" label.
@@ -162,7 +160,7 @@ XBRLReport.prototype.getRoleLabel = function(rolePrefix, viewerOptions) {
             return label;
         }
     }
-    return this.roleMap()[rolePrefix];
+    return this.reportSet.roleMap()[rolePrefix];
 }
 
 XBRLReport.prototype.localDocuments = function() {
@@ -193,7 +191,7 @@ XBRLReport.prototype.concepts = function() {
 
 XBRLReport.prototype.getLabel = function(c, rolePrefix, showPrefix) {
     rolePrefix = rolePrefix || 'std';
-    const lang = this._viewerOptions.language;
+    const lang = this.reportSet.viewerOptions.language;
     const concept = this._reportData.concepts[c];
     if (concept === undefined) {
         console.log("Attempt to get label for undefined concept: " + c);
@@ -216,7 +214,7 @@ XBRLReport.prototype.getLabel = function(c, rolePrefix, showPrefix) {
             return undefined;
         }
         var s = '';
-        if (showPrefix && this._viewerOptions.showPrefixes) {
+        if (showPrefix && this.reportSet.viewerOptions.showPrefixes) {
             s = "(" + this.qname(c).prefix + ") ";
         }
         s += label;
diff --git a/iXBRLViewerPlugin/viewer/src/js/report.test.js b/iXBRLViewerPlugin/viewer/src/js/report.test.js
index 3880ab5c8..cee9183c1 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.test.js
@@ -1,6 +1,6 @@
 // See COPYRIGHT.md for copyright information
 
-import { XBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 import { ViewerOptions } from "./viewerOptions.js";
 
 var testReportData = {
@@ -66,15 +66,16 @@ var testReportData = {
 
 
 describe("Language options", () => {
-    var testReport = new XBRLReport(testReportData);
+    const testReportSet = new ReportSet(testReportData);
+    testReportSet._initialize();
     test("Available languages", () => {
-        var al = testReport.availableLanguages();
+        const al = testReportSet.availableLanguages();
         expect(al).toHaveLength(6);
         expect(al).toEqual(expect.arrayContaining(["en", "en-us", "en-gb", "fr", "de", "es"]));
     });
 
     test("Names for available languages", () => {
-        var ln = testReport.languageNames();
+        const ln = testReportSet.languageNames();
         expect(Object.keys(ln)).toHaveLength(2);
         expect(ln['en']).toBe("English");
         expect(ln['en-us']).toBe("English (US)");
@@ -82,24 +83,27 @@ describe("Language options", () => {
 });
 
 describe("Fetching facts", () => {
-    var testReport = new XBRLReport(testReportData);
+    const testReportSet = new ReportSet(testReportData);
+    testReportSet._initialize();
 
     test("Successful", () => {
-        var f = testReport.getItemById("f1");
+        const f = testReportSet.getItemById("0-f1");
         expect(f).not.toBeNull();
         expect(f.decimals()).toEqual(-3);
     });
 
     test("Non-existent fact", () => {
-        var f = testReport.getItemById("fact-does-not-exist");
+        const f = testReportSet.getItemById("fact-does-not-exist");
         expect(f).toBeUndefined();
     });
 });
 
 describe("Concept labels", () => {
-    var testReport = new XBRLReport(testReportData);
-    var vo = new ViewerOptions();
-    testReport.setViewerOptions(vo);
+    const testReportSet = new ReportSet(testReportData);
+    testReportSet._initialize();
+    const testReport = testReportSet.reports[0];
+    const vo = new ViewerOptions();
+    testReportSet.viewerOptions = vo;
     test("Label fallback", () => {
         vo.language = 'fr';
         expect(testReport.getLabel('eg:Concept3', 'std')).toBe("Concept trois");
@@ -129,7 +133,9 @@ describe("Concept labels", () => {
 });
 
 describe("ELR labels", () => {
-    const testReport = new XBRLReport(testReportData);
+    const testReportSet = new ReportSet(testReportData);
+    testReportSet._initialize();
+    const testReport = testReportSet.reports[0];
     test("Present", () => {
         expect(testReport.getRoleLabel("role1")).toBe("Role 1 Label");
     });
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index 22b9a4267..27aa36626 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -5,7 +5,8 @@ import { Fact } from "./fact.js"
 import { Footnote } from "./footnote.js"
 import { Unit } from "./unit";
 import { titleCase, viewerUniqueId } from "./util.js";
-import { QName } from "./qname.js"
+import { QName } from "./qname.js";
+import { ViewerOptions } from './viewerOptions.js';
 import $ from 'jquery'
 
 
@@ -17,6 +18,7 @@ export class ReportSet {
     constructor(data) {
         this._data = data;
         this._ixNodeMap = {};
+        this.viewerOptions = new ViewerOptions()
     }
 
     /*
@@ -71,10 +73,10 @@ export class ReportSet {
 
 
     availableLanguages() {
-        return this.reports.reduce(
+        return Array.from(this.reports.reduce(
             (langs, report) => new Set([...langs, ...report.availableLanguages()]), 
             new Set()
-        );
+        ));
     }
 
     getItemById(id) {
@@ -205,8 +207,4 @@ export class ReportSet {
         return this._data.validation;
     }
     
-    setViewerOptions(vo) {
-        this._viewerOptions = vo;
-    }
-
 }

From 69229f513add915355e93f98693c1486d46c3a00 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 25 Sep 2023 22:14:26 +0100
Subject: [PATCH 09/32] Modernize code.

---
 iXBRLViewerPlugin/viewer/src/js/factset.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/factset.js b/iXBRLViewerPlugin/viewer/src/js/factset.js
index 460c5de93..5d83706b0 100644
--- a/iXBRLViewerPlugin/viewer/src/js/factset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/factset.js
@@ -10,10 +10,10 @@ export class FactSet {
 
     /* Returns the union of dimensions present on facts in the set */
     _allDimensions() {
-        var dims = {};
-        var facts = this._items.filter((item) => item instanceof Fact);
-        for (var i = 0; i < facts.length; i++) {
-            var dd = Object.keys(facts[i].dimensions());
+        const dims = {};
+        const facts = this._items.filter((item) => item instanceof Fact);
+        for (const fact of facts) {
+            const dd = Object.keys(fact.dimensions());
             for (var j = 0; j < dd.length; j++) {
                 dims[dd[j]] = true;
             }

From 75ea6a1fa4edb36590a6430ddc47b47eaf4d71b8 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 25 Sep 2023 22:42:31 +0100
Subject: [PATCH 10/32] Fix tests

---
 iXBRLViewerPlugin/viewer/src/js/aspect.js     |   2 +-
 .../viewer/src/js/aspect.test.js              |  66 ++++----
 iXBRLViewerPlugin/viewer/src/js/chart.test.js |  15 +-
 .../viewer/src/js/concept.test.js             |   7 +-
 .../viewer/src/js/factset.test.js             |  61 +++----
 .../viewer/src/js/inspector.test.js           |  44 ++---
 .../viewer/src/js/outline.test.js             | 150 +++++++++---------
 .../viewer/src/js/summary.test.js             |  52 +++---
 8 files changed, 215 insertions(+), 182 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/aspect.js b/iXBRLViewerPlugin/viewer/src/js/aspect.js
index 2dafa28d5..795f548b4 100644
--- a/iXBRLViewerPlugin/viewer/src/js/aspect.js
+++ b/iXBRLViewerPlugin/viewer/src/js/aspect.js
@@ -56,7 +56,7 @@ export class Aspect {
             return this._report.getLabel(this._value, rolePrefix) || this._value;
         }
         else if (this._aspect === 'u') {
-            return this._report.getUnit(this._value).measureLabel();
+            return this._report.reportSet.getUnit(this._value).measureLabel();
         }
         else if (this._aspect === 'p') {
             const p = new Period(this._value);
diff --git a/iXBRLViewerPlugin/viewer/src/js/aspect.test.js b/iXBRLViewerPlugin/viewer/src/js/aspect.test.js
index 03815166a..f794cd177 100644
--- a/iXBRLViewerPlugin/viewer/src/js/aspect.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/aspect.test.js
@@ -1,14 +1,15 @@
 // See COPYRIGHT.md for copyright information
 
 import { Aspect, AspectSet } from "./aspect.js";
-import { XBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 import { TestInspector } from "./test-utils.js";
 
-var testReportData = {
+const testReportData = {
     "prefixes": {
         "eg": "http://www.example.com",
         "iso4217": "http://www.xbrl.org/2003/iso4217"
     },
+    "facts" : {},
     "concepts": {
         "eg:Concept1": {
             "labels": {
@@ -43,75 +44,82 @@ var testReportData = {
     }
 };
 
-var insp = new TestInspector();
+const insp = new TestInspector();
 beforeAll(() => {
     return insp.i18nInit();
 });
 
-var testReport = new XBRLReport(testReportData);
+const testReportSet = new ReportSet(testReportData);
+testReportSet._initialize();
+const testReport = testReportSet.reports[0];
 
 test("Concept aspect labels", () => {
-    var conceptAspect = new Aspect("c", "eg:Concept1", testReport);
+    const conceptAspect = new Aspect("c", "eg:Concept1", testReport);
     expect(conceptAspect.label()).toBe("Concept");  
     expect(conceptAspect.valueLabel()).toBe("English label");  
 });
 
 test("Period aspect labels", () => {
-    var periodAspect = new Aspect("p", "2018-01-01/2019-01-01", testReport);
+    const periodAspect = new Aspect("p", "2018-01-01/2019-01-01", testReport);
     expect(periodAspect.label()).toBe("Period");  
     expect(periodAspect.valueLabel()).toBe("1 Jan 2018 to 31 Dec 2018");  
 });
 
 test("Unit aspects label - known currency", () => {
-    var unitAspect = new Aspect("u", "iso4217:GBP", testReport);
+    const unitAspect = new Aspect("u", "iso4217:GBP", testReport);
     expect(unitAspect.label()).toBe("Unit");  
     expect(unitAspect.valueLabel()).toBe("£");  
 });
 
 test("Unit aspects label - known currency (EUR)", () => {
-    var unitAspect = new Aspect("u", "iso4217:EUR", testReport);
+    const unitAspect = new Aspect("u", "iso4217:EUR", testReport);
     expect(unitAspect.label()).toBe("Unit");  
     expect(unitAspect.valueLabel()).toBe("€");  
 });
 
 test("Unit aspects label - unknown currency", () => {
-    var unitAspect = new Aspect("u", "iso4217:ZAR", testReport);
+    const unitAspect = new Aspect("u", "iso4217:ZAR", testReport);
     expect(unitAspect.label()).toBe("Unit");
     expect(unitAspect.valueLabel()).toBe("ZAR");
 });
 
 test("Entity aspect labels - unknown scheme", () => {
-    var tda = new Aspect("e", "eg:1234567", testReport);
+    const tda = new Aspect("e", "eg:1234567", testReport);
     expect(tda.label()).toBe("Entity");  
     expect(tda.valueLabel()).toBe("eg:1234567");  
 });
 
-test("Taxonomy defined dimension labels", () => {
-    var tda = new Aspect("eg:ExplicitDimension", "eg:Concept2", testReport);
-    expect(tda.label()).toBe("Explicit dimension");
-    expect(tda.valueLabel()).toBe("English label for concept two");
-
-    tda = new Aspect("eg:TypedDimension", "eg:Concept2", testReport);
-    expect(tda.label()).toBe("Typed dimension");
-    // "eg:Concept2" should be treated as a string, not a member name
-    expect(tda.valueLabel()).toBe("eg:Concept2");
-
-    tda = new Aspect("eg:TypedDimension", "1 2 3 4", testReport);
-    expect(tda.label()).toBe("Typed dimension");
-    expect(tda.valueLabel()).toBe("1 2 3 4");
-
-    tda = new Aspect("eg:TypedDimension", null, testReport);
-    expect(tda.label()).toBe("Typed dimension");
-    expect(tda.valueLabel()).toBe("nil");
+describe("Taxonomy defined dimension labels", () => {
+    test("Explicit dimension", () => {
+        const tda = new Aspect("eg:ExplicitDimension", "eg:Concept2", testReport);
+        expect(tda.label()).toBe("Explicit dimension");
+        expect(tda.valueLabel()).toBe("English label for concept two");
+    });
+    test("Typed dimension - qname-like value", () => {
+        const tda = new Aspect("eg:TypedDimension", "eg:Concept2", testReport);
+        expect(tda.label()).toBe("Typed dimension");
+        // "eg:Concept2" should be treated as a string, not a member name
+        expect(tda.valueLabel()).toBe("eg:Concept2");
+    });
+    test("Typed dimension - string value", () => {
+        const tda = new Aspect("eg:TypedDimension", "1 2 3 4", testReport);
+        expect(tda.label()).toBe("Typed dimension");
+        expect(tda.valueLabel()).toBe("1 2 3 4");
+    });
+    test("Typed dimension - nil value", () => {
+        const tda = new Aspect("eg:TypedDimension", null, testReport);
+        expect(tda.label()).toBe("Typed dimension");
+        expect(tda.valueLabel()).toBe("nil");
+    });
 });
 
 describe("AspectSet", () => {
     test("Unique values", () => {
-        var as = new AspectSet()
+        const as = new AspectSet()
         as.add(new Aspect("c", "eg:Concept1", testReport));
         as.add(new Aspect("c", "eg:Concept2", testReport));
         as.add(new Aspect("c", "eg:Concept1", testReport));
-        var uv = as.uniqueValues()
+        const uv = as.uniqueValues()
         expect(uv).toHaveLength(2);
         expect(uv.map(x => x.value())).toEqual(expect.arrayContaining(["eg:Concept1", "eg:Concept2"]));
     });
diff --git a/iXBRLViewerPlugin/viewer/src/js/chart.test.js b/iXBRLViewerPlugin/viewer/src/js/chart.test.js
index da176e325..3997bcd42 100644
--- a/iXBRLViewerPlugin/viewer/src/js/chart.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/chart.test.js
@@ -2,7 +2,7 @@
 
 import { Fact } from "./fact.js";
 import { IXBRLChart } from "./chart.js";
-import { XBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 import { TestInspector } from "./test-utils.js";
 
 var testReportData = {
@@ -74,21 +74,22 @@ var testReportData = {
 
 function testReport(facts, ixData) {
     // Deep copy of standing data
-    var data = JSON.parse(JSON.stringify(testReportData));
+    const data = JSON.parse(JSON.stringify(testReportData));
     data.facts = facts;
-    var report = new XBRLReport(data);
-    report.setIXNodeMap(ixData);
-    return report;
+    const reportSet = new ReportSet(data);
+    reportSet.setIXNodeMap(ixData);
+    return reportSet;
 }
 
 function testFact(factData, ixData) {
     factData.a = factData.a || {};
     factData.a.c = factData.a.c || 'eg:Concept1';
     ixData = ixData || {};
-    return new Fact(testReport({"f1": factData}, {"f1": ixData }), "f1");
+    const reportSet = testReport({"f1": factData}, {"f1": ixData });
+    return reportSet.getItemById("0-f1"); 
 }
 
-var insp = new TestInspector();
+const insp = new TestInspector();
 beforeAll(() => {
     return insp.i18nInit();
 });
diff --git a/iXBRLViewerPlugin/viewer/src/js/concept.test.js b/iXBRLViewerPlugin/viewer/src/js/concept.test.js
index 624d3a5e5..24f704518 100644
--- a/iXBRLViewerPlugin/viewer/src/js/concept.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/concept.test.js
@@ -1,8 +1,9 @@
 // See COPYRIGHT.md for copyright information
 
 import { XBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 
-var testReportData = {
+const testReportData = {
     "prefixes": {
         "eg": "http://www.example.com",
         "iso4217": "http://www.xbrl.org/2003/iso4217",
@@ -48,7 +49,9 @@ var testReportData = {
 };
 
 describe("Concept references", () => {
-    var r = new XBRLReport(testReportData);
+    const rs = new ReportSet(testReportData);
+    rs._initialize();
+    const r = rs.reports[0];
     test("Absent reference", () => {
         var c1 = r.getConcept("eg:Concept1");
         expect(c1.referenceValuesAsString()).toEqual("");
diff --git a/iXBRLViewerPlugin/viewer/src/js/factset.test.js b/iXBRLViewerPlugin/viewer/src/js/factset.test.js
index 781b745a9..a15e7a8da 100644
--- a/iXBRLViewerPlugin/viewer/src/js/factset.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/factset.test.js
@@ -2,7 +2,9 @@
 
 import { Fact } from "./fact.js";
 import { FactSet } from "./factset.js";
+import { viewerUniqueId } from "./util.js";
 import { XBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 
 var i = 0;
 
@@ -73,10 +75,11 @@ var testReportData = {
 
 function testReport(facts) {
     // Deep copy of standing data
-    var data = JSON.parse(JSON.stringify(testReportData));
+    const data = JSON.parse(JSON.stringify(testReportData));
     data.facts = facts;
-    var report = new XBRLReport(data);
-    return report;
+    const reportset = new ReportSet(data);
+    reportset._initialize();
+    return reportset;
 }
 
 function testFact(aspectData) {
@@ -84,42 +87,46 @@ function testFact(aspectData) {
     return factData;
 }
 
+function getFact(reportSet, id) {
+  return reportSet.getItemById(viewerUniqueId(0, id));
+}
+
 describe("Minimally unique labels (non-dimensional)", () => {
-  var report = testReport({ 
+  const reportSet = testReport({ 
       "f1": testFact({"c": "eg:Concept1", "p": "2018-01-01"}),
       "f2": testFact({"c": "eg:Concept2", "p": "2018-01-01"}),
       "f3": testFact({"c": "eg:Concept2", "p": "2019-01-01"}),
       "f4": testFact({"c": "eg:Concept2", "p": "2019-01-01"}),
   });
 
-  var f1 = new Fact(report, "f1");
-  var f2 = new Fact(report, "f2");
-  var f3 = new Fact(report, "f3");
-  var f4 = new Fact(report, "f3");
+  const f1 = getFact(reportSet, "f1");
+  const f2 = getFact(reportSet, "f2");
+  const f3 = getFact(reportSet, "f3");
+  const f4 = getFact(reportSet, "f4");
 
   test("Different concept", () => {
-    var fs = new FactSet([ f1, f2 ]);
+    const fs = new FactSet([ f1, f2 ]);
     expect(fs._allDimensions()).toEqual([]);
     expect(fs.minimallyUniqueLabel(f1)).toEqual("Concept 1");
     expect(fs.minimallyUniqueLabel(f2)).toEqual("Concept 2");
   });
 
   test("Different period", () => {
-    var fs = new FactSet([ f2, f3 ]);
+    const fs = new FactSet([ f2, f3 ]);
     expect(fs._allDimensions()).toEqual([]);
     expect(fs.minimallyUniqueLabel(f2)).toEqual("31 Dec 2017");
     expect(fs.minimallyUniqueLabel(f3)).toEqual("31 Dec 2018");
   });
 
   test("Different concept and period, concept takes precedence", () => {
-    var fs = new FactSet([ f1, f4 ]);
+    const fs = new FactSet([ f1, f4 ]);
     expect(fs._allDimensions()).toEqual([]);
     expect(fs.minimallyUniqueLabel(f1)).toEqual("Concept 1");
     expect(fs.minimallyUniqueLabel(f4)).toEqual("Concept 2");
   });
 
   test("Mix of period and concept differences", () => {
-    var fs = new FactSet([ f1, f2, f3 ]);
+    const fs = new FactSet([ f1, f2, f3 ]);
     expect(fs._allDimensions()).toEqual([]);
     expect(fs.minimallyUniqueLabel(f1)).toEqual("Concept 1, 31 Dec 2017");
     expect(fs.minimallyUniqueLabel(f2)).toEqual("Concept 2, 31 Dec 2017");
@@ -128,27 +135,27 @@ describe("Minimally unique labels (non-dimensional)", () => {
 });
 
 describe("Minimally unique labels (dimensional)", () => {
-  var report = testReport({ 
+  const reportSet = testReport({ 
       "f1": testFact({"c": "eg:Concept1", "p": "2018-01-01", "eg:Dimension1": "eg:DimensionValue1"}),
       "f2": testFact({"c": "eg:Concept1", "p": "2018-01-01", "eg:Dimension1": "eg:DimensionValue2"}),
       "f3": testFact({"c": "eg:Concept1", "p": "2019-01-01", "eg:Dimension1": "eg:DimensionValue2"}),
       "f4": testFact({"c": "eg:Concept1", "p": "2018-01-01" }),
   });
 
-  var f1 = new Fact(report, "f1");
-  var f2 = new Fact(report, "f2");
-  var f3 = new Fact(report, "f3");
-  var f4 = new Fact(report, "f4");
+  const f1 = getFact(reportSet, "f1");
+  const f2 = getFact(reportSet, "f2");
+  const f3 = getFact(reportSet, "f3");
+  const f4 = getFact(reportSet, "f4");
 
   test("Same concept & period, different dimension value", () => {
-    var fs = new FactSet([ f1, f2 ]);
+    const fs = new FactSet([ f1, f2 ]);
     expect(fs._allDimensions()).toEqual(["eg:Dimension1"]);
     expect(fs.minimallyUniqueLabel(f1)).toEqual("Dimension Value 1");
     expect(fs.minimallyUniqueLabel(f2)).toEqual("Dimension Value 2");
   });
 
   test("Different period, different dimension value", () => {
-    var fs = new FactSet([ f1, f3 ]);
+    const fs = new FactSet([ f1, f3 ]);
     expect(fs._allDimensions()).toEqual(["eg:Dimension1"]);
     /* Different period takes precedence */
     expect(fs.minimallyUniqueLabel(f1)).toEqual("31 Dec 2017");
@@ -156,7 +163,7 @@ describe("Minimally unique labels (dimensional)", () => {
   });
 
   test("Dimension present on one fact only", () => {
-    var fs = new FactSet([ f1, f4 ]);
+    const fs = new FactSet([ f1, f4 ]);
     expect(fs._allDimensions()).toEqual(["eg:Dimension1"]);
     /* Concept is included even though it's the same across all to avoid an
      * empty label */
@@ -167,16 +174,16 @@ describe("Minimally unique labels (dimensional)", () => {
 });
 
 describe("Minimally unique labels (duplicate facts)", () => {
-  var report = testReport({ 
+  const reportSet = testReport({ 
       "f1": testFact({"c": "eg:Concept1", "p": "2018-01-01", "eg:Dimension1": "eg:DimensionValue1"}),
       "f2": testFact({"c": "eg:Concept1", "p": "2018-01-01", "eg:Dimension1": "eg:DimensionValue1"}),
   });
 
-  var f1 = new Fact(report, "f1");
-  var f2 = new Fact(report, "f2");
+  const f1 = getFact(reportSet, "f1");
+  const f2 = getFact(reportSet, "f2");
 
   test("Two facts, all aspects the same", () => {
-    var fs = new FactSet([ f1, f2 ]);
+    const fs = new FactSet([ f1, f2 ]);
     expect(fs._allDimensions()).toEqual(["eg:Dimension1"]);
     expect(fs.minimallyUniqueLabel(f1)).toEqual("Concept 1");
     expect(fs.minimallyUniqueLabel(f2)).toEqual("Concept 1");
@@ -184,13 +191,13 @@ describe("Minimally unique labels (duplicate facts)", () => {
 });
 
 describe("Minimally unique labels (missing labels)", () => {
-  var report = testReport({ 
+  const reportSet = testReport({ 
       "f1": testFact({"c": "eg:Concept1", "p": "2018-01-01" }),
       "f2": testFact({"c": "eg:Concept4", "p": "2018-01-01" }),
   });
 
-  var f1 = new Fact(report, "f1");
-  var f2 = new Fact(report, "f2");
+  const f1 = getFact(reportSet, "f1");
+  const f2 = getFact(reportSet, "f2");
 
   test("Two facts, one has no label", () => {
     var fs = new FactSet([ f1, f2 ]);
diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.test.js b/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
index 25ba7bd04..1ed893aca 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
@@ -1,11 +1,12 @@
 // See COPYRIGHT.md for copyright information
 
 import { Fact } from "./fact.js";
-import { XBRLReport } from "./report.js";
+import { ReportSet } from "./reportset.js";
 import { TestInspector } from "./test-utils.js";
+import { viewerUniqueId } from "./util.js";
 
 
-var testReportData = {
+const testReportData = {
     "prefixes": {
         "eg": "http://www.example.com",
         "iso4217": "http://www.xbrl.org/2003/iso4217",
@@ -44,37 +45,38 @@ var testReportData = {
 
 function testReport(facts, ixData) {
     // Deep copy of standing data
-    var data = JSON.parse(JSON.stringify(testReportData));
+    const data = JSON.parse(JSON.stringify(testReportData));
     data.facts = facts;
-    var report = new XBRLReport(data);
-    report.setIXNodeMap(ixData);
-    return report;
+    const reportSet = new ReportSet(data);
+    reportSet.setIXNodeMap(ixData);
+    return reportSet;
 }
 
 function fromFact(value) {
-    var factData = {
+    const factData = {
                 "v": value,
                 "a": {
                     "c": "eg:Concept1",
                     "u": "iso4217:USD", 
                     "p": "2017-01-01/2018-01-01",
                 }};
-    return new Fact(testReport({"f1": factData}, {"f1": {} }), "f1");
+    return testReport({"f1": factData}, {"f1": {} }).getItemById("0-f1");
 }
 
 function toFact(value) {
-    var factData = {
+    const factData = {
                 "v": value,
                 "a": {
                     "c": "eg:Concept1",
                     "u": "iso4217:USD", 
                     "p": "2018-01-01/2019-01-01",
                 }};
-    return new Fact(testReport({"f1": factData}, {"f1": {} }), "f1");
+    
+    return testReport({"f1": factData}, {"f1": {} }).getItemById("0-f1");
 }
 
 describe("Describe changes", () => {
-    var insp = new TestInspector();
+    const insp = new TestInspector();
     beforeAll(() => {
         return insp.i18nInit();
     });
@@ -117,7 +119,7 @@ describe("Scales filter options", () => {
         if (scale !== 0) {
             ixNode["scale"] = scale;
         }
-        ixData[id] = ixNode;
+        ixData[viewerUniqueId(0, id)] = ixNode;
     }
     const nonMonetaryFactData = {};
     for (let scale = -4; scale < 11; scale++) {
@@ -127,16 +129,16 @@ describe("Scales filter options", () => {
         if (scale !== 0) {
             ixNode["scale"] = scale;
         }
-        ixData[id] = ixNode;
+        ixData[viewerUniqueId(0, id)] = ixNode;
     }
 
     test("Scales filter options with monetary and non-monetary facts", () => {
-        var insp = new TestInspector();
-        const report = testReport({
+        const insp = new TestInspector();
+        const reportSet = testReport({
             ...monetaryFactData,
             ...nonMonetaryFactData,
         }, ixData);
-        insp.initialize(report)
+        insp.initialize(reportSet)
         insp.i18nInit();
         const scalesOptions = insp._getScalesOptions();
         expect(scalesOptions).toEqual({
@@ -159,10 +161,10 @@ describe("Scales filter options", () => {
 
     test("Scales filter options with only monetary facts", () => {
         var insp = new TestInspector();
-        const report = testReport({
+        const reportSet = testReport({
             ...monetaryFactData,
         }, ixData);
-        insp.initialize(report)
+        insp.initialize(reportSet)
         insp.i18nInit();
         const scalesOptions = insp._getScalesOptions();
         expect(scalesOptions).toEqual({
@@ -184,11 +186,11 @@ describe("Scales filter options", () => {
     })
 
     test("Scales filter options with only non-monetary facts", () => {
-        var insp = new TestInspector();
-        const report = testReport({
+        const insp = new TestInspector();
+        const reportSet = testReport({
             ...nonMonetaryFactData,
         }, ixData);
-        insp.initialize(report)
+        insp.initialize(reportSet)
         insp.i18nInit();
         const scalesOptions = insp._getScalesOptions();
         expect(scalesOptions).toEqual({
diff --git a/iXBRLViewerPlugin/viewer/src/js/outline.test.js b/iXBRLViewerPlugin/viewer/src/js/outline.test.js
index 055c22960..2ebd6266b 100644
--- a/iXBRLViewerPlugin/viewer/src/js/outline.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/outline.test.js
@@ -4,6 +4,7 @@ import $ from 'jquery'
 import { ReportSet } from "./reportset.js";
 import { DocumentOutline } from "./outline.js";
 import { IXNode } from "./ixnode.js";
+import { viewerUniqueId } from "./util.js";
 
 const testReportData = {
     prefixes: {
@@ -165,56 +166,60 @@ const testFacts =  {
         },
     };
 
-function testReport(factList) {
+function testReportSet(factList) {
     // Deep copy of standing data
-    var data = JSON.parse(JSON.stringify(testReportData));
-    var ixNodeMap = {};
-    var i = 0;
+    const data = JSON.parse(JSON.stringify(testReportData));
+    const ixNodeMap = {};
+    let i = 0;
     data.facts = {};
     for (const f of factList) {
         data.facts[f] = testFacts[f];
-        ixNodeMap[f] = new IXNode(f, $('<span></span>'), i++);
+        ixNodeMap[viewerUniqueId(0,f)] = new IXNode(f, $('<span></span>'), i++);
     }
-    var report = new ReportSet(data);
-    report.setIXNodeMap(ixNodeMap);
-    return report;
+    const reportSet = new ReportSet(data);
+    reportSet.setIXNodeMap(ixNodeMap);
+    return reportSet;
+}
+
+function getFact(rs, id) {
+    return rs.getItemById(viewerUniqueId(0, id));
 }
 
 describe("Section filtering", () => {
     // f1 has a line item from elr1, f2 has a line item from elr3
     test("Both groups", () => {
-        var report = testReport(["f1", "f2"]);
-        var outline = new DocumentOutline(report);
-        expect(outline.factInGroup(report.getItemById("f1"), "elr1")).toBe(true);
-        expect(outline.factInGroup(report.getItemById("f1"), "elr2")).toBe(false);
-        expect(outline.factInGroup(report.getItemById("f1"), "elr3")).toBe(false);
+        const reportSet = testReportSet(["f1", "f2"]);
+        const outline = new DocumentOutline(reportSet);
+        expect(outline.factInGroup(getFact(reportSet, "f1"), "elr1")).toBe(true);
+        expect(outline.factInGroup(getFact(reportSet, "f1"), "elr2")).toBe(false);
+        expect(outline.factInGroup(getFact(reportSet, "f1"), "elr3")).toBe(false);
 
-        expect(outline.factInGroup(report.getItemById("f2"), "elr1")).toBe(false);
-        expect(outline.factInGroup(report.getItemById("f2"), "elr2")).toBe(false);
-        expect(outline.factInGroup(report.getItemById("f2"), "elr3")).toBe(true);
+        expect(outline.factInGroup(getFact(reportSet, "f2"), "elr1")).toBe(false);
+        expect(outline.factInGroup(getFact(reportSet, "f2"), "elr2")).toBe(false);
+        expect(outline.factInGroup(getFact(reportSet, "f2"), "elr3")).toBe(true);
 
         expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
     });
 
     test("First group", () => {
-        var report = testReport(["f1"]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f1"]);
+        const outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1"]);
     });
 
     test("Last group", () => {
-        var report = testReport(["f2"]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f2"]);
+        const outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr3"]);
     });
 });
 
 describe("Dimensional filtering", () => {
     test("Simple", () => {
-        var report = testReport(["f3"]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f3"]);
+        let outline = new DocumentOutline(reportSet);
         // ELR1 does not mention Dimension 1, so f3 is included.
-        var f3 = report.getItemById("f3");
+        const f3 = getFact(reportSet, "f3");
         expect(outline.factInGroup(f3, "elr1")).toBe(true);
         // ELR1 includes Dimension 2 with specified member, so included
         expect(outline.factInGroup(f3, "elr2")).toBe(true);
@@ -227,12 +232,12 @@ describe("Dimensional filtering", () => {
         expect(outline.groupsForFact(f3)).toEqual(["elr1", "elr2"]);
 
         // Exclude Member1 from Dimension1 in ELR2
-        report.data.rels.pres.elr2['eg:Dimension1'] = [
+        reportSet.reports[0]._reportData.rels.pres.elr2['eg:Dimension1'] = [
             { "t": "eg:Member2" }
         ];
-        report._reverseRelationshipCache = {}; 
+        reportSet.reports[0]._reverseRelationshipCache = {}; 
 
-        outline = new DocumentOutline(report);
+        outline = new DocumentOutline(reportSet);
 
         // ELR1 does not mention Dimension 1, so f3 is included.
         expect(outline.factInGroup(f3, "elr1")).toBe(true);
@@ -248,9 +253,9 @@ describe("Dimensional filtering", () => {
     });
 
     test("Typed Dimensions", () => {
-        var report = testReport(["ft"]);
-        var outline = new DocumentOutline(report);
-        var ft = report.getItemById("ft");
+        const reportSet = testReportSet(["ft"]);
+        const outline = new DocumentOutline(reportSet);
+        const ft = getFact(reportSet, "ft");
         expect(outline.factInGroup(ft, "elr1")).toBe(true);
         // Missing required Dimension1
         expect(outline.factInGroup(ft, "elr2")).toBe(false);
@@ -261,24 +266,25 @@ describe("Dimensional filtering", () => {
 
     test("Defaults", () => {
         // Make Member1 the default for Dimension1
-        var report = testReport(["f1", "f2", "f3"]);
-        report.data.rels["d-d"] = { elr1: { 'eg:Dimension1': [ { t: 'eg:Member1' } ] } };
+        const reportSet = testReportSet(["f1", "f2", "f3"]);
+        const report = reportSet.reports[0];
+        report._reportData.rels["d-d"] = { elr1: { 'eg:Dimension1': [ { t: 'eg:Member1' } ] } };
 
-        var outline = new DocumentOutline(report);
-        var f1 = report.getItemById("f1");
+        const outline = new DocumentOutline(reportSet);
+        const f1 = getFact(reportSet, "f1");
         expect(outline.factInGroup(f1, "elr1")).toBe(true);
         // f1 is now included in elr2 because the default member is in ELR2
         expect(outline.factInGroup(f1, "elr2")).toBe(true);
         expect(outline.factInGroup(f1, "elr3")).toBe(false);
 
         // This should be unchanged
-        var f1 = report.getItemById("f2");
-        expect(outline.factInGroup(report.getItemById("f2"), "elr1")).toBe(false);
-        expect(outline.factInGroup(report.getItemById("f2"), "elr2")).toBe(false);
-        expect(outline.factInGroup(report.getItemById("f2"), "elr3")).toBe(true);
+        const f2 = getFact(reportSet, "f2");
+        expect(outline.factInGroup(f2, "elr1")).toBe(false);
+        expect(outline.factInGroup(f2, "elr2")).toBe(false);
+        expect(outline.factInGroup(f2, "elr3")).toBe(true);
 
         // f3 is now technically illegal because it includes the default value for a dimension
-        var f3 = report.getItemById("f3");
+        const f3 = getFact(reportSet, "f3");
         expect(outline.factInGroup(f3, "elr1")).toBe(true);
         // ELR2 now excludeds f3 because the default must be omitted
         expect(outline.factInGroup(f3, "elr2")).toBe(false);
@@ -292,71 +298,71 @@ describe("Section grouping", () => {
     // f1* in ELR1, f2* in ELR3
     test("Single group", () => {
         // All facts in a single group
-        var report = testReport(["f1", "f1a"]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f1", "f1a"]);
+        const outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1"]);
-        expect(outline.sections["elr1"].id).toEqual("f1");
+        expect(outline.sections["elr1"].localId()).toEqual("f1");
         expect(outline.sections["elr3"]).toBeUndefined();
     });
 
     test("Longest runs 1", () => {
         // ELR1 is the f1, f1a run
         // ELR3 is the f2a, f2b run
-        var report = testReport(["f1", "f1a", "f2", "f1b", "f2a", "f2b"]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f1", "f1a", "f2", "f1b", "f2a", "f2b"]);
+        const outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
-        expect(outline.sections["elr1"].id).toEqual("f1");
-        expect(outline.sections["elr3"].id).toEqual("f2a");
+        expect(outline.sections["elr1"].localId()).toEqual("f1");
+        expect(outline.sections["elr3"].localId()).toEqual("f2a");
     });
 
     test("Longest runs 2", () => {
         // ELR1 is the f1a, f1b run
         // ELR3 is the f2, f2b run
-        var report = testReport(["f1", "f2", "f2b", "f1a", "f1b", "f2a"]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f1", "f2", "f2b", "f1a", "f1b", "f2a"]);
+        const outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
-        expect(outline.sections["elr1"].id).toEqual("f1a");
-        expect(outline.sections["elr3"].id).toEqual("f2");
+        expect(outline.sections["elr1"].localId()).toEqual("f1a");
+        expect(outline.sections["elr3"].localId()).toEqual("f2");
     });
 
     test("Equal length runs", () => {
         // If multiple runs have the same length, we arbitrarily assign the ELR
         // to the first.
-        var report = testReport(["f1", "f1a", "f2", "f1b", "f1c", "f2b" ]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f1", "f1a", "f2", "f1b", "f1c", "f2b" ]);
+        const outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
-        expect(outline.sections["elr1"].id).toEqual("f1");
-        expect(outline.sections["elr3"].id).toEqual("f2");
+        expect(outline.sections["elr1"].localId()).toEqual("f1");
+        expect(outline.sections["elr3"].localId()).toEqual("f2");
     });
 
     test("Hidden facts", () => {
         // Start with ELR1*2 ELR3*1 ELR1*3
-        var report = testReport(["f1a", "f1", "f2", "f1b", "f1c", "f1d"]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f1a", "f1", "f2", "f1b", "f1c", "f1d"]);
+        let outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
-        expect(outline.sections["elr1"].id).toEqual("f1b");
-        expect(outline.sections["elr3"].id).toEqual("f2");
+        expect(outline.sections["elr1"].localId()).toEqual("f1b");
+        expect(outline.sections["elr3"].localId()).toEqual("f2");
 
         // Make f1c hidden.  We now have ELR1*2 ELR3*1 ELR1*2
         // The first ELR1 run should be selected.
-        report.getItemById("f1c").ixNode.isHidden = true;
-        outline = new DocumentOutline(report);
+        getFact(reportSet, "f1c").ixNode.isHidden = true;
+        outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
-        expect(outline.sections["elr1"].id).toEqual("f1a");
-        expect(outline.sections["elr3"].id).toEqual("f2");
+        expect(outline.sections["elr1"].localId()).toEqual("f1a");
+        expect(outline.sections["elr3"].localId()).toEqual("f2");
 
         // Make f1a hidden.  f1b-[f1c]-f1d is now the longest run.
-        report.getItemById("f1a").ixNode.isHidden = true;
-        outline = new DocumentOutline(report);
+        getFact(reportSet, "f1a").ixNode.isHidden = true;
+        outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
-        expect(outline.sections["elr1"].id).toEqual("f1b");
-        expect(outline.sections["elr3"].id).toEqual("f2");
+        expect(outline.sections["elr1"].localId()).toEqual("f1b");
+        expect(outline.sections["elr3"].localId()).toEqual("f2");
 
         // Hide f2.  We now have a single run for ELR1
-        report.getItemById("f2").ixNode.isHidden = true;
-        outline = new DocumentOutline(report);
+        getFact(reportSet, "f2").ixNode.isHidden = true;
+        outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1"]);
-        expect(outline.sections["elr1"].id).toEqual("f1");
+        expect(outline.sections["elr1"].localId()).toEqual("f1");
 
     });
 });
@@ -364,13 +370,13 @@ describe("Section grouping", () => {
 describe("No presentation", () => {
     // f1 has a line item from elr1, f2 has a line item from elr3
     test("Remove presentation relationships", () => {
-        var report = testReport(["f1", "f2"]);
-        var outline = new DocumentOutline(report);
+        const reportSet = testReportSet(["f1", "f2"]);
+        let outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
         expect(outline.hasOutline()).toEqual(true);
 
-        delete report.data.rels.pres;
-        outline = new DocumentOutline(report);
+        delete reportSet.reports[0]._reportData.rels.pres;
+        outline = new DocumentOutline(reportSet);
         expect(outline.sortedSections()).toEqual([]);
         expect(outline.hasOutline()).toEqual(false);
     });
diff --git a/iXBRLViewerPlugin/viewer/src/js/summary.test.js b/iXBRLViewerPlugin/viewer/src/js/summary.test.js
index 445dc5568..d31cbc450 100644
--- a/iXBRLViewerPlugin/viewer/src/js/summary.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/summary.test.js
@@ -17,19 +17,25 @@ function testFact(conceptName, dimensions) {
     }
 }
 
-function testReport(concepts, facts, documents) {
-    return {
+function testReportSet(concepts, facts, documents) {
+    const report = {
         getConcept: conceptName => concepts[conceptName],
-        facts: () => facts,
         localDocuments: () => documents
     }
+    for (const f of facts) {
+        f.report = () => report;
+    }
+    return {
+        facts: () => facts,
+        reports: [ report ]
+    }
 }
 
 describe("Facts summary", () => {
 
     test("no facts", () => {
-        const report = testReport({}, [], {});
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet({}, [], {});
+        const summary = new DocumentSummary(reportSet);
 
         expect(summary.totalFacts()).toBe(0);
     });
@@ -39,8 +45,8 @@ describe("Facts summary", () => {
         for (let i = 0; i < 10; i++) {
             facts.push(testFact("eg:Concept1", {}));
         }
-        const report = testReport({}, facts, {});
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet({}, facts, {});
+        const summary = new DocumentSummary(reportSet);
 
         expect(summary.totalFacts()).toBe(10);
     });
@@ -49,8 +55,8 @@ describe("Facts summary", () => {
         const conceptName = "eg:Concept1";
         const fact1 = testFact(conceptName, {});
         const fact2 = testFact(conceptName, {});
-        const report = testReport({}, [fact1, fact2], {});
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet({}, [fact1, fact2], {});
+        const summary = new DocumentSummary(reportSet);
 
         expect(summary.totalFacts()).toBe(2);
     });
@@ -60,8 +66,8 @@ describe("Facts summary", () => {
 describe("Tags summary", () => {
 
     test("no tags", () => {
-        const report = testReport({}, [], {})
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet({}, [], {})
+        const summary = new DocumentSummary(reportSet);
 
         expect(summary.tagCounts()).toEqual(new Map());
     });
@@ -70,8 +76,8 @@ describe("Tags summary", () => {
         const fact1 = testFact("eg:Concept1", {});
         const fact2 = testFact("eg:Concept2", {});
         const fact3 = testFact("xz:Concept1", {});
-        const report = testReport({}, [fact1, fact2, fact3], {})
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet({}, [fact1, fact2, fact3], {})
+        const summary = new DocumentSummary(reportSet);
 
         expect(Object.fromEntries(summary.tagCounts())).toEqual({
             'eg': {
@@ -99,8 +105,8 @@ describe("Tags summary", () => {
         const concepts = {
             [dimension]: testConcept(),
         }
-        const report = testReport(concepts, [fact], {})
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet(concepts, [fact], {})
+        const summary = new DocumentSummary(reportSet);
 
         expect(Object.fromEntries(summary.tagCounts())).toEqual({
             'eg': {
@@ -129,8 +135,8 @@ describe("Tags summary", () => {
             [dimension2]: testConcept(),
             [dimension3]: testConcept(),
         }
-        const report = testReport(concepts, [fact], {})
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet(concepts, [fact], {})
+        const summary = new DocumentSummary(reportSet);
 
         expect(Object.fromEntries(summary.tagCounts())).toEqual({
             'ab': {
@@ -170,8 +176,8 @@ describe("Tags summary", () => {
         const concepts = {
             [dimension]: testConcept(typedDomain),
         }
-        const report = testReport(concepts, [fact], {})
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet(concepts, [fact], {})
+        const summary = new DocumentSummary(reportSet);
 
         expect(Object.fromEntries(summary.tagCounts())).toEqual({
             'eg': {
@@ -194,8 +200,8 @@ describe("Files summary", () => {
 
     test("no files", () => {
         const documentData = {}
-        const report = testReport({}, [], documentData);
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet({}, [], documentData);
+        const summary = new DocumentSummary(reportSet);
 
         expect(summary.getLocalDocuments()).toEqual({
             inline: [],
@@ -222,8 +228,8 @@ describe("Files summary", () => {
             'labelLinkbase.xml': ['labelLinkbase'],
             'unrecognizedLinkbase.xml': ['unrecognizedLinkbase'],
         }
-        const report = testReport({}, [], documentData);
-        const summary = new DocumentSummary(report);
+        const reportSet = testReportSet({}, [], documentData);
+        const summary = new DocumentSummary(reportSet);
 
         expect(summary.getLocalDocuments()).toEqual({
             inline: ['docset', 'inline.htm'],

From b9d143763d7230ead0b3a8146e049bd9937adc0b Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Wed, 27 Sep 2023 00:06:09 +0100
Subject: [PATCH 11/32] Multi-doc support for outlines.

---
 .../viewer/src/js/calculations.js             |  4 +-
 iXBRLViewerPlugin/viewer/src/js/fact.js       | 41 +++++------
 iXBRLViewerPlugin/viewer/src/js/inspector.js  | 27 ++++---
 iXBRLViewerPlugin/viewer/src/js/outline.js    | 62 +++++++++-------
 .../viewer/src/js/outline.test.js             | 70 +++++++++----------
 iXBRLViewerPlugin/viewer/src/js/report.js     |  4 ++
 iXBRLViewerPlugin/viewer/src/js/reportset.js  |  6 +-
 iXBRLViewerPlugin/viewer/src/js/search.js     | 10 +--
 iXBRLViewerPlugin/viewer/src/js/summary.js    |  2 +-
 9 files changed, 121 insertions(+), 105 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/calculations.js b/iXBRLViewerPlugin/viewer/src/js/calculations.js
index 3d835a26e..31562ef61 100644
--- a/iXBRLViewerPlugin/viewer/src/js/calculations.js
+++ b/iXBRLViewerPlugin/viewer/src/js/calculations.js
@@ -24,7 +24,7 @@ export function Calculation(fact) {
 
 Calculation.prototype.calculationFacts = function () {
     var fact = this._fact;
-    var report = fact.report();
+    var report = fact.report;
     if (!this._conceptToFact) {
         var rels = report.getChildRelationships(fact.conceptName(), "calc")
         var ctf = {};
@@ -91,7 +91,7 @@ Calculation.prototype.bestELRForFactSet = function(facts) {
 Calculation.prototype.resolvedCalculation = function(elr) {
     var calc = [];
     var calcFacts = this.calculationFacts()[elr];
-    var rels = this._fact.report().getChildRelationships(this._fact.conceptName(), "calc")[elr];
+    var rels = this._fact.report.getChildRelationships(this._fact.conceptName(), "calc")[elr];
     $.each(rels, function (i, r) {
         var s;
         if (r.w == 1) {
diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.js b/iXBRLViewerPlugin/viewer/src/js/fact.js
index 2ce374b9a..19d5a7402 100644
--- a/iXBRLViewerPlugin/viewer/src/js/fact.js
+++ b/iXBRLViewerPlugin/viewer/src/js/fact.js
@@ -12,7 +12,7 @@ export class Fact {
     constructor(report, factId, factData) {
         this.f = factData;
         this.ixNode = report.reportSet.getIXNodeForItemId(factId);
-        this._report = report;
+        this.report = report;
         this.id = factId;
         this.linkedFacts = [];
         this._footnotes = [];
@@ -22,16 +22,12 @@ export class Fact {
         return this.id.replace(/^\d+-/,"");
     }
 
-    report() {
-        return this._report;
-    }
-
     getLabel(rolePrefix, withPrefix) {
-        return this._report.getLabel(this.f.a.c, rolePrefix, withPrefix);
+        return this.report.getLabel(this.f.a.c, rolePrefix, withPrefix);
     }
 
     getLabelOrName(rolePrefix, withPrefix) {
-        return this._report.getLabelOrName(this.f.a.c, rolePrefix, withPrefix);
+        return this.report.getLabelOrName(this.f.a.c, rolePrefix, withPrefix);
     }
 
     conceptName() {
@@ -39,11 +35,11 @@ export class Fact {
     }
 
     concept() {
-        return this._report.getConcept(this.f.a.c); 
+        return this.report.getConcept(this.f.a.c); 
     }
 
     conceptQName() {
-        return this._report.qname(this.f.a.c);
+        return this.report.qname(this.f.a.c);
     }
 
     period(){
@@ -105,7 +101,7 @@ export class Fact {
         else if (this.isEnumeration()) {
             const labels = [];
             for (const qn of v.split(' ')) {
-                labels.push(this._report.getLabelOrName(qn, 'std'));
+                labels.push(this.report.getLabelOrName(qn, 'std'));
             }
             v = labels.join(', ');
         }
@@ -138,7 +134,7 @@ export class Fact {
             if (!unitKey) {
                 return undefined;
             }
-            this._unit = this.report().reportSet.getUnit(unitKey);
+            this._unit = this.report.reportSet.getUnit(unitKey);
         }
         return this._unit;
     }
@@ -149,14 +145,14 @@ export class Fact {
 
     isCalculationContributor() {
         if (this._isCalculationContributor === undefined) {
-            this._isCalculationContributor = this._report.isCalculationContributor(this.f.a.c);
+            this._isCalculationContributor = this.report.isCalculationContributor(this.f.a.c);
         }
         return this._isCalculationContributor;
     }
 
     isCalculationSummation() {
         if (this._isCalculationSummation === undefined) {
-            this._isCalculationSummation = this._report.isCalculationSummation(this.f.a.c);
+            this._isCalculationSummation = this.report.isCalculationSummation(this.f.a.c);
         }
         return this._isCalculationSummation;
     }
@@ -176,11 +172,11 @@ export class Fact {
     }
 
     hasExplicitDimension() {
-        return Object.keys(this.dimensions()).some(d => !this._report.getConcept(d).isTypedDimension());
+        return Object.keys(this.dimensions()).some(d => !this.report.getConcept(d).isTypedDimension());
     }
 
     hasTypedDimension() {
-        return Object.keys(this.dimensions()).some(d => this._report.getConcept(d).isTypedDimension());
+        return Object.keys(this.dimensions()).some(d => this.report.getConcept(d).isTypedDimension());
     }
 
     isMonetaryValue() {
@@ -201,7 +197,7 @@ export class Fact {
         }
         if (this._aspects[a] === undefined) {
             if (this.f.a[a] !== undefined) {
-                this._aspects[a] = new Aspect(a, this.f.a[a], this._report);
+                this._aspects[a] = new Aspect(a, this.f.a[a], this.report);
             }
         }
         return this._aspects[a];
@@ -247,7 +243,7 @@ export class Fact {
     }
 
     duplicates() {
-        return this._report.getAlignedFacts(this);
+        return this.report.getAlignedFacts(this);
     }
 
     isNil() {
@@ -270,9 +266,9 @@ export class Fact {
     getScaleLabel(value, isAccuracy=false) {
         let measure = this.measure() ?? '';
         if (measure) {
-            measure = this.report().qname(measure).localname;
+            measure = this.report.qname(measure).localname;
         }
-        return this._report.getScaleLabel(
+        return this.report.getScaleLabel(
                 // We use the same table of labels for scale and accuracy,
                 // but decimals means "accurate to 10^-N" whereas scale means 10^N,
                 // so invert N for accuracy.
@@ -316,7 +312,7 @@ export class Fact {
     }
 
     identifier() {
-        return this._report.qname(this.f.a.e);
+        return this.report.qname(this.f.a.e);
     }
 
     escaped() {
@@ -345,7 +341,7 @@ export class Fact {
 
     widerConcepts() {
         const concepts = [];
-        const parentsByELR = this._report.getParentRelationships(this.conceptName(), "w-n");
+        const parentsByELR = this.report.getParentRelationships(this.conceptName(), "w-n");
         for (const elr in parentsByELR) {
             concepts.push(...$.map(parentsByELR[elr], (rel) => rel.src));
         }
@@ -354,7 +350,7 @@ export class Fact {
 
     narrowerConcepts() {
         const concepts = [];
-        const childrenByELR = this._report.getChildRelationships(this.conceptName(), "w-n");
+        const childrenByELR = this.report.getChildRelationships(this.conceptName(), "w-n");
         for (const elr in childrenByELR) {
             concepts.push(...$.map(childrenByELR[elr], (rel) => rel.t));
         }
@@ -367,3 +363,4 @@ export class Fact {
     }
 }
 
+
diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index c5925edae..4527f4156 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -17,7 +17,7 @@ import { Footnote } from './footnote.js';
 import { ValidationReportDialog } from './validationreport.js';
 import { TextBlockViewerDialog } from './textblockviewer.js';
 import { MessageBox } from './messagebox.js';
-import { DocumentOutline } from './outline.js';
+import { ReportSetOutline } from './outline.js';
 import { DIMENSIONS_KEY, DocumentSummary, MEMBERS_KEY, PRIMARY_ITEMS_KEY, TOTAL_KEY } from './summary.js';
 
 const SEARCH_PAGE_SIZE = 100
@@ -115,7 +115,7 @@ export class Inspector {
                 reportSet.viewerOptions = inspector._viewerOptions;
                 inspector.summary = new DocumentSummary(reportSet);
                 inspector.createSummary()
-                inspector.outline = new DocumentOutline(reportSet);
+                inspector.outline = new ReportSetOutline(reportSet);
                 inspector.createOutline();
                 inspector._iv.setProgress(i18next.t("inspector.initializing")).then(() => {
                     inspector._search = new ReportSearch(reportSet);
@@ -559,11 +559,10 @@ export class Inspector {
         if (this.outline.hasOutline()) {
             $('.outline .no-outline-overlay').hide();
             const container = $('<div class="fact-list"></div>').appendTo($('.outline .body'));
-            for (const elr of this.outline.sortedSections()) {
+            for (const group of this.outline.sortedSections()) {
                 $('<div class="fact-list-item"></div>')
-                    // XXX hard-coded to first report
-                    .text(this._reportSet.reports[0].getRoleLabel(elr))
-                    .click(() => this.selectItem(this.outline.sections[elr].id))
+                    .text(group.report.getRoleLabel(group.elr))
+                    .click(() => this.selectItem(group.fact.id))
                     .dblclick(() => $('#inspector').removeClass("outline-mode"))
                     .mousedown((e) => {
                         // Prevent text selection by double click
@@ -578,10 +577,10 @@ export class Inspector {
 
     updateOutline(cf) {
         $('.fact-groups').empty();
-        for (const elr of this.outline.groupsForFact(cf)) {
+        for (const group of this.outline.groupsForFact(cf)) {
             $('<div class="fact-list-item"></div>')
-                .text(cf.report().getRoleLabel(elr))
-                .click(() => this.selectItem(this.outline.sections[elr].id))
+                .text(cf.report.getRoleLabel(group.elr))
+                .click(() => this.selectItem(group.fact.id))
                 .appendTo($('.fact-groups'));
         }
 
@@ -609,8 +608,8 @@ export class Inspector {
         const html = $("<ul></ul>");
         if (anchors.length > 0) {
             for (const c of anchors) {
-                const otherFacts = fact.report().getAlignedFacts(fact, { "c": c });
-                const label = fact.report().getLabel(c, "std", true);
+                const otherFacts = fact.report.getAlignedFacts(fact, { "c": c });
+                const label = fact.report.getLabel(c, "std", true);
 
                 $("<li></li>")
                     .appendTo(html)
@@ -674,7 +673,7 @@ export class Inspector {
         if (!elr) {
             elr = calc.bestELRForFactSet(tableFacts);
         }
-        const report = fact.report();
+        const report = fact.report;
         const inspector = this;
         const a = new Accordian();
 
@@ -776,7 +775,7 @@ export class Inspector {
     getPeriodIncrease(fact) {
         let s = "";
         if (fact.isNumeric()) {
-            const otherFacts = fact.report().getAlignedFacts(fact, {"p":null });
+            const otherFacts = fact.report.getAlignedFacts(fact, {"p":null });
             var mostRecent;
             if (fact.periodTo()) {
                 for (const other of otherFacts) {
@@ -786,7 +785,7 @@ export class Inspector {
                 }
             }
             if (mostRecent) {
-                const allMostRecent = fact.report().getAlignedFacts(mostRecent);
+                const allMostRecent = fact.report.getAlignedFacts(mostRecent);
                 s = $("<span></span>")
                         .text(this.describeChange(mostRecent, fact))
                         .append(this.factLinkHTML(mostRecent.periodString(), allMostRecent));
diff --git a/iXBRLViewerPlugin/viewer/src/js/outline.js b/iXBRLViewerPlugin/viewer/src/js/outline.js
index eb163f79d..1f7e5fe55 100644
--- a/iXBRLViewerPlugin/viewer/src/js/outline.js
+++ b/iXBRLViewerPlugin/viewer/src/js/outline.js
@@ -2,21 +2,40 @@
 
 import $ from 'jquery'
 
+export class ReportSetOutline {
+    constructor(reportSet) {
+        this._reportSet = reportSet;
+        this.outlines = reportSet.reports.map(r => new DocumentOutline(r));
+    }
+
+    hasOutline() {
+        return this.outlines.some(o => Object.keys(o.sections).length > 0);
+    }
+
+    sortedSections() {
+        return this.outlines.flatMap(o => o.sortedSections());
+    }
+
+    groupsForFact(f) {
+        return this.outlines.find(o => o.report == f.report).groupsForFact(f);
+    }
+
+}
+
 // DocumentOutline chooses a fact for each presentation group (ELR) that
 // represents the start of that ELR.  This is done by deciding which ELRs each
 // fact participates in (see factInGroup()) and then finding the longest
 // continuous run of facts in document order that participate in each ELR.
 export class DocumentOutline {
-    constructor(reportSet) {
-        this._reportSet = reportSet;
-        const facts = reportSet.facts().sort((a, b) => a.ixNode.docOrderindex - b.ixNode.docOrderindex);
+    constructor(report) {
+        this.report = report;
+        const facts = report.facts().sort((a, b) => a.ixNode.docOrderindex - b.ixNode.docOrderindex);
         const runLength = {};
         const runStart = {};
         const longestRun = {};
         const longestRunStart = {};
         this._buildDimensionMap();
-        // XXX Hard coded to first report
-        const elrs = reportSet.reports[0].relationshipGroups("pres");
+        const elrs = report.relationshipGroups("pres");
         for (const f of facts) {
             if (f.isHidden()) {
                 continue;
@@ -59,8 +78,7 @@ export class DocumentOutline {
         // Roots are abstract so no need to check for concepts with outgoing
         // relationships only.
 
-        // XXX
-        if (this._reportSet.reports[0].getParentRelationshipsInGroup(fact.conceptName(), "pres", elr).length == 0) {
+        if (this.report.getParentRelationshipsInGroup(fact.conceptName(), "pres", elr).length == 0) {
             return false;
         }
         const fd = fact.dimensions();
@@ -100,21 +118,18 @@ export class DocumentOutline {
     //   between presentation and dimensional ELRs.
     //
     _buildDimensionMap() {
-        // XXX hard-coded to first report
-        const groups = this._reportSet.reports[0].relationshipGroups("pres");
+        const groups = this.report.relationshipGroups("pres");
         this.dimensionMap = {};
         for (const elr of groups) {
             this.dimensionMap[elr] = {};
-            // XXX
-            for (const root of this._reportSet.reports[0].relationshipGroupRoots("pres", elr)) {
+            for (const root of this.report.relationshipGroupRoots("pres", elr)) {
                 this.buildDimensionMapFromSubTree("pres", elr, null, root);
             }
         }
     }
 
     buildDimensionMapFromSubTree(arcrole, elr, dimension, conceptName) {
-        // XXX
-        const c = this._reportSet.reports[0].getConcept(conceptName);
+        const c = this.report.getConcept(conceptName);
         if (c.isTypedDimension()) {
             this.dimensionMap[elr][conceptName] = { typed: true };
             return
@@ -123,15 +138,13 @@ export class DocumentOutline {
             dimension = conceptName;
             this.dimensionMap[elr][dimension] = { members: {}, allowDefault: false};
         }
-        // XXX
-        var children = this._reportSet.reports[0].getChildRelationships(conceptName, arcrole);
+        var children = this.report.getChildRelationships(conceptName, arcrole);
         if (!(elr in children)) {
             return
         }
         for (var rel of children[elr]) {
             if (dimension) {
-                // XXX
-                if (this._reportSet.reports[0].dimensionDefault(dimension) == rel.t) {
+                if (this.report.dimensionDefault(dimension) == rel.t) {
                     this.dimensionMap[elr][dimension].allowDefault = true;
                 }
                 else {
@@ -144,11 +157,10 @@ export class DocumentOutline {
 
     // Returns a list of presentation groups that this fact participates in
     groupsForFact(fact) {
-        var factGroups = [];
-        // XXX
-        for (const group of this._reportSet.reports[0].relationshipGroups("pres")) {
+        const factGroups = [];
+        for (const group of this.report.relationshipGroups("pres")) {
             if (this.factInGroup(fact, group)) {
-                factGroups.push(group);
+                factGroups.push({ elr: group, fact: this.sections[group], report: this.report});
             }
         }
         return factGroups;
@@ -161,9 +173,9 @@ export class DocumentOutline {
     sortedSections() {
         const sections = Object.keys(this.sections);
         const re = /\(parenthetical\)\s*$/i;
-        // XXX
-        const filteredSections = sections.filter(s => !re.test(this._reportSet.reports[0].getRoleLabel(s)));
-        // XXX
-        return filteredSections.sort((a, b) => this._reportSet.reports[0].getRoleLabel(a).localeCompare(this._reportSet.reports[0].getRoleLabel(b)));
+        const filteredSections = sections.filter(s => !re.test(this.report.getRoleLabel(s)));
+        return filteredSections
+            .sort((a, b) => this.report.getRoleLabel(a).localeCompare(this.report.getRoleLabel(b)))
+            .map(elr => ({ report: this.report, fact: this.sections[elr], elr: elr }));
     }
 }
diff --git a/iXBRLViewerPlugin/viewer/src/js/outline.test.js b/iXBRLViewerPlugin/viewer/src/js/outline.test.js
index 2ebd6266b..1b80dafc8 100644
--- a/iXBRLViewerPlugin/viewer/src/js/outline.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/outline.test.js
@@ -2,7 +2,7 @@
 
 import $ from 'jquery'
 import { ReportSet } from "./reportset.js";
-import { DocumentOutline } from "./outline.js";
+import { ReportSetOutline, DocumentOutline } from "./outline.js";
 import { IXNode } from "./ixnode.js";
 import { viewerUniqueId } from "./util.js";
 
@@ -189,7 +189,7 @@ describe("Section filtering", () => {
     // f1 has a line item from elr1, f2 has a line item from elr3
     test("Both groups", () => {
         const reportSet = testReportSet(["f1", "f2"]);
-        const outline = new DocumentOutline(reportSet);
+        const outline = new DocumentOutline(reportSet.reports[0]);
         expect(outline.factInGroup(getFact(reportSet, "f1"), "elr1")).toBe(true);
         expect(outline.factInGroup(getFact(reportSet, "f1"), "elr2")).toBe(false);
         expect(outline.factInGroup(getFact(reportSet, "f1"), "elr3")).toBe(false);
@@ -198,26 +198,26 @@ describe("Section filtering", () => {
         expect(outline.factInGroup(getFact(reportSet, "f2"), "elr2")).toBe(false);
         expect(outline.factInGroup(getFact(reportSet, "f2"), "elr3")).toBe(true);
 
-        expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr3"]);
     });
 
     test("First group", () => {
         const reportSet = testReportSet(["f1"]);
-        const outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1"]);
+        const outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1"]);
     });
 
     test("Last group", () => {
         const reportSet = testReportSet(["f2"]);
-        const outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr3"]);
+        const outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr3"]);
     });
 });
 
 describe("Dimensional filtering", () => {
     test("Simple", () => {
         const reportSet = testReportSet(["f3"]);
-        let outline = new DocumentOutline(reportSet);
+        let outline = new DocumentOutline(reportSet.reports[0]);
         // ELR1 does not mention Dimension 1, so f3 is included.
         const f3 = getFact(reportSet, "f3");
         expect(outline.factInGroup(f3, "elr1")).toBe(true);
@@ -227,9 +227,9 @@ describe("Dimensional filtering", () => {
         // Missing required TypedDimensions1
         expect(outline.factInGroup(f3, "elr4")).toBe(false);
 
-        expect(outline.sortedSections()).toEqual(["elr1", "elr2"]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr2"]);
 
-        expect(outline.groupsForFact(f3)).toEqual(["elr1", "elr2"]);
+        expect(outline.groupsForFact(f3).map(g => g.elr)).toEqual(["elr1", "elr2"]);
 
         // Exclude Member1 from Dimension1 in ELR2
         reportSet.reports[0]._reportData.rels.pres.elr2['eg:Dimension1'] = [
@@ -237,7 +237,7 @@ describe("Dimensional filtering", () => {
         ];
         reportSet.reports[0]._reverseRelationshipCache = {}; 
 
-        outline = new DocumentOutline(reportSet);
+        outline = new DocumentOutline(reportSet.reports[0]);
 
         // ELR1 does not mention Dimension 1, so f3 is included.
         expect(outline.factInGroup(f3, "elr1")).toBe(true);
@@ -247,14 +247,14 @@ describe("Dimensional filtering", () => {
         // Missing required TypedDimensions1
         expect(outline.factInGroup(f3, "elr4")).toBe(false);
 
-        expect(outline.sortedSections()).toEqual(["elr1"]);
-        expect(outline.groupsForFact(f3)).toEqual(["elr1"]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1"]);
+        expect(outline.groupsForFact(f3).map(g => g.elr)).toEqual(["elr1"]);
 
     });
 
     test("Typed Dimensions", () => {
         const reportSet = testReportSet(["ft"]);
-        const outline = new DocumentOutline(reportSet);
+        const outline = new DocumentOutline(reportSet.reports[0]);
         const ft = getFact(reportSet, "ft");
         expect(outline.factInGroup(ft, "elr1")).toBe(true);
         // Missing required Dimension1
@@ -270,7 +270,7 @@ describe("Dimensional filtering", () => {
         const report = reportSet.reports[0];
         report._reportData.rels["d-d"] = { elr1: { 'eg:Dimension1': [ { t: 'eg:Member1' } ] } };
 
-        const outline = new DocumentOutline(reportSet);
+        const outline = new DocumentOutline(reportSet.reports[0]);
         const f1 = getFact(reportSet, "f1");
         expect(outline.factInGroup(f1, "elr1")).toBe(true);
         // f1 is now included in elr2 because the default member is in ELR2
@@ -299,8 +299,8 @@ describe("Section grouping", () => {
     test("Single group", () => {
         // All facts in a single group
         const reportSet = testReportSet(["f1", "f1a"]);
-        const outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1"]);
+        const outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1"]);
         expect(outline.sections["elr1"].localId()).toEqual("f1");
         expect(outline.sections["elr3"]).toBeUndefined();
     });
@@ -309,8 +309,8 @@ describe("Section grouping", () => {
         // ELR1 is the f1, f1a run
         // ELR3 is the f2a, f2b run
         const reportSet = testReportSet(["f1", "f1a", "f2", "f1b", "f2a", "f2b"]);
-        const outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
+        const outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr3"]);
         expect(outline.sections["elr1"].localId()).toEqual("f1");
         expect(outline.sections["elr3"].localId()).toEqual("f2a");
     });
@@ -319,8 +319,8 @@ describe("Section grouping", () => {
         // ELR1 is the f1a, f1b run
         // ELR3 is the f2, f2b run
         const reportSet = testReportSet(["f1", "f2", "f2b", "f1a", "f1b", "f2a"]);
-        const outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
+        const outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr3"]);
         expect(outline.sections["elr1"].localId()).toEqual("f1a");
         expect(outline.sections["elr3"].localId()).toEqual("f2");
     });
@@ -329,8 +329,8 @@ describe("Section grouping", () => {
         // If multiple runs have the same length, we arbitrarily assign the ELR
         // to the first.
         const reportSet = testReportSet(["f1", "f1a", "f2", "f1b", "f1c", "f2b" ]);
-        const outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
+        const outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr3"]);
         expect(outline.sections["elr1"].localId()).toEqual("f1");
         expect(outline.sections["elr3"].localId()).toEqual("f2");
     });
@@ -338,30 +338,30 @@ describe("Section grouping", () => {
     test("Hidden facts", () => {
         // Start with ELR1*2 ELR3*1 ELR1*3
         const reportSet = testReportSet(["f1a", "f1", "f2", "f1b", "f1c", "f1d"]);
-        let outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
+        let outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr3"]);
         expect(outline.sections["elr1"].localId()).toEqual("f1b");
         expect(outline.sections["elr3"].localId()).toEqual("f2");
 
         // Make f1c hidden.  We now have ELR1*2 ELR3*1 ELR1*2
         // The first ELR1 run should be selected.
         getFact(reportSet, "f1c").ixNode.isHidden = true;
-        outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
+        outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr3"]);
         expect(outline.sections["elr1"].localId()).toEqual("f1a");
         expect(outline.sections["elr3"].localId()).toEqual("f2");
 
         // Make f1a hidden.  f1b-[f1c]-f1d is now the longest run.
         getFact(reportSet, "f1a").ixNode.isHidden = true;
-        outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
+        outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr3"]);
         expect(outline.sections["elr1"].localId()).toEqual("f1b");
         expect(outline.sections["elr3"].localId()).toEqual("f2");
 
         // Hide f2.  We now have a single run for ELR1
         getFact(reportSet, "f2").ixNode.isHidden = true;
-        outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1"]);
+        outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1"]);
         expect(outline.sections["elr1"].localId()).toEqual("f1");
 
     });
@@ -371,13 +371,13 @@ describe("No presentation", () => {
     // f1 has a line item from elr1, f2 has a line item from elr3
     test("Remove presentation relationships", () => {
         const reportSet = testReportSet(["f1", "f2"]);
-        let outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual(["elr1", "elr3"]);
+        let outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual(["elr1", "elr3"]);
         expect(outline.hasOutline()).toEqual(true);
 
         delete reportSet.reports[0]._reportData.rels.pres;
-        outline = new DocumentOutline(reportSet);
-        expect(outline.sortedSections()).toEqual([]);
+        outline = new DocumentOutline(reportSet.reports[0]);
+        expect(outline.sortedSections().map(g => g.elr)).toEqual([]);
         expect(outline.hasOutline()).toEqual(false);
     });
 });
diff --git a/iXBRLViewerPlugin/viewer/src/js/report.js b/iXBRLViewerPlugin/viewer/src/js/report.js
index d10a793b7..85ed23c5d 100644
--- a/iXBRLViewerPlugin/viewer/src/js/report.js
+++ b/iXBRLViewerPlugin/viewer/src/js/report.js
@@ -32,6 +32,10 @@ XBRLReport.prototype.availableLanguages = function() {
     return this._availableLanguages;
 }
 
+XBRLReport.prototype.facts = function() {
+    return this.reportSet.factsForReport(this);
+}
+
 XBRLReport.prototype.getChildRelationships = function(conceptName, arcrole) {
     var rels = {}
     const elrs = this._reportData.rels[arcrole] || {};
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index 27aa36626..40336a20b 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -59,7 +59,7 @@ export class ReportSet {
                     const fnvuid = viewerUniqueId(reportIndex, fnid);
                     var fn = this._items[fnvuid];
                     if (fn === undefined) {
-                        fn = new Footnote(fact.report(), fnvuid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
+                        fn = new Footnote(fact.report, fnvuid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
                         this._items[fnvuid] = fn;
                     }
                     // Associate fact with footnote
@@ -206,5 +206,9 @@ export class ReportSet {
     validation() {
         return this._data.validation;
     }
+
+    factsForReport(report) {
+        return Object.values(this._items).filter(i => i instanceof Fact && i.report == report);
+    }
     
 }
diff --git a/iXBRLViewerPlugin/viewer/src/js/search.js b/iXBRLViewerPlugin/viewer/src/js/search.js
index 481b33b24..f320a436c 100644
--- a/iXBRLViewerPlugin/viewer/src/js/search.js
+++ b/iXBRLViewerPlugin/viewer/src/js/search.js
@@ -25,22 +25,22 @@ export class ReportSearch {
             doc.startDate = f.periodFrom();
             var dims = f.dimensions();
             for (var d in dims) {
-                if (f.report().getConcept(d).isTypedDimension()) {
+                if (f.report.getConcept(d).isTypedDimension()) {
                     if (dims[d] !== null) {
                         l += " " + dims[d];
                     }
                 }
                 else {
-                    l += " " + f.report().getLabel(dims[d], "std");
+                    l += " " + f.report.getLabel(dims[d], "std");
                 }
             }
             doc.label = l;
             doc.ref = f.concept().referenceValuesAsString();
             const wider = f.widerConcepts();
             if (wider.length > 0) {
-                doc.widerConcept = f.report().qname(wider[0]).localname;
-                doc.widerLabel = f.report().getLabel(wider[0], "std");
-                doc.widerDoc = f.report().getLabel(wider[0], "doc");
+                doc.widerConcept = f.report.qname(wider[0]).localname;
+                doc.widerLabel = f.report.getLabel(wider[0], "std");
+                doc.widerDoc = f.report.getLabel(wider[0], "doc");
             }
             docs.push(doc);
 
diff --git a/iXBRLViewerPlugin/viewer/src/js/summary.js b/iXBRLViewerPlugin/viewer/src/js/summary.js
index 99ab5be17..21dddfead 100644
--- a/iXBRLViewerPlugin/viewer/src/js/summary.js
+++ b/iXBRLViewerPlugin/viewer/src/js/summary.js
@@ -93,7 +93,7 @@ export class DocumentSummary {
                 counter = this._getTagCounter(tagCounts, dimension);
                 counter.addDimension(dimension);
 
-                const dimensionConcept = fact.report().getConcept(dimension);
+                const dimensionConcept = fact.report.getConcept(dimension);
                 if (dimensionConcept.isTypedDimension()) {
                     const typedDomainElement = dimensionConcept.typedDomainElement();
                     if (typedDomainElement) {

From ce498777f39f13ed33806a76ece0222bcc809399 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Wed, 27 Sep 2023 20:49:01 +0100
Subject: [PATCH 12/32] Fix python tests.

---
 iXBRLViewerPlugin/iXBRLViewer.py              | 13 +++---
 .../iXBRLViewerPlugin/test_iXBRLViewer.py     | 43 +++++++++++--------
 2 files changed, 33 insertions(+), 23 deletions(-)

diff --git a/iXBRLViewerPlugin/iXBRLViewer.py b/iXBRLViewerPlugin/iXBRLViewer.py
index dc4c7a1e8..cd6ee44c1 100644
--- a/iXBRLViewerPlugin/iXBRLViewer.py
+++ b/iXBRLViewerPlugin/iXBRLViewer.py
@@ -230,7 +230,7 @@ def getRelationships(self, report: ModelXbrl):
         return rels
 
     def validationErrors(self):
-        dts = self.dts
+        dts = self.reports[0]
 
         logHandler = dts.modelManager.cntlr.logHandler
         if getattr(logHandler, "logRecordBuffer") is None:
@@ -378,6 +378,12 @@ def getStubDocument(self):
         with open(os.path.join(os.path.dirname(__file__),"stubviewer.html")) as fin:
             return etree.parse(fin)
 
+    def addReport(self):
+        self.taxonomyData["reports"].append({
+            "concepts": {},
+            "facts": {},
+        })
+
     def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool = False, showValidations: bool = True, packageDownloadURL: str = None) -> Optional[iXBRLViewer]:
         """
         Create an iXBRL file with XBRL data as a JSON blob, and script tags added.
@@ -402,10 +408,7 @@ def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool
 
         for n, report in enumerate(self.reports):
             self.footnoteRelationshipSet = ModelRelationshipSet(report, "XBRL-footnotes")
-            self.taxonomyData["reports"].append({
-                "concepts": {},
-                "facts": {},
-            })
+            self.addReport()
             for f in report.facts:
                 self.addFact(report, f)
             self.currentReportData["rels"] = self.getRelationships(report)
diff --git a/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py b/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
index bd0ec971a..bf660527d 100644
--- a/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
+++ b/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
@@ -425,29 +425,33 @@ def urlDocEntry(path, docType, linkQName=None):
         typed_dimension_concept.modelXbrl = self.modelXbrl_1
         typed_dimension_domain_concept.modelXbrl = self.modelXbrl_1
         member_concept.modelXbrl = self.modelXbrl_1
-        self.builder_1 = IXBRLViewerBuilder(self.modelXbrl_1)
-        self.builder_2 = IXBRLViewerBuilder(self.modelXbrl_1)
-        self.builder_3 = IXBRLViewerBuilder(self.modelXbrl_2)
-        self.builder_doc_set = IXBRLViewerBuilder(self.modelXbrlDocSet)
+
+
+        self.builder_1 = IXBRLViewerBuilder([self.modelXbrl_1])
+        self.builder_2 = IXBRLViewerBuilder([self.modelXbrl_1])
+        self.builder_3 = IXBRLViewerBuilder([self.modelXbrl_2])
+        self.builder_doc_set = IXBRLViewerBuilder([self.modelXbrlDocSet])
 
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
     def test_addConcept_simple_case(self):
-        self.builder_1.addConcept(self.cash_concept)
-        self.assertTrue(self.builder_1.taxonomyData.get('concepts').get('us-gaap:Cash'))
+        self.builder_1.addReport()
+        self.builder_1.addConcept(self.modelXbrl_1, self.cash_concept)
+        self.assertTrue(self.builder_1.taxonomyData["reports"][0].get('concepts').get('us-gaap:Cash'))
 
     @patch('arelle.XbrlConst.parentChild', 'http://www.xbrl.org/2003/arcrole/parent-child')
     @patch('arelle.XbrlConst.summationItem', 'http://www.xbrl.org/2003/arcrole/summation-item')
     def test_getRelationships_simple_case(self):
         modelXbrl = Mock(baseSets=defaultdict(list), relationshipSets={})
         builder = IXBRLViewerBuilder(modelXbrl)
-        result = builder.getRelationships()
+        result = builder.getRelationships(modelXbrl)
         self.assertDictEqual(result, {})
 
     @patch('arelle.XbrlConst.parentChild', 'http://www.xbrl.org/2003/arcrole/parent-child')
     @patch('arelle.XbrlConst.summationItem', 'http://www.xbrl.org/2003/arcrole/summation-item')
     def test_getRelationships_returns_a_rel(self):
-        result = self.builder_1.getRelationships()
+        self.builder_1.addReport()
+        result = self.builder_1.getRelationships(self.modelXbrl_1)
         roleMap = self.builder_1.roleMap
         siPrefix = roleMap.getPrefix('http://www.xbrl.org/2003/arcrole/summation-item')
         self.assertTrue(result.get(siPrefix).get(roleMap.getPrefix('ELR')).get('us-gaap:from_concept'))
@@ -457,18 +461,20 @@ def test_addELR_no_definition(self):
         Adding an ELR with no definition should result in no entry in the roleDefs map
         """
         elr = "http://example.com/unknownELR"
-        self.builder_1.addELR(elr)
+        self.builder_1.addReport()
+        self.builder_1.addELR(self.modelXbrl_1, elr)
         elrPrefix = self.builder_1.roleMap.getPrefix(elr)
-        self.assertEqual(self.builder_1.taxonomyData.get('roleDefs').get(elrPrefix), None)
+        self.assertEqual(self.builder_1.currentReportData.get('roleDefs').get(elrPrefix), None)
 
     def test_addELR_with_definition(self):
         """
         Adding an ELR with a definition should result in an "en" label with the definition as its value.
         """
         elr = "ELR"
-        self.builder_1.addELR(elr)
+        self.builder_1.addReport()
+        self.builder_1.addELR(self.modelXbrl_1, elr)
         elrPrefix = self.builder_1.roleMap.getPrefix(elr)
-        self.assertEqual(self.builder_1.taxonomyData.get('roleDefs').get(elrPrefix).get("en"), "ELR Label")
+        self.assertEqual(self.builder_1.currentReportData.get('roleDefs').get(elrPrefix).get("en"), "ELR Label")
 
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
@@ -491,7 +497,7 @@ def test_createViewerWithValidation(self):
         jsdata = json.loads(body[2].text)
         errors = jsdata["validation"]
         self.assertEqual(errors, [{"sev": "ERROR", "msg": "Error message", "code": "code1" }])
-        self.assertEqual(set(jsdata["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
+        self.assertEqual(set(jsdata["reports"][0]["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
 
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
@@ -513,8 +519,9 @@ def test_createViewer(self):
 
         jsdata = json.loads(body[2].text)
         self.assertNotIn("validation", jsdata)
-        self.assertEqual(set(jsdata["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
-        self.assertEqual(jsdata["concepts"], {
+        print(jsdata["reports"])
+        self.assertEqual(set(jsdata["reports"][0]["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
+        self.assertEqual(jsdata["reports"][0]["concepts"], {
             'us-gaap:Cash': {'e': True, 't': True, 'labels': {}},
             'us-gaap:from_concept': {'e': True, 't': True, 'labels': {}},
             'us-gaap:to_concept': {'e': True, 't': True, 'labels': {}},
@@ -523,7 +530,7 @@ def test_createViewer(self):
             'us-gaap:typed_dimension_domain': {'e': True, 't': True, 'labels': {}},
             'us-gaap:typed_dimension': {'d': 't', 'e': True, 't': True, 'labels': {}, 'td': 'us-gaap:typed_dimension_domain'},
         })
-        self.assertEqual(jsdata["localDocs"], {
+        self.assertEqual(jsdata["reports"][0]["localDocs"], {
             'local-inline.htm': ['inline'],
             'local-docset': ['inline'],
             'local-schema.xsd': ['schema'],
@@ -555,7 +562,7 @@ def test_createViewer_docset(self):
 
         jsdata = json.loads(body[2].text)
         self.assertNotIn("validation", jsdata)
-        self.assertEqual(set(jsdata["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
+        self.assertEqual(set(jsdata["reports"][0]["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
 
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
@@ -580,7 +587,7 @@ def test_createViewer_bad_path(self):
         self.assertEqual(body[3].text, 'END IXBRL VIEWER EXTENSIONS')
 
         jsdata = json.loads(body[2].text)
-        facts = jsdata["facts"]
+        facts = jsdata["reports"][0]["facts"]
         self.assertEqual(facts.keys(), {"fact_id2", "fact_id3"})
         self.assertEqual(facts["fact_id2"]["a"]["u"], "iso4217:USD")
         self.assertEqual(facts["fact_id3"]["a"]["u"], None)

From c11997259eacce4ec241fffee6e784310f01bc0d Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Sun, 1 Oct 2023 22:37:07 +0100
Subject: [PATCH 13/32] Support for multi-report fact deep links.

---
 iXBRLViewerPlugin/viewer/src/js/inspector.js  | 18 ++++++--
 .../viewer/src/js/inspector.test.js           | 41 +++++++++++++++++++
 2 files changed, 55 insertions(+), 4 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index 4527f4156..cdcda2034 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -1,7 +1,7 @@
 // See COPYRIGHT.md for copyright information
 
 import $ from 'jquery'
-import { formatNumber, wrapLabel, truncateLabel, runGenerator } from "./util.js";
+import { formatNumber, wrapLabel, truncateLabel, runGenerator, viewerUniqueId } from "./util.js";
 import { ReportSearch } from "./search.js";
 import { Calculation } from "./calculations.js";
 import { IXBRLChart } from './chart.js';
@@ -145,10 +145,20 @@ export class Inspector {
     /*
      * Check for fragment identifier pointing to a specific fact and select it if
      * present.
+     *
+     * Legacy format: #f-FACT_ID
+     * New format: #fN-FACT_ID where N is report index
+     *
      */
     handleFactDeepLink() {
-        if (location.hash.startsWith("#f-")) {
-            this.selectItem(location.hash.slice(3));
+        const match = location.hash.match(/^#f(-|([0-9]+)-)(.*)$/);
+        if (match !== undefined) {
+            const reportId = match[1] === "-" ? 0 : match[2];
+            const id = viewerUniqueId(reportId, match[3]);
+            console.log(id);
+            if (this._reportSet.getItemById(id) !== undefined) {
+                this.selectItem(id);
+            }
         }
     }
 
@@ -174,7 +184,7 @@ export class Inspector {
 
     updateURLFragment() {
         if (this._currentItem) {
-            location.hash = "#f-" + this._currentItem.id;
+            location.hash = "#f" + this._currentItem.id;
         }
         else {
             location.hash = "";
diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.test.js b/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
index 1ed893aca..1e3fac0cb 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.test.js
@@ -211,3 +211,44 @@ describe("Scales filter options", () => {
         });
     })
 });
+
+describe("Fact deep link", () => {
+    const insp = new TestInspector();
+    insp._reportSet = {
+        getItemById: jest.fn(id => ["0-123", "1-abc"].includes(id) ? true : undefined),
+    };
+    const mockSelect = jest.fn(id => true);
+    insp.selectItem = mockSelect;
+    test("Old style fact deep link", () => {
+        mockSelect.mockClear();
+        location.hash = "#f-123";
+        insp.handleFactDeepLink();
+        expect(mockSelect).toHaveBeenCalledWith("0-123");
+    })
+    test("Old style fact deep link (non-existent)", () => {
+        mockSelect.mockClear();
+        location.hash = "#f-1234";
+        insp.handleFactDeepLink();
+        expect(mockSelect).not.toHaveBeenCalled();
+    })
+    test("New style fact deep link", () => {
+        mockSelect.mockClear();
+        location.hash = "#f0-123";
+        insp.handleFactDeepLink();
+        expect(mockSelect).toHaveBeenCalledWith("0-123");
+    })
+    test("New style fact deep link", () => {
+        mockSelect.mockClear();
+        location.hash = "#f1-abc";
+        insp.handleFactDeepLink();
+        expect(mockSelect).toHaveBeenCalledWith("1-abc");
+    })
+    test("New style fact deep link (non-existent)", () => {
+        mockSelect.mockClear();
+        location.hash = "#f0-1234";
+        insp.handleFactDeepLink();
+        expect(mockSelect).not.toHaveBeenCalled();
+    })
+
+
+});

From 8e19c562b8f96b053a333e8ca9bfd5838bb42df7 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Sun, 1 Oct 2023 22:38:08 +0100
Subject: [PATCH 14/32] Report set test.

---
 iXBRLViewerPlugin/viewer/src/js/reportset.js  |   2 -
 .../viewer/src/js/reportset.test.js           | 286 ++++++++++++++++++
 .../viewer/src/js/search.test.js              |  23 +-
 .../viewer/src/js/summary.test.js             |   2 +-
 iXBRLViewerPlugin/viewer/src/js/test-utils.js |  27 ++
 5 files changed, 315 insertions(+), 25 deletions(-)
 create mode 100644 iXBRLViewerPlugin/viewer/src/js/reportset.test.js

diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index 40336a20b..6ca910dc4 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -70,8 +70,6 @@ export class ReportSet {
         }
     }
 
-
-
     availableLanguages() {
         return Array.from(this.reports.reduce(
             (langs, report) => new Set([...langs, ...report.availableLanguages()]), 
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.test.js b/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
new file mode 100644
index 000000000..64413afa8
--- /dev/null
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
@@ -0,0 +1,286 @@
+// See COPYRIGHT.md for copyright information
+
+import { ReportSet } from "./reportset.js";
+import { ViewerOptions } from "./viewerOptions.js";
+import { viewerUniqueId } from "./util.js";
+import { createNumericFact } from "./test-utils.js";
+
+const multiReportTestData = {
+    "features": [],
+    "languages": {
+        "en-us": "English (US)",
+        "en": "English",
+        "fr": "French",
+    },
+    "prefixes": {
+        "eg": "http://www.example.com",
+        "iso4217": "http://www.xbrl.org/2003/iso4217"
+    },
+    "roles": {
+        "role1": "https://www.example.com/role1",
+        "role2": "https://www.example.com/role2",
+        "role3": "https://www.example.com/role3",
+        "role4": "https://www.example.com/role4"
+    },
+    "reports": [
+        {
+            "roleDefs": {
+                "role1": { "en": "Role 1 Label" },
+                "role2": { "en": null },
+                "role3": {}
+            },
+            "concepts": {
+                "eg:Concept1": {
+                    "labels": {
+                        "std": {
+                            "en": "English label"
+                        }
+                    }
+                },
+                "eg:Concept2": {
+                    "labels": {
+                        "std": {
+                            "en": "English label for concept two",
+                            "en-us": "English (US) label for concept two",
+                        }
+                    }
+                },
+                "eg:Concept3": {
+                    "labels": {
+                        "std": {
+                            "en": "Concept three"
+                        }
+                    }
+                }
+            },
+
+            "facts": {
+                ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+                ...createNumericFact("f2", "eg:Concept2", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+            }
+        },
+        {
+            "roleDefs": {
+            },
+            "concepts": {
+                "eg:Concept1": {
+                    "labels": {
+                        "std": {
+                            "en": "English label"
+                        }
+                    }
+                },
+                "eg:Concept2": {
+                    "labels": {
+                        "std": {
+                            "en": "Report 2 English label for concept two",
+                        }
+                    }
+                },
+                "eg:Concept3": {
+                    "labels": {
+                        "std": {
+                            "en-gb": "Concept three"
+                        }
+                    }
+                }
+            },
+
+            "facts": {
+                ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 2000, -3),
+            }
+        }
+    ]
+};
+
+// Legacy report data format - no "reports" array
+const singleReportTestData = {
+    "features": [],
+    "languages": {
+        "en-us": "English (US)",
+        "en": "English",
+        "fr": "French",
+    },
+    "prefixes": {
+        "eg": "http://www.example.com",
+        "iso4217": "http://www.xbrl.org/2003/iso4217"
+    },
+    "roles": {
+        "role1": "https://www.example.com/role1",
+        "role2": "https://www.example.com/role2",
+        "role3": "https://www.example.com/role3",
+        "role4": "https://www.example.com/role4"
+    },
+    "roleDefs": {
+        "role1": { "en": "Role 1 Label" },
+        "role2": { "en": null },
+        "role3": {}
+    },
+    "concepts": {
+        "eg:Concept1": {
+            "labels": {
+                "std": {
+                    "en": "English label"
+                }
+            }
+        },
+        "eg:Concept2": {
+            "labels": {
+                "std": {
+                    "en": "English label for concept two",
+                    "en-us": "English (US) label for concept two",
+                }
+            }
+        },
+    },
+
+    "facts": {
+        ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+        ...createNumericFact("f2", "eg:Concept2", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+    }
+};
+
+describe("Multi report - basic", () => {
+    const testReportSet = new ReportSet(multiReportTestData);
+    testReportSet._initialize();
+    test("Report count", () => {
+        expect(testReportSet.reports).toHaveLength(2);
+    });
+});
+
+describe("Multi report - Language options", () => {
+    const testReportSet = new ReportSet(multiReportTestData);
+    testReportSet._initialize();
+    test("Available languages", () => {
+        const al = testReportSet.availableLanguages();
+        expect(al).toHaveLength(3);
+        expect(al).toEqual(expect.arrayContaining(["en", "en-us", "en-gb"]));
+    });
+
+    test("Names for languages", () => {
+        const ln = testReportSet.languageNames();
+        expect(Object.keys(ln)).toHaveLength(3);
+        expect(ln['en']).toBe("English");
+        expect(ln['en-us']).toBe("English (US)");
+        expect(ln['fr']).toBe("French");
+    });
+});
+
+describe("Multi report - Fetching facts", () => {
+    const testReportSet = new ReportSet(multiReportTestData);
+    testReportSet._initialize();
+
+    test("Successful f1 (report 1)", () => {
+        const f = testReportSet.getItemById(viewerUniqueId(0, "f1"));
+        expect(f).not.toBeNull();
+        expect(f.decimals()).toEqual(-3);
+    });
+    test("Successful f2 (report 1)", () => {
+        const f = testReportSet.getItemById(viewerUniqueId(0, "f2"));
+        expect(f).not.toBeNull();
+        expect(f.decimals()).toEqual(-3);
+    });
+    test("Successful f1 (report 2)", () => {
+        const f = testReportSet.getItemById(viewerUniqueId(1, "f1"));
+        expect(f).not.toBeNull();
+        expect(f.decimals()).toEqual(-3);
+    });
+
+    test("Non-existent fact", () => {
+        const f = testReportSet.getItemById(viewerUniqueId(1, "f2"));
+        expect(f).toBeUndefined();
+    });
+});
+
+describe("Multi report - Concept labels", () => {
+    const testReportSet = new ReportSet(multiReportTestData);
+    testReportSet._initialize();
+    const testReport = testReportSet.reports[0];
+    const vo = new ViewerOptions();
+    testReportSet.viewerOptions = vo;
+    test("Label fallback", () => {
+        vo.language = 'en-us';
+        expect(testReportSet.reports[0].getLabel('eg:Concept2', 'std')).toBe("English (US) label for concept two");
+        // No en-US label in report 2, so fall back on en label
+        expect(testReportSet.reports[1].getLabel('eg:Concept2', 'std')).toBe("Report 2 English label for concept two");
+    });
+});
+
+describe("Multi report - ELR labels", () => {
+    const testReportSet = new ReportSet(multiReportTestData);
+    testReportSet._initialize();
+
+    test("Present", () => {
+        // Role 1 only has a label in report 1
+        expect(testReportSet.reports[0].getRoleLabel("role1")).toBe("Role 1 Label");
+        expect(testReportSet.reports[1].getRoleLabel("role1")).toBe("https://www.example.com/role1");
+    });
+});
+
+describe("Single report - basic", () => {
+    const testReportSet = new ReportSet(singleReportTestData);
+    testReportSet._initialize();
+    test("Report count", () => {
+        expect(testReportSet.reports).toHaveLength(1);
+    });
+});
+
+describe("Single report - Language options", () => {
+    const testReportSet = new ReportSet(singleReportTestData);
+    testReportSet._initialize();
+    test("Available languages", () => {
+        const al = testReportSet.availableLanguages();
+        expect(al).toHaveLength(2);
+        expect(al).toEqual(expect.arrayContaining(["en", "en-us"]));
+    });
+
+    test("Names for languages", () => {
+        const ln = testReportSet.languageNames();
+        expect(Object.keys(ln)).toHaveLength(3);
+        expect(ln['en']).toBe("English");
+        expect(ln['en-us']).toBe("English (US)");
+        expect(ln['fr']).toBe("French");
+    });
+});
+
+describe("Single report - Fetching facts", () => {
+    const testReportSet = new ReportSet(singleReportTestData);
+    testReportSet._initialize();
+
+    test("Successful f1", () => {
+        const f = testReportSet.getItemById(viewerUniqueId(0, "f1"));
+        expect(f).not.toBeNull();
+        expect(f.decimals()).toEqual(-3);
+    });
+    test("Successful f2", () => {
+        const f = testReportSet.getItemById(viewerUniqueId(0, "f2"));
+        expect(f).not.toBeNull();
+        expect(f.decimals()).toEqual(-3);
+    });
+    // There is no second report
+    test("Successful f1 (report 2)", () => {
+        const f = testReportSet.getItemById(viewerUniqueId(1, "f1"));
+        expect(f).toBeUndefined();
+    });
+});
+
+describe("Single report - Concept labels", () => {
+    const testReportSet = new ReportSet(singleReportTestData);
+    testReportSet._initialize();
+    const testReport = testReportSet.reports[0];
+    const vo = new ViewerOptions();
+    testReportSet.viewerOptions = vo;
+    test("Label fallback", () => {
+        vo.language = 'en-us';
+        expect(testReportSet.reports[0].getLabel('eg:Concept2', 'std')).toBe("English (US) label for concept two");
+    });
+});
+
+describe("ELR labels", () => {
+    const testReportSet = new ReportSet(singleReportTestData);
+    testReportSet._initialize();
+
+    test("Present", () => {
+        expect(testReportSet.reports[0].getRoleLabel("role1")).toBe("Role 1 Label");
+    });
+});
diff --git a/iXBRLViewerPlugin/viewer/src/js/search.test.js b/iXBRLViewerPlugin/viewer/src/js/search.test.js
index 8e11bfff4..34c56e791 100644
--- a/iXBRLViewerPlugin/viewer/src/js/search.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/search.test.js
@@ -3,6 +3,7 @@
 import { ReportSearch } from "./search.js"
 import { ReportSet } from "./reportset.js";
 import { viewerUniqueId } from "./util.js";
+import { createSimpleFact, createNumericFact } from './test-utils.js';
 
 const testReportData = {
     "concepts": {},
@@ -50,28 +51,6 @@ function createDimensionalizedFact(id, concept, options=null, dimensions= {}) {
     return fact;
 }
 
-function createSimpleFact(id, concept, options=null) {
-    options = options || {};
-    return {
-        [id]: {
-            "a": {
-                "c": concept,
-                "u": options["unit"],
-                "p": options["period"],
-            },
-            "d": options["decimals"],
-            "v": options["value"]
-        }
-    };
-}
-
-function createNumericFact(id, concept, unit, period, value) {
-    return createSimpleFact(id, concept, {
-        "unit": unit,
-        "period": period,
-        "value": value
-    });
-}
 
 function testReport(ixData, testData) {
     // Deep copy of standing data
diff --git a/iXBRLViewerPlugin/viewer/src/js/summary.test.js b/iXBRLViewerPlugin/viewer/src/js/summary.test.js
index d31cbc450..d9c1bf4c6 100644
--- a/iXBRLViewerPlugin/viewer/src/js/summary.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/summary.test.js
@@ -23,7 +23,7 @@ function testReportSet(concepts, facts, documents) {
         localDocuments: () => documents
     }
     for (const f of facts) {
-        f.report = () => report;
+        f.report = report;
     }
     return {
         facts: () => facts,
diff --git a/iXBRLViewerPlugin/viewer/src/js/test-utils.js b/iXBRLViewerPlugin/viewer/src/js/test-utils.js
index 71b768773..59626b762 100644
--- a/iXBRLViewerPlugin/viewer/src/js/test-utils.js
+++ b/iXBRLViewerPlugin/viewer/src/js/test-utils.js
@@ -10,3 +10,30 @@ export function TestInspector() {
 }
 
 TestInspector.prototype = Object.create(Inspector.prototype);
+
+export function createSimpleFact(id, concept, options=null) {
+    options = options || {};
+    return {
+        [id]: {
+            "a": {
+                "c": concept,
+                "u": options["unit"],
+                "p": options["period"],
+            },
+            "d": options["decimals"],
+            "v": options["value"]
+        }
+    };
+}
+
+export function createNumericFact(id, concept, unit, period, value, decimals) {
+    const options = {
+        "unit": unit,
+        "period": period,
+        "value": value
+    };
+    if (decimals !== undefined) { 
+        options.decimals = decimals;
+    }
+    return createSimpleFact(id, concept, options);
+}

From beb15d11bef40d7e2e59d9412662956c251d1e30 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 2 Oct 2023 22:37:11 +0100
Subject: [PATCH 15/32] Fix legacy reference to dts property.

---
 iXBRLViewerPlugin/iXBRLViewer.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iXBRLViewerPlugin/iXBRLViewer.py b/iXBRLViewerPlugin/iXBRLViewer.py
index cd6ee44c1..deb32172e 100644
--- a/iXBRLViewerPlugin/iXBRLViewer.py
+++ b/iXBRLViewerPlugin/iXBRLViewer.py
@@ -487,7 +487,7 @@ def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool
         if packageDownloadURL is not None:
             self.taxonomyData["filingDocuments"] = packageDownloadURL
         elif len(self.reports) == 1 and os.path.dirname(self.reports[0].modelDocument.filepath).endswith('.zip'):
-            filingDocZipPath = os.path.dirname(self.dts.modelDocument.filepath)
+            filingDocZipPath = os.path.dirname(self.reports[0].modelDocument.filepath)
             filingDocZipName = os.path.basename(filingDocZipPath)
             iv.addFilingDoc(filingDocZipPath)
             self.taxonomyData["filingDocuments"] = filingDocZipName

From 1aa8ea010aa145b0647cea10321791b4b4183132 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 2 Oct 2023 22:45:22 +0100
Subject: [PATCH 16/32] Fix fact deep linking.

---
 iXBRLViewerPlugin/viewer/src/js/inspector.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index cdcda2034..336b22873 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -152,7 +152,7 @@ export class Inspector {
      */
     handleFactDeepLink() {
         const match = location.hash.match(/^#f(-|([0-9]+)-)(.*)$/);
-        if (match !== undefined) {
+        if (match !== null) {
             const reportId = match[1] === "-" ? 0 : match[2];
             const id = viewerUniqueId(reportId, match[3]);
             console.log(id);

From 706f0db5e5d6374ab8bfd76e2e87ae344771a42c Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 2 Oct 2023 23:11:06 +0100
Subject: [PATCH 17/32] Make anchoring detection multi-doc aware.

---
 iXBRLViewerPlugin/viewer/src/js/reportset.js  |   3 +-
 .../viewer/src/js/reportset.test.js           | 286 ++++++++++--------
 2 files changed, 161 insertions(+), 128 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index 6ca910dc4..220d31884 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -193,8 +193,7 @@ export class ReportSet {
     }
 
     usesAnchoring() {
-        // XXX hard-coded to first report
-        return this.reportsData()[0].rels["w-n"] !== undefined;
+        return this.reportsData().some(r => r.rels?.["w-n"] !== undefined);
     }
 
     hasValidationErrors() {
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.test.js b/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
index 64413afa8..38c3bd27d 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
@@ -5,143 +5,164 @@ import { ViewerOptions } from "./viewerOptions.js";
 import { viewerUniqueId } from "./util.js";
 import { createNumericFact } from "./test-utils.js";
 
-const multiReportTestData = {
-    "features": [],
-    "languages": {
-        "en-us": "English (US)",
-        "en": "English",
-        "fr": "French",
-    },
-    "prefixes": {
-        "eg": "http://www.example.com",
-        "iso4217": "http://www.xbrl.org/2003/iso4217"
-    },
-    "roles": {
-        "role1": "https://www.example.com/role1",
-        "role2": "https://www.example.com/role2",
-        "role3": "https://www.example.com/role3",
-        "role4": "https://www.example.com/role4"
-    },
-    "reports": [
-        {
-            "roleDefs": {
-                "role1": { "en": "Role 1 Label" },
-                "role2": { "en": null },
-                "role3": {}
-            },
-            "concepts": {
-                "eg:Concept1": {
-                    "labels": {
-                        "std": {
-                            "en": "English label"
-                        }
-                    }
+function anchoringRelationShips(include) {
+    if (include) {
+        return {
+          "w-n": {
+            "role1": {
+              "eg:Concept1": [{"t": "eg:Concept2"}],
+            }
+          }
+        }
+    }
+    return {}
+}
+
+function multiReportTestData(withAnchoring) {
+    return {
+        "features": [],
+        "languages": {
+            "en-us": "English (US)",
+            "en": "English",
+            "fr": "French",
+        },
+        "prefixes": {
+            "eg": "http://www.example.com",
+            "iso4217": "http://www.xbrl.org/2003/iso4217"
+        },
+        "roles": {
+            "role1": "https://www.example.com/role1",
+            "role2": "https://www.example.com/role2",
+            "role3": "https://www.example.com/role3",
+            "role4": "https://www.example.com/role4"
+        },
+        "reports": [
+            {
+                "roleDefs": {
+                    "role1": { "en": "Role 1 Label" },
+                    "role2": { "en": null },
+                    "role3": {}
                 },
-                "eg:Concept2": {
-                    "labels": {
-                        "std": {
-                            "en": "English label for concept two",
-                            "en-us": "English (US) label for concept two",
+                "concepts": {
+                    "eg:Concept1": {
+                        "labels": {
+                            "std": {
+                                "en": "English label"
+                            }
                         }
-                    }
-                },
-                "eg:Concept3": {
-                    "labels": {
-                        "std": {
-                            "en": "Concept three"
+                    },
+                    "eg:Concept2": {
+                        "labels": {
+                            "std": {
+                                "en": "English label for concept two",
+                                "en-us": "English (US) label for concept two",
+                            }
+                        }
+                    },
+                    "eg:Concept3": {
+                        "labels": {
+                            "std": {
+                                "en": "Concept three"
+                            }
                         }
                     }
-                }
-            },
+                },
 
-            "facts": {
-                ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
-                ...createNumericFact("f2", "eg:Concept2", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
-            }
-        },
-        {
-            "roleDefs": {
+                "facts": {
+                    ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+                    ...createNumericFact("f2", "eg:Concept2", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+                }
             },
-            "concepts": {
-                "eg:Concept1": {
-                    "labels": {
-                        "std": {
-                            "en": "English label"
-                        }
-                    }
+            {
+                "roleDefs": {
                 },
-                "eg:Concept2": {
-                    "labels": {
-                        "std": {
-                            "en": "Report 2 English label for concept two",
+                "concepts": {
+                    "eg:Concept1": {
+                        "labels": {
+                            "std": {
+                                "en": "English label"
+                            }
                         }
-                    }
-                },
-                "eg:Concept3": {
-                    "labels": {
-                        "std": {
-                            "en-gb": "Concept three"
+                    },
+                    "eg:Concept2": {
+                        "labels": {
+                            "std": {
+                                "en": "Report 2 English label for concept two",
+                            }
+                        }
+                    },
+                    "eg:Concept3": {
+                        "labels": {
+                            "std": {
+                                "en-gb": "Concept three"
+                            }
                         }
                     }
-                }
-            },
+                },
 
-            "facts": {
-                ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 2000, -3),
-            }
-        }
-    ]
-};
+                "facts": {
+                    ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 2000, -3),
+                },
 
-// Legacy report data format - no "reports" array
-const singleReportTestData = {
-    "features": [],
-    "languages": {
-        "en-us": "English (US)",
-        "en": "English",
-        "fr": "French",
-    },
-    "prefixes": {
-        "eg": "http://www.example.com",
-        "iso4217": "http://www.xbrl.org/2003/iso4217"
-    },
-    "roles": {
-        "role1": "https://www.example.com/role1",
-        "role2": "https://www.example.com/role2",
-        "role3": "https://www.example.com/role3",
-        "role4": "https://www.example.com/role4"
-    },
-    "roleDefs": {
-        "role1": { "en": "Role 1 Label" },
-        "role2": { "en": null },
-        "role3": {}
-    },
-    "concepts": {
-        "eg:Concept1": {
-            "labels": {
-                "std": {
-                    "en": "English label"
+                "rels": {
+                  ...anchoringRelationShips(withAnchoring)
                 }
             }
+        ]
+    };
+}
+
+// Legacy report data format - no "reports" array
+function singleReportTestData() {
+    return {
+        "features": [],
+        "languages": {
+            "en-us": "English (US)",
+            "en": "English",
+            "fr": "French",
+        },
+        "prefixes": {
+            "eg": "http://www.example.com",
+            "iso4217": "http://www.xbrl.org/2003/iso4217"
+        },
+        "roles": {
+            "role1": "https://www.example.com/role1",
+            "role2": "https://www.example.com/role2",
+            "role3": "https://www.example.com/role3",
+            "role4": "https://www.example.com/role4"
+        },
+        "roleDefs": {
+            "role1": { "en": "Role 1 Label" },
+            "role2": { "en": null },
+            "role3": {}
         },
-        "eg:Concept2": {
-            "labels": {
-                "std": {
-                    "en": "English label for concept two",
-                    "en-us": "English (US) label for concept two",
+        "concepts": {
+            "eg:Concept1": {
+                "labels": {
+                    "std": {
+                        "en": "English label"
+                    }
                 }
-            }
+            },
+            "eg:Concept2": {
+                "labels": {
+                    "std": {
+                        "en": "English label for concept two",
+                        "en-us": "English (US) label for concept two",
+                    }
+                }
+            },
         },
-    },
 
-    "facts": {
-        ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
-        ...createNumericFact("f2", "eg:Concept2", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
-    }
-};
+        "facts": {
+            ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+            ...createNumericFact("f2", "eg:Concept2", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+        }
+    };
+}
 
 describe("Multi report - basic", () => {
-    const testReportSet = new ReportSet(multiReportTestData);
+    const testReportSet = new ReportSet(multiReportTestData());
     testReportSet._initialize();
     test("Report count", () => {
         expect(testReportSet.reports).toHaveLength(2);
@@ -149,7 +170,7 @@ describe("Multi report - basic", () => {
 });
 
 describe("Multi report - Language options", () => {
-    const testReportSet = new ReportSet(multiReportTestData);
+    const testReportSet = new ReportSet(multiReportTestData());
     testReportSet._initialize();
     test("Available languages", () => {
         const al = testReportSet.availableLanguages();
@@ -167,7 +188,7 @@ describe("Multi report - Language options", () => {
 });
 
 describe("Multi report - Fetching facts", () => {
-    const testReportSet = new ReportSet(multiReportTestData);
+    const testReportSet = new ReportSet(multiReportTestData());
     testReportSet._initialize();
 
     test("Successful f1 (report 1)", () => {
@@ -193,7 +214,7 @@ describe("Multi report - Fetching facts", () => {
 });
 
 describe("Multi report - Concept labels", () => {
-    const testReportSet = new ReportSet(multiReportTestData);
+    const testReportSet = new ReportSet(multiReportTestData());
     testReportSet._initialize();
     const testReport = testReportSet.reports[0];
     const vo = new ViewerOptions();
@@ -207,7 +228,7 @@ describe("Multi report - Concept labels", () => {
 });
 
 describe("Multi report - ELR labels", () => {
-    const testReportSet = new ReportSet(multiReportTestData);
+    const testReportSet = new ReportSet(multiReportTestData());
     testReportSet._initialize();
 
     test("Present", () => {
@@ -217,8 +238,21 @@ describe("Multi report - ELR labels", () => {
     });
 });
 
+describe("Multi anchoring - ELR labels", () => {
+    test("Without anchoring", () => {
+        const testReportSet = new ReportSet(multiReportTestData(false));
+        testReportSet._initialize();
+        expect(testReportSet.usesAnchoring()).toBe(false);
+    });
+    test("With anchoring", () => {
+        const testReportSet = new ReportSet(multiReportTestData(true));
+        testReportSet._initialize();
+        expect(testReportSet.usesAnchoring()).toBe(true);
+    });
+});
+
 describe("Single report - basic", () => {
-    const testReportSet = new ReportSet(singleReportTestData);
+    const testReportSet = new ReportSet(singleReportTestData());
     testReportSet._initialize();
     test("Report count", () => {
         expect(testReportSet.reports).toHaveLength(1);
@@ -226,7 +260,7 @@ describe("Single report - basic", () => {
 });
 
 describe("Single report - Language options", () => {
-    const testReportSet = new ReportSet(singleReportTestData);
+    const testReportSet = new ReportSet(singleReportTestData());
     testReportSet._initialize();
     test("Available languages", () => {
         const al = testReportSet.availableLanguages();
@@ -244,7 +278,7 @@ describe("Single report - Language options", () => {
 });
 
 describe("Single report - Fetching facts", () => {
-    const testReportSet = new ReportSet(singleReportTestData);
+    const testReportSet = new ReportSet(singleReportTestData());
     testReportSet._initialize();
 
     test("Successful f1", () => {
@@ -265,7 +299,7 @@ describe("Single report - Fetching facts", () => {
 });
 
 describe("Single report - Concept labels", () => {
-    const testReportSet = new ReportSet(singleReportTestData);
+    const testReportSet = new ReportSet(singleReportTestData());
     testReportSet._initialize();
     const testReport = testReportSet.reports[0];
     const vo = new ViewerOptions();
@@ -277,7 +311,7 @@ describe("Single report - Concept labels", () => {
 });
 
 describe("ELR labels", () => {
-    const testReportSet = new ReportSet(singleReportTestData);
+    const testReportSet = new ReportSet(singleReportTestData());
     testReportSet._initialize();
 
     test("Present", () => {

From af8c506b41e607118254c1be8e829c4b88938528 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Tue, 3 Oct 2023 22:44:54 +0100
Subject: [PATCH 18/32] Comments, renaming, reportSet tests

---
 iXBRLViewerPlugin/iXBRLViewer.py              |  2 ++
 .../viewer/src/js/ixbrlviewer.js              |  2 +-
 iXBRLViewerPlugin/viewer/src/js/reportset.js  | 22 ++++++++++++++++---
 .../viewer/src/js/reportset.test.js           | 21 +++++++++++++++++-
 iXBRLViewerPlugin/viewer/src/js/util.js       |  9 ++++++++
 iXBRLViewerPlugin/viewer/src/js/viewer.js     |  6 ++---
 6 files changed, 54 insertions(+), 8 deletions(-)

diff --git a/iXBRLViewerPlugin/iXBRLViewer.py b/iXBRLViewerPlugin/iXBRLViewer.py
index e43ebad3c..80afd036e 100644
--- a/iXBRLViewerPlugin/iXBRLViewer.py
+++ b/iXBRLViewerPlugin/iXBRLViewer.py
@@ -444,8 +444,10 @@ def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool
 
             else:
                 if len(self.reports) == 1:
+                    # If there is only a single report, call the output file "xbrlviewer.html"
                     filename = "xbrlviewer.html"
                 else:
+                    # Otherwise, preserve filenames
                     filename = self.outputFilename(os.path.basename(report.modelDocument.filepath))
                     docSetFiles = [ filename ]
                 if xmlDocument is None:
diff --git a/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js b/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
index 76f1187a6..0ccd6bd24 100644
--- a/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
+++ b/iXBRLViewerPlugin/viewer/src/js/ixbrlviewer.js
@@ -220,7 +220,7 @@ iXBRLViewer.prototype.load = function () {
             return;
         }
         const reportSet = new ReportSet(parsedTaxonomyData);
-        const ds = reportSet.documentSetFiles();
+        const ds = reportSet.reportFiles();
         var hasExternalIframe = false;
         for (var i = stubViewer ? 0 : 1; i < ds.length; i++) {
             const iframe = $("<iframe />").attr("src", ds[i].file).data("report-index", ds[i].index).appendTo("#ixv #iframe-container");
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index 220d31884..28cd4875f 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -184,12 +184,28 @@ export class ReportSet {
         return this._data.reports ?? [ this._data ];
     }
 
-    documentSetFiles() {
+    /**
+     * Returns a flat list of source files for all reports in the report set.
+     * Each entry in the list is an object with:
+     *   file - name of the file
+     *   index - index of the report that it is for
+     * May return an empty list for single file, non-stub viewers.
+     * @return {List}   A list of objects describing each file
+     */
+    reportFiles() {
         return this.reportsData().map((x, n) => (x.docSetFiles ?? []).map(file => ({ index: n, file: file }))).flat();
     }
 
-    isDocumentSet() {
-        return this.documentSetFiles().length > 1;
+    /**
+     * Returns true if the viewer is for more than one Inline XBRL document
+     * This may be a single document set with multiple files, or multiple
+     * document sets
+     * @return {Boolean}   true if the viewer covers more than one iXBRL
+     *                     document
+     */
+
+    isMultiDocumentViewer() {
+        return this.reportFiles().length > 1;
     }
 
     usesAnchoring() {
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.test.js b/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
index 38c3bd27d..97d5b09f5 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
@@ -238,7 +238,7 @@ describe("Multi report - ELR labels", () => {
     });
 });
 
-describe("Multi anchoring - ELR labels", () => {
+describe("Multi report - anchoring", () => {
     test("Without anchoring", () => {
         const testReportSet = new ReportSet(multiReportTestData(false));
         testReportSet._initialize();
@@ -251,6 +251,25 @@ describe("Multi anchoring - ELR labels", () => {
     });
 });
 
+describe("Multi report - doc set files", () => {
+    test("Not overlapping", () => {
+        const data = multiReportTestData(false);
+        data.reports[0].docSetFiles = ["a.html", "b.html"];
+        data.reports[1].docSetFiles = ["c.html", "d.html"];
+        const testReportSet = new ReportSet(data);
+        testReportSet._initialize();
+        expect(testReportSet.reportFiles()).toStrictEqual([{"index": 0, "file": "a.html"}, {"index": 0, "file": "b.html"}, {"index": 1, "file": "c.html"}, {"index": 1, "file": "d.html"}]);
+    });
+    test("Repeated document set", () => {
+        const data = multiReportTestData(false);
+        data.reports[0].docSetFiles = ["a.html", "b.html"];
+        data.reports[1].docSetFiles = ["a.html", "b.html"];
+        const testReportSet = new ReportSet(data);
+        testReportSet._initialize();
+        expect(testReportSet.reportFiles()).toStrictEqual([{"index": 0, "file": "a.html"}, {"index": 0, "file": "b.html"}, {"index": 1, "file": "a.html"}, {"index": 1, "file": "b.html"}]);
+    });
+});
+
 describe("Single report - basic", () => {
     const testReportSet = new ReportSet(singleReportTestData());
     testReportSet._initialize();
diff --git a/iXBRLViewerPlugin/viewer/src/js/util.js b/iXBRLViewerPlugin/viewer/src/js/util.js
index 21ffebef6..f99264de1 100644
--- a/iXBRLViewerPlugin/viewer/src/js/util.js
+++ b/iXBRLViewerPlugin/viewer/src/js/util.js
@@ -161,6 +161,15 @@ export function isTransparent(rgba) {
     return !isNaN(val) && val < 0.1;
 }
 
+/**
+ * Prefix an item ID with the index of the report document that it appears in,
+ * in order to generate an ID that is guaranteed to be unique within the
+ * viewer. This is already within an iXBRL Document Set, but not across
+ * separate iXBRL documents or document sets.
+ * @param  {Integer}  reportIndex  Index of the report document containing the fact
+ * @return {String}   a viewer unique ID
+ */
+
 export function viewerUniqueId(reportIndex, id) {
     if (id === null) {
         return null;
diff --git a/iXBRLViewerPlugin/viewer/src/js/viewer.js b/iXBRLViewerPlugin/viewer/src/js/viewer.js
index 774290ef4..4367e6408 100644
--- a/iXBRLViewerPlugin/viewer/src/js/viewer.js
+++ b/iXBRLViewerPlugin/viewer/src/js/viewer.js
@@ -106,9 +106,9 @@ export class Viewer {
     }
 
     _addDocumentSetTabs() {
-        if (this._reportSet.isDocumentSet()) {
+        if (this._reportSet.isMultiDocumentViewer()) {
             $('#ixv .ixds-tabs').show();
-            for (const [i, doc] of this._reportSet.documentSetFiles().entries()) {
+            for (const [i, doc] of this._reportSet.reportFiles().entries()) {
                 $('<div class="tab">')
                     .text(doc.file)
                     .prop('title', doc.file)
@@ -231,7 +231,7 @@ export class Viewer {
         const url = $(n).attr("href");
         if (url !== undefined) {
             const [file, fragment] = url.split('#', 2);
-            const docIndex = this._reportSet.documentSetFiles().indexOf(file);
+            const docIndex = this._reportSet.reportFiles().indexOf(file);
             if (!url.includes('/') && docIndex != -1) {
                 $(n).click((e) => { 
                     this._showDocumentAndElement(docIndex, fragment);

From e82713eee59eb3acad949c0b4986a72c031749a0 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Wed, 4 Oct 2023 22:40:39 +0100
Subject: [PATCH 19/32] Initial draft of architecture document

---
 ARCHITECTURE.md | 117 ++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 117 insertions(+)
 create mode 100644 ARCHITECTURE.md

diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md
new file mode 100644
index 000000000..03ef0cd81
--- /dev/null
+++ b/ARCHITECTURE.md
@@ -0,0 +1,117 @@
+# Inline XBRL Viewer architecture 
+
+This document provides developer documentation for various aspects of the
+Inline XBRL Viewer.
+
+## JSON data
+
+The viewer relies on a block of JSON data that is embedded within the primary
+XHTML file of the viewer.  This avoids having to do full XBRL processing within
+the viewer, and avoids the need to access the report's taxonomy from the
+viewer.
+
+The format of the JSON data is described below.  Newer viewers are expected to
+work correctly with data generated by an older plugin version within the same
+major version, degrading new features gracefully if required.
+
+
+```
+{
+    "features": [],
+    "prefixes": {},
+    "roles": {},
+    "languages": {},
+    "sourceReports": [
+        {
+            "docSetFiles": [],
+            "targetReports": [
+                {
+                    "localDocs": {},
+                    "roleDefs": {},
+                    "concepts": {},
+                    "facts": {},
+                    "rels": {},
+                }
+            ]
+        }
+    ],
+    "validation": [],
+    "filingDocuments": "foo.zip"
+}
+```
+
+A viewer can contain one or more "source reports", each producing one or more
+target report.
+
+A source report is an Inline XBRL Document Set, comprising one or more Inline
+XBRL Documents.  A target report is the XBRL data obtained from extracting a
+given target document from the source report.
+
+Target documents are not yet supported, so at present, there will always be one
+target report per source report.
+
+### prefixes
+
+`prefixes` is a map of namespace prefixes to namespace URIs.  It is shared by
+all Target Reports.
+
+### languages
+
+
+```
+"languages": {
+    "en-us": "English (US)",
+    "en": "English",
+    "fr": "French",
+},
+
+```
+
+A map of language codes to language labels.  There should be an entry here for
+every language code used by a label in a report.
+
+### sourceReports
+
+`sourceReports` is an array of objects of report data.  Prior to multi-document
+support, this property was not present, and the `docSetFiles` property, and the
+properties of the objects within `targetReports` appeared at the top-level.
+
+There is an object in this array for each separate Inline XBRL Document Set in
+the viewer.
+
+### docSetFiles
+
+`docSetFiles` is a list of files in the document set.  It is used to load other
+documents in the document set into iframes in tabs in the viewer.  For single
+file, non-stub viewers, this property is not present.
+
+### targetReports
+
+An array of objects, one for each target document obtained from the enclosing
+source report.
+
+### localDocs
+
+```
+{
+    "filename.xsd": ["schema"],
+    "inline.xhtml": ["inline"],
+}
+```
+
+`localDocs` is the set of XBRL files local to the filing (i.e. the Inline XBRL
+files, and any extension taxonomies).
+
+The property is used to populate a summary of the files in the filing in the
+document summary panel.
+
+## IDs and Viewer Unique IDs
+
+The viewer requires all iXBRL facts to have `id` attributes.  The Python plugin
+will add `id` attributes to facts if not present.  IDs are required to be unique
+within an Inline XBRL Document Set, but in order to avoid collisions between IDs
+in different Inline XBRL Document Sets when multiple source reports are
+present, the JavaScript viewer prefixes IDs with a source report index when
+loading (e.g `0-f1` is `f1` in the first report).
+
+

From 86f50e3d73956d109f17e122814f232de1daf897 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Wed, 4 Oct 2023 22:43:41 +0100
Subject: [PATCH 20/32] Split reports data into sourceReports/targetReports.

---
 iXBRLViewerPlugin/iXBRLViewer.py              |  20 ++-
 iXBRLViewerPlugin/viewer/src/js/reportset.js  |  61 ++++----
 .../viewer/src/js/reportset.test.js           | 144 +++++++++---------
 iXBRLViewerPlugin/viewer/src/js/util.js       |   6 +-
 .../iXBRLViewerPlugin/test_iXBRLViewer.py     | 133 ++++++++++++----
 5 files changed, 226 insertions(+), 138 deletions(-)

diff --git a/iXBRLViewerPlugin/iXBRLViewer.py b/iXBRLViewerPlugin/iXBRLViewer.py
index 80afd036e..917e8b2a2 100644
--- a/iXBRLViewerPlugin/iXBRLViewer.py
+++ b/iXBRLViewerPlugin/iXBRLViewer.py
@@ -87,7 +87,7 @@ def __init__(self, reports: List[ModelXbrl], basenameSuffix: str = ''):
         self.roleMap = NamespaceMap()
         self.reports = reports
         self.taxonomyData = {
-            "reports": [],
+            "sourceReports": [],
             "features": [],
             "languages": {},
         }
@@ -145,9 +145,13 @@ def addLanguage(self, langCode):
         if langCode not in self.taxonomyData["languages"]:
             self.taxonomyData["languages"][langCode] = self.makeLanguageName(langCode)
 
+    @property
+    def currentSourceReportData(self):
+        return self.taxonomyData["sourceReports"][-1]
+
     @property
     def currentReportData(self):
-        return self.taxonomyData["reports"][-1]
+        return self.currentSourceReportData["targetReports"][-1]
             
     def addELR(self, report: ModelXbrl, elr):
         prefix = self.roleMap.getPrefix(elr)
@@ -379,9 +383,13 @@ def getStubDocument(self):
             return etree.parse(fin)
 
     def addReport(self):
-        self.taxonomyData["reports"].append({
-            "concepts": {},
-            "facts": {},
+        self.taxonomyData["sourceReports"].append({
+            "targetReports": [
+                {
+                    "concepts": {},
+                    "facts": {},
+                }
+            ]
         })
 
     def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool = False, showValidations: bool = True, packageDownloadURL: str = None) -> Optional[iXBRLViewer]:
@@ -479,7 +487,7 @@ def createViewer(self, scriptUrl: str = DEFAULT_VIEWER_PATH, useStubViewer: bool
             }
 
             if docSetFiles is not None:
-                self.currentReportData["docSetFiles"] = list(urllib.parse.quote(f) for f in docSetFiles)
+                self.currentSourceReportData["docSetFiles"] = list(urllib.parse.quote(f) for f in docSetFiles)
 
         self.taxonomyData["prefixes"] = self.nsmap.prefixmap
         self.taxonomyData["roles"] = self.roleMap.prefixmap
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index 28cd4875f..229e1157c 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -38,34 +38,36 @@ export class ReportSet {
         fnorder.sort((a,b) => this._ixNodeMap[a].docOrderindex - this._ixNodeMap[b].docOrderindex);
 
         // Create Fact objects for all facts.
-        for (const [reportIndex, reportData] of this.reportsData().entries()) {
-            const report = new XBRLReport(this, reportData);
-            this.reports.push(report);
-            for (const [id, factData] of Object.entries(reportData.facts)) {
-                const vuid = viewerUniqueId(reportIndex, id);
-                this._items[vuid] = new Fact(report, vuid, factData);
-            }
+        for (const [reportIndex, sourceReport] of (this._data.sourceReports ?? [ { "targetReports": [ this._data ] } ]).entries()) {
+            for (const reportData of sourceReport.targetReports) {
+                const report = new XBRLReport(this, reportData);
+                this.reports.push(report);
+                for (const [id, factData] of Object.entries(reportData.facts)) {
+                    const vuid = viewerUniqueId(reportIndex, id);
+                    this._items[vuid] = new Fact(report, vuid, factData);
+                }
 
-            // Now resolve footnote references, creating footnote objects for "normal"
-            // footnotes, and finding Fact objects for fact->fact footnotes.  
-            //
-            // Associate source facts with target footnote/facts to allow two way
-            // navigation.
-            for (const [id, factData] of Object.entries(reportData.facts)) {
-                const vuid = viewerUniqueId(reportIndex, id);
-                const fact = this._items[vuid];
-                const fns = factData.fn || [];
-                fns.forEach((fnid) => {
-                    const fnvuid = viewerUniqueId(reportIndex, fnid);
-                    var fn = this._items[fnvuid];
-                    if (fn === undefined) {
-                        fn = new Footnote(fact.report, fnvuid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
-                        this._items[fnvuid] = fn;
-                    }
-                    // Associate fact with footnote
-                    fn.addLinkedFact(fact);
-                    fact.addFootnote(fn);
-                });
+                // Now resolve footnote references, creating footnote objects for "normal"
+                // footnotes, and finding Fact objects for fact->fact footnotes.  
+                //
+                // Associate source facts with target footnote/facts to allow two way
+                // navigation.
+                for (const [id, factData] of Object.entries(reportData.facts)) {
+                    const vuid = viewerUniqueId(reportIndex, id);
+                    const fact = this._items[vuid];
+                    const fns = factData.fn || [];
+                    fns.forEach((fnid) => {
+                        const fnvuid = viewerUniqueId(reportIndex, fnid);
+                        var fn = this._items[fnvuid];
+                        if (fn === undefined) {
+                            fn = new Footnote(fact.report, fnvuid, "Footnote " + (fnorder.indexOf(fnvuid) + 1));
+                            this._items[fnvuid] = fn;
+                        }
+                        // Associate fact with footnote
+                        fn.addLinkedFact(fact);
+                        fact.addFootnote(fn);
+                    });
+                }
             }
         }
     }
@@ -181,7 +183,7 @@ export class ReportSet {
     }
 
     reportsData() {
-        return this._data.reports ?? [ this._data ];
+        return this._data.sourceReports?.flatMap(sr => sr.targetReports) ?? [ this._data ];
     }
 
     /**
@@ -193,7 +195,8 @@ export class ReportSet {
      * @return {List}   A list of objects describing each file
      */
     reportFiles() {
-        return this.reportsData().map((x, n) => (x.docSetFiles ?? []).map(file => ({ index: n, file: file }))).flat();
+        const sourceReports = this._data.sourceReports ?? [ this._data ];
+        return sourceReports.map((x, n) => (x.docSetFiles ?? []).map(file => ({ index: n, file: file }))).flat();
     }
 
     /**
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.test.js b/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
index 97d5b09f5..d2415651d 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.test.js
@@ -36,83 +36,91 @@ function multiReportTestData(withAnchoring) {
             "role3": "https://www.example.com/role3",
             "role4": "https://www.example.com/role4"
         },
-        "reports": [
-            {
-                "roleDefs": {
-                    "role1": { "en": "Role 1 Label" },
-                    "role2": { "en": null },
-                    "role3": {}
-                },
-                "concepts": {
-                    "eg:Concept1": {
-                        "labels": {
-                            "std": {
-                                "en": "English label"
-                            }
-                        }
-                    },
-                    "eg:Concept2": {
-                        "labels": {
-                            "std": {
-                                "en": "English label for concept two",
-                                "en-us": "English (US) label for concept two",
+        "sourceReports": [
+            { 
+                "targetReports": [
+                    {
+                        "roleDefs": {
+                            "role1": { "en": "Role 1 Label" },
+                            "role2": { "en": null },
+                            "role3": {}
+                        },
+                        "concepts": {
+                            "eg:Concept1": {
+                                "labels": {
+                                    "std": {
+                                        "en": "English label"
+                                    }
+                                }
+                            },
+                            "eg:Concept2": {
+                                "labels": {
+                                    "std": {
+                                        "en": "English label for concept two",
+                                        "en-us": "English (US) label for concept two",
+                                    }
+                                }
+                            },
+                            "eg:Concept3": {
+                                "labels": {
+                                    "std": {
+                                        "en": "Concept three"
+                                    }
+                                }
                             }
+                        },
+
+                        "facts": {
+                            ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
+                            ...createNumericFact("f2", "eg:Concept2", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
                         }
                     },
-                    "eg:Concept3": {
-                        "labels": {
-                            "std": {
-                                "en": "Concept three"
-                            }
-                        }
-                    }
-                },
-
-                "facts": {
-                    ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
-                    ...createNumericFact("f2", "eg:Concept2", "iso2417:USD", "2018-01-01/2019-01-01", 1000, -3),
-                }
+                ]
             },
             {
-                "roleDefs": {
-                },
-                "concepts": {
-                    "eg:Concept1": {
-                        "labels": {
-                            "std": {
-                                "en": "English label"
+                "targetReports": [
+                    {
+                        "roleDefs": {
+                        },
+                        "concepts": {
+                            "eg:Concept1": {
+                                "labels": {
+                                    "std": {
+                                        "en": "English label"
+                                    }
+                                }
+                            },
+                            "eg:Concept2": {
+                                "labels": {
+                                    "std": {
+                                        "en": "Report 2 English label for concept two",
+                                    }
+                                }
+                            },
+                            "eg:Concept3": {
+                                "labels": {
+                                    "std": {
+                                        "en-gb": "Concept three"
+                                    }
+                                }
                             }
-                        }
-                    },
-                    "eg:Concept2": {
-                        "labels": {
-                            "std": {
-                                "en": "Report 2 English label for concept two",
-                            }
-                        }
-                    },
-                    "eg:Concept3": {
-                        "labels": {
-                            "std": {
-                                "en-gb": "Concept three"
-                            }
-                        }
-                    }
-                },
+                        },
 
-                "facts": {
-                    ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 2000, -3),
-                },
+                        "facts": {
+                            ...createNumericFact("f1", "eg:Concept1", "iso2417:USD", "2018-01-01/2019-01-01", 2000, -3),
+                        },
 
-                "rels": {
-                  ...anchoringRelationShips(withAnchoring)
-                }
+                        "rels": {
+                          ...anchoringRelationShips(withAnchoring)
+                        }
+                    }
+                ]
             }
         ]
     };
 }
 
-// Legacy report data format - no "reports" array
+// Legacy report data format - no "sourceReports" array
 function singleReportTestData() {
     return {
         "features": [],
@@ -254,16 +262,16 @@ describe("Multi report - anchoring", () => {
 describe("Multi report - doc set files", () => {
     test("Not overlapping", () => {
         const data = multiReportTestData(false);
-        data.reports[0].docSetFiles = ["a.html", "b.html"];
-        data.reports[1].docSetFiles = ["c.html", "d.html"];
+        data.sourceReports[0].docSetFiles = ["a.html", "b.html"];
+        data.sourceReports[1].docSetFiles = ["c.html", "d.html"];
         const testReportSet = new ReportSet(data);
         testReportSet._initialize();
         expect(testReportSet.reportFiles()).toStrictEqual([{"index": 0, "file": "a.html"}, {"index": 0, "file": "b.html"}, {"index": 1, "file": "c.html"}, {"index": 1, "file": "d.html"}]);
     });
     test("Repeated document set", () => {
         const data = multiReportTestData(false);
-        data.reports[0].docSetFiles = ["a.html", "b.html"];
-        data.reports[1].docSetFiles = ["a.html", "b.html"];
+        data.sourceReports[0].docSetFiles = ["a.html", "b.html"];
+        data.sourceReports[1].docSetFiles = ["a.html", "b.html"];
         const testReportSet = new ReportSet(data);
         testReportSet._initialize();
         expect(testReportSet.reportFiles()).toStrictEqual([{"index": 0, "file": "a.html"}, {"index": 0, "file": "b.html"}, {"index": 1, "file": "a.html"}, {"index": 1, "file": "b.html"}]);
diff --git a/iXBRLViewerPlugin/viewer/src/js/util.js b/iXBRLViewerPlugin/viewer/src/js/util.js
index f99264de1..e39760b95 100644
--- a/iXBRLViewerPlugin/viewer/src/js/util.js
+++ b/iXBRLViewerPlugin/viewer/src/js/util.js
@@ -166,13 +166,13 @@ export function isTransparent(rgba) {
  * in order to generate an ID that is guaranteed to be unique within the
  * viewer. This is already within an iXBRL Document Set, but not across
  * separate iXBRL documents or document sets.
- * @param  {Integer}  reportIndex  Index of the report document containing the fact
+ * @param  {Integer}  sourceReportIndex - index of the report document containing the fact
  * @return {String}   a viewer unique ID
  */
 
-export function viewerUniqueId(reportIndex, id) {
+export function viewerUniqueId(sourceReportIndex, id) {
     if (id === null) {
         return null;
     }
-    return reportIndex.toString() + "-" + id;
+    return sourceReportIndex.toString() + "-" + id;
 }
diff --git a/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py b/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
index 7aa72defd..1b129048b 100644
--- a/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
+++ b/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
@@ -321,20 +321,26 @@ def info_effect(info, msg):
 
         self.modelDocument = Mock(
             xmlDocument=etree.ElementTree(root),
-            filepath='c.xml'
+            filepath='a.html',
+            referencesDocument={
+                "xmlDocument":etree.ElementTree(root),
+                "filepath":'a.html',
+                "objectIndex":0,
+                "type":Type.INLINEXBRL,
+            }
         )
 
         self.modelDocumentInlineSet = Mock(
             referencesDocument={
                 Mock(
                     xmlDocument=etree.ElementTree(root),
-                    filepath='a.xml',
+                    filepath='a.html',
                     objectIndex=0,
                     type=Type.INLINEXBRL,
                 ): [],
                 Mock(
                     xmlDocument=etree.ElementTree(root),
-                    filepath='b.xml',
+                    filepath='b.html',
                     objectIndex=1,
                     type=Type.INLINEXBRL,
                 ): [],
@@ -434,7 +440,6 @@ def urlDocEntry(path, docType, linkQName=None):
         typed_dimension_domain_concept.modelXbrl = self.modelXbrl_1
         member_concept.modelXbrl = self.modelXbrl_1
 
-
         self.builder_1 = IXBRLViewerBuilder([self.modelXbrl_1])
         self.builder_2 = IXBRLViewerBuilder([self.modelXbrl_1])
         self.builder_3 = IXBRLViewerBuilder([self.modelXbrl_2])
@@ -443,9 +448,10 @@ def urlDocEntry(path, docType, linkQName=None):
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
     def test_addConcept_simple_case(self):
-        self.builder_1.addReport()
-        self.builder_1.addConcept(self.modelXbrl_1, self.cash_concept)
-        self.assertTrue(self.builder_1.taxonomyData["reports"][0].get('concepts').get('us-gaap:Cash'))
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
+        builder.addReport()
+        builder.addConcept(self.modelXbrl_1, self.cash_concept)
+        self.assertTrue(builder.taxonomyData["sourceReports"][0]["targetReports"][0].get('concepts').get('us-gaap:Cash'))
 
     @patch('arelle.XbrlConst.parentChild', 'http://www.xbrl.org/2003/arcrole/parent-child')
     @patch('arelle.XbrlConst.summationItem', 'http://www.xbrl.org/2003/arcrole/summation-item')
@@ -458,9 +464,10 @@ def test_getRelationships_simple_case(self):
     @patch('arelle.XbrlConst.parentChild', 'http://www.xbrl.org/2003/arcrole/parent-child')
     @patch('arelle.XbrlConst.summationItem', 'http://www.xbrl.org/2003/arcrole/summation-item')
     def test_getRelationships_returns_a_rel(self):
-        self.builder_1.addReport()
-        result = self.builder_1.getRelationships(self.modelXbrl_1)
-        roleMap = self.builder_1.roleMap
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
+        builder.addReport()
+        result = builder.getRelationships(self.modelXbrl_1)
+        roleMap = builder.roleMap
         siPrefix = roleMap.getPrefix('http://www.xbrl.org/2003/arcrole/summation-item')
         self.assertTrue(result.get(siPrefix).get(roleMap.getPrefix('ELR')).get('us-gaap:from_concept'))
 
@@ -469,20 +476,22 @@ def test_addELR_no_definition(self):
         Adding an ELR with no definition should result in no entry in the roleDefs map
         """
         elr = "http://example.com/unknownELR"
-        self.builder_1.addReport()
-        self.builder_1.addELR(self.modelXbrl_1, elr)
-        elrPrefix = self.builder_1.roleMap.getPrefix(elr)
-        self.assertEqual(self.builder_1.currentReportData.get('roleDefs').get(elrPrefix), None)
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
+        builder.addReport()
+        builder.addELR(self.modelXbrl_1, elr)
+        elrPrefix = builder.roleMap.getPrefix(elr)
+        self.assertEqual(builder.currentReportData.get('roleDefs').get(elrPrefix), None)
 
     def test_addELR_with_definition(self):
         """
         Adding an ELR with a definition should result in an "en" label with the definition as its value.
         """
         elr = "ELR"
-        self.builder_1.addReport()
-        self.builder_1.addELR(self.modelXbrl_1, elr)
-        elrPrefix = self.builder_1.roleMap.getPrefix(elr)
-        self.assertEqual(self.builder_1.currentReportData.get('roleDefs').get(elrPrefix).get("en"), "ELR Label")
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
+        builder.addReport()
+        builder.addELR(self.modelXbrl_1, elr)
+        elrPrefix = builder.roleMap.getPrefix(elr)
+        self.assertEqual(builder.currentReportData.get('roleDefs').get(elrPrefix).get("en"), "ELR Label")
 
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
@@ -493,7 +502,8 @@ def test_addELR_with_definition(self):
     @patch('arelle.XbrlConst.documentationLabel', 'http://www.xbrl.org/2003/role/documentation')
     def test_createViewerWithValidation(self):
         js_uri = 'ixbrlviewer.js'
-        result = self.builder_1.createViewer(js_uri)
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
+        result = builder.createViewer(js_uri)
         self.assertEqual(len(result.files),1)
         body = result.files[0].xmlDocument.getroot()[0]
         self.assertEqual(body[0].text, 'BEGIN IXBRL VIEWER EXTENSIONS')
@@ -505,7 +515,7 @@ def test_createViewerWithValidation(self):
         jsdata = json.loads(body[2].text)
         errors = jsdata["validation"]
         self.assertEqual(errors, [{"sev": "ERROR", "msg": "Error message", "code": "code1" }])
-        self.assertEqual(set(jsdata["reports"][0]["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
+        self.assertEqual(set(jsdata["sourceReports"][0]["targetReports"][0]["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
 
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
@@ -516,8 +526,9 @@ def test_createViewerWithValidation(self):
     @patch('arelle.XbrlConst.dimensionDefault', 'http://xbrl.org/int/dim/arcrole/dimension-default')
     def test_createViewer(self):
         js_uri = 'ixbrlviewer.js'
-        result = self.builder_2.createViewer(js_uri, showValidations = False)
-        self.assertEqual(len(result.files),1)
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
+        result = builder.createViewer(js_uri, showValidations = False)
+        self.assertEqual(len(result.files), 1)
         body = result.files[0].xmlDocument.getroot()[0]
         self.assertEqual(body[0].text, 'BEGIN IXBRL VIEWER EXTENSIONS')
         self.assertEqual(body[1].attrib.get('src'), js_uri)
@@ -527,9 +538,9 @@ def test_createViewer(self):
 
         jsdata = json.loads(body[2].text)
         self.assertNotIn("validation", jsdata)
-        print(jsdata["reports"])
-        self.assertEqual(set(jsdata["reports"][0]["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
-        self.assertEqual(jsdata["reports"][0]["concepts"], {
+        reportData = jsdata["sourceReports"][0]["targetReports"][0]
+        self.assertEqual(set(reportData["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
+        self.assertEqual(reportData["concepts"], {
             'us-gaap:Cash': {'e': True, 't': True, 'labels': {}},
             'us-gaap:from_concept': {'e': True, 't': True, 'labels': {}},
             'us-gaap:to_concept': {'e': True, 't': True, 'labels': {}},
@@ -538,7 +549,7 @@ def test_createViewer(self):
             'us-gaap:typed_dimension_domain': {'e': True, 't': True, 'labels': {}},
             'us-gaap:typed_dimension': {'d': 't', 'e': True, 't': True, 'labels': {}, 'td': 'us-gaap:typed_dimension_domain'},
         })
-        self.assertEqual(jsdata["reports"][0]["localDocs"], {
+        self.assertEqual(reportData["localDocs"], {
             'local-inline.htm': ['inline'],
             'local-schema.xsd': ['schema'],
             'local-pres-linkbase.xml': ['presLinkbase'],
@@ -549,6 +560,55 @@ def test_createViewer(self):
             'local-unrecognized-linkbase.xml': ['unrecognizedLinkbase'],
         })
 
+        # There's not actually a good reason for not including "docSetFiles"
+        # now, but it's what we do currently.
+        self.assertNotIn("docSetFiles", jsdata["sourceReports"][0]);
+
+    @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
+    @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
+    @patch('arelle.XbrlConst.parentChild', 'http://www.xbrl.org/2003/arcrole/parent-child')
+    @patch('arelle.XbrlConst.summationItem', 'http://www.xbrl.org/2003/arcrole/summation-item')
+    @patch('arelle.XbrlConst.standardLabel', 'http://www.xbrl.org/2003/role/label')
+    @patch('arelle.XbrlConst.documentationLabel', 'http://www.xbrl.org/2003/role/documentation')
+    @patch('arelle.XbrlConst.dimensionDefault', 'http://xbrl.org/int/dim/arcrole/dimension-default')
+    def test_createStubViewer(self):
+        js_uri = 'ixbrlviewer.js'
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
+        result = builder.createViewer(js_uri, showValidations = False, useStubViewer = True)
+        self.assertEqual(len(result.files), 2)
+        body = result.files[0].xmlDocument.getroot().find('{http://www.w3.org/1999/xhtml}body')
+        self.assertEqual(body[0].text, 'BEGIN IXBRL VIEWER EXTENSIONS')
+        self.assertEqual(body[1].attrib.get('src'), js_uri)
+        self.assertEqual(body[1].attrib.get('type'), 'text/javascript')
+        self.assertEqual(body[2].attrib.get('type'), 'application/x.ixbrl-viewer+json')
+        self.assertEqual(body[3].text, 'END IXBRL VIEWER EXTENSIONS')
+
+        jsdata = json.loads(body[2].text)
+        self.assertNotIn("validation", jsdata)
+        reportData = jsdata["sourceReports"][0]["targetReports"][0]
+        self.assertEqual(set(reportData["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
+        self.assertEqual(reportData["concepts"], {
+            'us-gaap:Cash': {'e': True, 't': True, 'labels': {}},
+            'us-gaap:from_concept': {'e': True, 't': True, 'labels': {}},
+            'us-gaap:to_concept': {'e': True, 't': True, 'labels': {}},
+            'us-gaap:dimension': {'d': 'e', 'e': True, 't': True, 'labels': {}},
+            'us-gaap:member': {'e': True, 't': True, 'labels': {}},
+            'us-gaap:typed_dimension_domain': {'e': True, 't': True, 'labels': {}},
+            'us-gaap:typed_dimension': {'d': 't', 'e': True, 't': True, 'labels': {}, 'td': 'us-gaap:typed_dimension_domain'},
+        })
+        self.assertEqual(reportData["localDocs"], {
+            'local-inline.htm': ['inline'],
+            'local-schema.xsd': ['schema'],
+            'local-pres-linkbase.xml': ['presLinkbase'],
+            'local-calc-linkbase.xml': ['calcLinkbase'],
+            'local-def-linkbase.xml': ['defLinkbase'],
+            'local-label-linkbase.xml': ['labelLinkbase'],
+            'local-ref-linkbase.xml': ['refLinkbase'],
+            'local-unrecognized-linkbase.xml': ['unrecognizedLinkbase'],
+        })
+
+        self.assertEqual(jsdata["sourceReports"][0]["docSetFiles"], [ "a.html" ]);
+
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
     @patch('arelle.XbrlConst.parentChild', 'http://www.xbrl.org/2003/arcrole/parent-child')
@@ -569,7 +629,13 @@ def test_createViewer_docset(self):
 
         jsdata = json.loads(body[2].text)
         self.assertNotIn("validation", jsdata)
-        self.assertEqual(set(jsdata["reports"][0]["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
+        reportData = jsdata["sourceReports"][0]["targetReports"][0]
+        self.assertEqual(set(reportData["facts"]), {"fact_id1", "fact_typed_dimension", "fact_dimension_missing_member"})
+
+        self.assertEqual(jsdata["sourceReports"][0]["docSetFiles"], [
+            'a.html',
+            'b.html'
+        ])
 
     @patch('arelle.XbrlConst.conceptLabel', 'http://www.xbrl.org/2003/arcrole/concept-label')
     @patch('arelle.XbrlConst.conceptReference', 'http://www.xbrl.org/2003/arcrole/concept-reference')
@@ -580,7 +646,8 @@ def test_createViewer_docset(self):
     @patch('arelle.XbrlConst.documentationLabel', 'http://www.xbrl.org/2003/role/documentation')
     def test_createViewer_bad_path(self):
         js_uri = 'ixbrlviewer.js'
-        result = self.builder_3.createViewer(js_uri)
+        builder = IXBRLViewerBuilder([self.modelXbrl_2])
+        result = builder.createViewer(js_uri)
         self.assertEqual(len(result.files),1)
         body = result.files[0].xmlDocument.getroot()[0]
         self.assertEqual(body[0].text, 'BEGIN IXBRL VIEWER EXTENSIONS')
@@ -594,7 +661,7 @@ def test_createViewer_bad_path(self):
         self.assertEqual(body[3].text, 'END IXBRL VIEWER EXTENSIONS')
 
         jsdata = json.loads(body[2].text)
-        facts = jsdata["reports"][0]["facts"]
+        facts = jsdata["sourceReports"][0]["targetReports"][0]["facts"]
         self.assertEqual(facts.keys(), {"fact_id2", "fact_id3"})
         self.assertEqual(facts["fact_id2"]["a"]["u"], "iso4217:USD")
         self.assertEqual(facts["fact_id3"]["a"]["u"], None)
@@ -603,15 +670,17 @@ def test_enableFeature_valid(self):
         """
         Enable a defined feature
         """
-        self.builder_1.enableFeature('review')
-        self.assertEqual(self.builder_1.taxonomyData["features"], ['review'])
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
+        builder.enableFeature('review')
+        self.assertEqual(builder.taxonomyData["features"], ['review'])
 
     def test_enableFeature_invalid(self):
         """
         Attempt to enable an undefined feature
         """
+        builder = IXBRLViewerBuilder([self.modelXbrl_1])
         with self.assertRaisesRegex(AssertionError, rf'^Given feature name `unknown` does not match any defined features'):
-            self.builder_1.enableFeature('unknown')
+            builder.enableFeature('unknown')
 
     def test_xhtmlNamespaceHandling(self):
         # Check the prefix used for our inserted script tags

From 169b0279b78eb5b57b3b8cfdbe731465a709b7f0 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Thu, 5 Oct 2023 13:42:38 +0100
Subject: [PATCH 21/32] Add comment explaining keepOpen option.

---
 iXBRLViewerPlugin/__init__.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/iXBRLViewerPlugin/__init__.py b/iXBRLViewerPlugin/__init__.py
index bde388706..30305c511 100644
--- a/iXBRLViewerPlugin/__init__.py
+++ b/iXBRLViewerPlugin/__init__.py
@@ -81,6 +81,8 @@ def iXBRLViewerCommandLineOptionExtender(parser, *args, **kwargs):
                       default=False,
                       dest="zipViewerOutput",
                       help="Converts the viewer output into a self contained zip")
+    # Force "keepOpen" to true, so that all models are retained.  Needed for
+    # multi-instance viewers.
     parser.add_option("--keepOpen", dest="keepOpen", default=True, action="store_true", help=argparse.SUPPRESS)
     featureGroup = OptionGroup(parser, "Viewer Features",
                             "See viewer README for information on enabling/disabling features.")

From 74f4e0d98fb66beebf6ecd950e1831ad7876e18c Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Thu, 5 Oct 2023 13:46:54 +0100
Subject: [PATCH 22/32] Remove legacy reference to dts object.

---
 iXBRLViewerPlugin/iXBRLViewer.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/iXBRLViewerPlugin/iXBRLViewer.py b/iXBRLViewerPlugin/iXBRLViewer.py
index 917e8b2a2..353c70290 100644
--- a/iXBRLViewerPlugin/iXBRLViewer.py
+++ b/iXBRLViewerPlugin/iXBRLViewer.py
@@ -234,9 +234,7 @@ def getRelationships(self, report: ModelXbrl):
         return rels
 
     def validationErrors(self):
-        dts = self.reports[0]
-
-        logHandler = dts.modelManager.cntlr.logHandler
+        logHandler = self.reports[0].modelManager.cntlr.logHandler
         if getattr(logHandler, "logRecordBuffer") is None:
             raise IXBRLViewerBuilderError("Logging is not configured to use a buffer.  Unable to retrieve validation messages")
 

From 60a0c06f9cd59434e0e80501220874f08ad6dbb5 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Fri, 6 Oct 2023 19:28:29 +0100
Subject: [PATCH 23/32] Expand description of viewer unique IDs.

---
 ARCHITECTURE.md | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/ARCHITECTURE.md b/ARCHITECTURE.md
index 03ef0cd81..de44ee313 100644
--- a/ARCHITECTURE.md
+++ b/ARCHITECTURE.md
@@ -111,7 +111,11 @@ The viewer requires all iXBRL facts to have `id` attributes.  The Python plugin
 will add `id` attributes to facts if not present.  IDs are required to be unique
 within an Inline XBRL Document Set, but in order to avoid collisions between IDs
 in different Inline XBRL Document Sets when multiple source reports are
-present, the JavaScript viewer prefixes IDs with a source report index when
-loading (e.g `0-f1` is `f1` in the first report).
+present, the JavaScript viewer internally uses "viewer unique IDs", which are
+the `id` attribute values prefixed by the source report index (e.g `0-f1` is
+`f1` in the first report).  The original `id` attributes are only used to
+resolve footnotes and continuation chains during the pre-process phase.  Facts
+are selected via the `ivids` data attribute on wrapper nodes, which uses viewer
+unique IDs.
 
 

From b7097cbc749274f86aaf75c70d8e076e92aaa50a Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Fri, 6 Oct 2023 20:29:02 +0100
Subject: [PATCH 24/32] Don't include report number in fragment for first
 report.

---
 iXBRLViewerPlugin/viewer/src/js/inspector.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index 336b22873..7cfa41cd1 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -184,7 +184,9 @@ export class Inspector {
 
     updateURLFragment() {
         if (this._currentItem) {
-            location.hash = "#f" + this._currentItem.id;
+            // Don't include report number for first report for compatibility
+            // with legacy fragments
+            location.hash = "#f" + this._currentItem.id.replace(/^0-/,  "-");
         }
         else {
             location.hash = "";

From dcbfc44f6c95dc9f918e857dc7a14b487f3ff0a2 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Fri, 6 Oct 2023 21:10:04 +0100
Subject: [PATCH 25/32] Renaming/refactoring to clarify viewer unique IDs

---
 .../viewer/src/js/calculations.js             |  2 +-
 iXBRLViewerPlugin/viewer/src/js/fact.js       |  6 ++--
 iXBRLViewerPlugin/viewer/src/js/factset.js    | 14 ++++-----
 iXBRLViewerPlugin/viewer/src/js/footnote.js   |  2 +-
 iXBRLViewerPlugin/viewer/src/js/inspector.js  | 31 +++++++++----------
 iXBRLViewerPlugin/viewer/src/js/search.js     |  2 +-
 iXBRLViewerPlugin/viewer/src/js/util.js       | 10 ++++--
 iXBRLViewerPlugin/viewer/src/js/viewer.js     | 12 +++----
 8 files changed, 41 insertions(+), 38 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/calculations.js b/iXBRLViewerPlugin/viewer/src/js/calculations.js
index 31562ef61..a60c5726d 100644
--- a/iXBRLViewerPlugin/viewer/src/js/calculations.js
+++ b/iXBRLViewerPlugin/viewer/src/js/calculations.js
@@ -32,7 +32,7 @@ Calculation.prototype.calculationFacts = function () {
             ctf[elr] = {};
             if (rr.length > 0) {
                 var otherFacts = report.getAlignedFacts(fact, {"c": $.map(rr, (r,i) => r.t ) });
-                $.each(otherFacts, (i,ff) => setDefault(ctf[elr], ff.conceptName(), {})[ff.id] = ff);
+                $.each(otherFacts, (i,ff) => setDefault(ctf[elr], ff.conceptName(), {})[ff.vuid] = ff);
             }
         });
         this._conceptToFact = ctf;
diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.js b/iXBRLViewerPlugin/viewer/src/js/fact.js
index 19d5a7402..d52b74109 100644
--- a/iXBRLViewerPlugin/viewer/src/js/fact.js
+++ b/iXBRLViewerPlugin/viewer/src/js/fact.js
@@ -4,7 +4,7 @@ import $ from 'jquery'
 import i18next from "i18next";
 import { Aspect } from "./aspect.js";
 import { Period } from './period.js';
-import { formatNumber } from "./util.js";
+import { formatNumber, localId } from "./util.js";
 import Decimal from "decimal.js";
 
 export class Fact {
@@ -13,13 +13,13 @@ export class Fact {
         this.f = factData;
         this.ixNode = report.reportSet.getIXNodeForItemId(factId);
         this.report = report;
-        this.id = factId;
+        this.vuid = factId;
         this.linkedFacts = [];
         this._footnotes = [];
     }
 
     localId() {
-        return this.id.replace(/^\d+-/,"");
+        localId(this.vuid);
     }
 
     getLabel(rolePrefix, withPrefix) {
diff --git a/iXBRLViewerPlugin/viewer/src/js/factset.js b/iXBRLViewerPlugin/viewer/src/js/factset.js
index 5d83706b0..308f5131b 100644
--- a/iXBRLViewerPlugin/viewer/src/js/factset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/factset.js
@@ -37,10 +37,10 @@ export class FactSet {
              * consistent order */
             for (var i = 0; i < facts.length; i++) {
                 var f = facts[i];
-                allLabels[f.id] = [];
+                allLabels[f.vuid] = [];
                 for (var j = 0; j < allAspects.length; j++) {
                     var dd = f.aspect(allAspects[j]);
-                    allLabels[f.id].push(dd ? dd.valueLabel() : null);
+                    allLabels[f.vuid].push(dd ? dd.valueLabel() : null);
                 }
             }
             /* Iterate each aspect label and compare that label across all facts in
@@ -49,7 +49,7 @@ export class FactSet {
             for (var j = 0; j < allAspects.length; j++) {
                 var labelMap = {};
                 for (var i = 0; i < facts.length; i++) {
-                    labelMap[allLabels[facts[i].id][j]] = true;
+                    labelMap[allLabels[facts[i].vuid][j]] = true;
                 }
 
                 var uniqueLabelsByLabel = {};
@@ -57,7 +57,7 @@ export class FactSet {
                     /* We have at least two different labels, so include this
                      * aspect in the label for all facts in the set */
                     for (var i = 0; i < facts.length; i++) {
-                        var fid = facts[i].id;
+                        var fid = facts[i].vuid;
                         var l = allLabels[fid][j];
                         var ul = uniqueLabels[fid] || [];
                         if (l !== null) {
@@ -79,7 +79,7 @@ export class FactSet {
              * of them */
             if (Object.keys(uniqueLabels).length < facts.length) {
                 for (var i = 0; i < facts.length; i++) {
-                    var fid = facts[i].id;
+                    var fid = facts[i].vuid;
                     var ul = uniqueLabels[fid] || [];
                     ul.unshift(allLabels[fid][0]);
                     uniqueLabels[fid] = ul;
@@ -87,11 +87,11 @@ export class FactSet {
             }
 
             this._items.filter((item) => item instanceof Footnote).forEach((fn) => {
-                uniqueLabels[fn.id] = [fn.title];
+                uniqueLabels[fn.vuid] = [fn.title];
             });
 
             this._minimallyUniqueLabels = uniqueLabels;
         }
-        return this._minimallyUniqueLabels[fact.id].join(", ");
+        return this._minimallyUniqueLabels[fact.vuid].join(", ");
     }
 }
diff --git a/iXBRLViewerPlugin/viewer/src/js/footnote.js b/iXBRLViewerPlugin/viewer/src/js/footnote.js
index e5371b2ec..f3994dc6e 100644
--- a/iXBRLViewerPlugin/viewer/src/js/footnote.js
+++ b/iXBRLViewerPlugin/viewer/src/js/footnote.js
@@ -2,7 +2,7 @@
 
 export class Footnote {
     constructor(report, footnoteId, title) {
-        this.id = footnoteId;
+        this.vuid = footnoteId;
         this.linkedFacts = [];
         this.title = title;
         this.ixNode = report.reportSet.getIXNodeForItemId(footnoteId);
diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index 7cfa41cd1..d4f8a1644 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -155,7 +155,6 @@ export class Inspector {
         if (match !== null) {
             const reportId = match[1] === "-" ? 0 : match[2];
             const id = viewerUniqueId(reportId, match[3]);
-            console.log(id);
             if (this._reportSet.getItemById(id) !== undefined) {
                 this.selectItem(id);
             }
@@ -186,7 +185,7 @@ export class Inspector {
         if (this._currentItem) {
             // Don't include report number for first report for compatibility
             // with legacy fragments
-            location.hash = "#f" + this._currentItem.id.replace(/^0-/,  "-");
+            location.hash = "#f" + this._currentItem.vuid.replace(/^0-/,  "-");
         }
         else {
             location.hash = "";
@@ -263,7 +262,7 @@ export class Inspector {
 
     factListRow(f) {
         const row = $('<div class="fact-list-item"></div>')
-            .click(() => this.selectItem(f.id))
+            .click(() => this.selectItem(f.vuid))
             .dblclick(() => $('#inspector').removeClass("search-mode"))
             .mousedown((e) => { 
                 /* Prevents text selection via double click without
@@ -276,10 +275,10 @@ export class Inspector {
             })
             .mouseenter(() => this._viewer.linkedHighlightFact(f))
             .mouseleave(() => this._viewer.clearLinkedHighlightFact(f))
-            .data('ivid', f.id);
+            .data('ivid', f.vuid);
         $('<div class="select-icon"></div>')
             .click(() => {
-                this.selectItem(f.id);
+                this.selectItem(f.vuid);
                 $('#inspector').removeClass("search-mode");
             })
             .appendTo(row)
@@ -574,7 +573,7 @@ export class Inspector {
             for (const group of this.outline.sortedSections()) {
                 $('<div class="fact-list-item"></div>')
                     .text(group.report.getRoleLabel(group.elr))
-                    .click(() => this.selectItem(group.fact.id))
+                    .click(() => this.selectItem(group.fact.vuid))
                     .dblclick(() => $('#inspector').removeClass("outline-mode"))
                     .mousedown((e) => {
                         // Prevent text selection by double click
@@ -592,7 +591,7 @@ export class Inspector {
         for (const group of this.outline.groupsForFact(cf)) {
             $('<div class="fact-list-item"></div>')
                 .text(cf.report.getRoleLabel(group.elr))
-                .click(() => this.selectItem(group.fact.id))
+                .click(() => this.selectItem(group.fact.vuid))
                 .appendTo($('.fact-groups'));
         }
 
@@ -705,7 +704,7 @@ export class Inspector {
                 if (r.facts) {
                     itemHTML.addClass("calc-fact-link");
                     itemHTML.data('ivids', Object.keys(r.facts));
-                    itemHTML.click(() => inspector.selectItem(Object.values(r.facts)[0].id));
+                    itemHTML.click(() => inspector.selectItem(Object.values(r.facts)[0].vuid));
                     itemHTML.mouseenter(() => Object.values(r.facts).forEach(f => this._viewer.linkedHighlightFact(f)));
                     itemHTML.mouseleave(() => Object.values(r.facts).forEach(f => this._viewer.clearLinkedHighlightFact(f)));
                     Object.values(r.facts).forEach(f => this._viewer.highlightRelatedFact(f));
@@ -731,7 +730,7 @@ export class Inspector {
                     .text(truncateLabel(fn.textContent(), 120))
                     .mouseenter(() => this._viewer.linkedHighlightFact(fn))
                     .mouseleave(() => this._viewer.clearLinkedHighlightFact(fn))
-                    .click(() => this.selectItem(fn.id))
+                    .click(() => this.selectItem(fn.vuid))
                     .appendTo(html);
             }
             else if (fn instanceof Fact) {
@@ -777,7 +776,7 @@ export class Inspector {
         if (factList.length > 0) {
             html
             .addClass("fact-link")
-            .click(() => this.selectItem(factList[0].id))
+            .click(() => this.selectItem(factList[0].vuid))
             .mouseenter(() => factList.forEach(f => this._viewer.linkedHighlightFact(f)))
             .mouseleave(() => factList.forEach(f => this._viewer.clearLinkedHighlightFact(f)));
         }
@@ -960,8 +959,8 @@ export class Inspector {
             a.addCard(
                 title,
                 factHTML, 
-                fact.id == cf.id,
-                fact.id
+                fact.vuid == cf.vuid,
+                fact.vuid
             );
         }
         return a;
@@ -994,19 +993,19 @@ export class Inspector {
                 this.updateAnchoring(cf);
                 $('div.references').empty().append(this._referencesHTML(cf));
                 $('#inspector .search-results .fact-list-item').removeClass('selected');
-                $('#inspector .search-results .fact-list-item').filter((i, e) => $(e).data('ivid') == cf.id).addClass('selected');
+                $('#inspector .search-results .fact-list-item').filter((i, e) => $(e).data('ivid') == cf.vuid).addClass('selected');
 
                 const duplicates = cf.duplicates();
                 let n = 0;
                 const ndup = duplicates.length;
                 for (var i = 0; i < ndup; i++) {
-                    if (cf.id == duplicates[i].id) {
+                    if (cf.vuid == duplicates[i].vuid) {
                         n = i;
                     }
                 }
                 $('.duplicates .text').text(i18next.t('factDetails.duplicatesCount', { current: n + 1, total: ndup}));
-                $('.duplicates .prev').off().click(() => this.selectItem(duplicates[(n+ndup-1) % ndup].id));
-                $('.duplicates .next').off().click(() => this.selectItem(duplicates[(n+1) % ndup].id));
+                $('.duplicates .prev').off().click(() => this.selectItem(duplicates[(n+ndup-1) % ndup].vuid));
+                $('.duplicates .next').off().click(() => this.selectItem(duplicates[(n+1) % ndup].vuid));
 
                 this.getPeriodIncrease(cf);
                 if (cf.isHidden()) {
diff --git a/iXBRLViewerPlugin/viewer/src/js/search.js b/iXBRLViewerPlugin/viewer/src/js/search.js
index f320a436c..f0ebf8c31 100644
--- a/iXBRLViewerPlugin/viewer/src/js/search.js
+++ b/iXBRLViewerPlugin/viewer/src/js/search.js
@@ -17,7 +17,7 @@ export class ReportSearch {
         this.periods = {};
         for (var i = 0; i < facts.length; i++) {
             var f = facts[i];
-            var doc = { "id": f.id };
+            var doc = { "id": f.vuid };
             var l = f.getLabel("std");
             doc.concept = f.conceptQName().localname;
             doc.doc = f.getLabel("doc");
diff --git a/iXBRLViewerPlugin/viewer/src/js/util.js b/iXBRLViewerPlugin/viewer/src/js/util.js
index e39760b95..878666e11 100644
--- a/iXBRLViewerPlugin/viewer/src/js/util.js
+++ b/iXBRLViewerPlugin/viewer/src/js/util.js
@@ -170,9 +170,13 @@ export function isTransparent(rgba) {
  * @return {String}   a viewer unique ID
  */
 
-export function viewerUniqueId(sourceReportIndex, id) {
-    if (id === null) {
+export function viewerUniqueId(sourceReportIndex, localId) {
+    if (localId === null) {
         return null;
     }
-    return sourceReportIndex.toString() + "-" + id;
+    return sourceReportIndex.toString() + "-" + localId;
+}
+
+export function localId(viewerUniqueId) {
+    return viewerUniqueId.replace(/^\d+-/,"");
 }
diff --git a/iXBRLViewerPlugin/viewer/src/js/viewer.js b/iXBRLViewerPlugin/viewer/src/js/viewer.js
index 4367e6408..917584470 100644
--- a/iXBRLViewerPlugin/viewer/src/js/viewer.js
+++ b/iXBRLViewerPlugin/viewer/src/js/viewer.js
@@ -499,7 +499,7 @@ export class Viewer {
     _selectAdjacentTag(offset, currentItem) {
         var nextId;
         if (currentItem !== null) {
-            nextId = this._docOrderItemIndex.getAdjacentItem(currentItem.id, offset);
+            nextId = this._docOrderItemIndex.getAdjacentItem(currentItem.vuid, offset);
             this.showDocumentForItemId(nextId);
         }
         // If no fact selected go to the first or last in the current document
@@ -682,12 +682,12 @@ export class Viewer {
     }
 
     highlightRelatedFact(f) {
-        this.changeItemClass(f.id, "ixbrl-related");
+        this.changeItemClass(f.vuid, "ixbrl-related");
     }
 
     highlightRelatedFacts(facts) {
         for (const f of facts) {
-            this.changeItemClass(f.id, "ixbrl-related");
+            this.changeItemClass(f.vuid, "ixbrl-related");
         }
     }
 
@@ -792,7 +792,7 @@ export class Viewer {
 
     factsInSameTable(fact) {
         var facts = [];
-        const e = this.elementsForItemId(fact.id);
+        const e = this.elementsForItemId(fact.vuid);
         e.closest("table").find(".ixbrl-element").each(function () {
             facts = facts.concat($(this).data('ivids'));
         });
@@ -800,11 +800,11 @@ export class Viewer {
     }
 
     linkedHighlightFact(f) {
-        this.changeItemClass(f.id, "ixbrl-linked-highlight");
+        this.changeItemClass(f.vuid, "ixbrl-linked-highlight");
     }
 
     clearLinkedHighlightFact(f) {
-        this.changeItemClass(f.id, "ixbrl-linked-highlight", true);
+        this.changeItemClass(f.vuid, "ixbrl-linked-highlight", true);
     }
 
     _setTitle(docIndex) {

From 74b457d8dbfca2392a4d42043c4ca83f1d7b5fdf Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Fri, 6 Oct 2023 22:06:56 +0100
Subject: [PATCH 26/32] Change approach to overriding keepOpen option (needed
 for more recent Arelle)

---
 iXBRLViewerPlugin/__init__.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/iXBRLViewerPlugin/__init__.py b/iXBRLViewerPlugin/__init__.py
index 30305c511..70eab7750 100644
--- a/iXBRLViewerPlugin/__init__.py
+++ b/iXBRLViewerPlugin/__init__.py
@@ -81,9 +81,11 @@ def iXBRLViewerCommandLineOptionExtender(parser, *args, **kwargs):
                       default=False,
                       dest="zipViewerOutput",
                       help="Converts the viewer output into a self contained zip")
+
     # Force "keepOpen" to true, so that all models are retained.  Needed for
     # multi-instance viewers.
-    parser.add_option("--keepOpen", dest="keepOpen", default=True, action="store_true", help=argparse.SUPPRESS)
+    next(o for o in parser.option_list if o.dest == 'keepOpen').default=True
+
     featureGroup = OptionGroup(parser, "Viewer Features",
                             "See viewer README for information on enabling/disabling features.")
     for featureConfig in FEATURE_CONFIGS:

From 8b9ba0b8986d04ae57fc886b02b46ae5a4b16b98 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Fri, 6 Oct 2023 22:08:45 +0100
Subject: [PATCH 27/32] Rename "dts" to "logger_model"

---
 iXBRLViewerPlugin/iXBRLViewer.py | 40 ++++++++++++++++++--------------
 1 file changed, 22 insertions(+), 18 deletions(-)

diff --git a/iXBRLViewerPlugin/iXBRLViewer.py b/iXBRLViewerPlugin/iXBRLViewer.py
index 353c70290..9a2b1c090 100644
--- a/iXBRLViewerPlugin/iXBRLViewer.py
+++ b/iXBRLViewerPlugin/iXBRLViewer.py
@@ -86,6 +86,8 @@ def __init__(self, reports: List[ModelXbrl], basenameSuffix: str = ''):
         self.nsmap = NamespaceMap()
         self.roleMap = NamespaceMap()
         self.reports = reports
+        # Arbitrary ModelXbrl used for logging
+        self.logger_model = reports[0]
         self.taxonomyData = {
             "sourceReports": [],
             "features": [],
@@ -234,7 +236,7 @@ def getRelationships(self, report: ModelXbrl):
         return rels
 
     def validationErrors(self):
-        logHandler = self.reports[0].modelManager.cntlr.logHandler
+        logHandler = self.logger_model.modelManager.cntlr.logHandler
         if getattr(logHandler, "logRecordBuffer") is None:
             raise IXBRLViewerBuilderError("Logging is not configured to use a buffer.  Unable to retrieve validation messages")
 
@@ -352,7 +354,7 @@ def addViewerToXMLDocument(self, xmlDocument, scriptUrl):
             if child.tag == '{http://www.w3.org/1999/xhtml}body':
                 for body_child in child:
                     if body_child.tag == '{http://www.w3.org/1999/xhtml}script' and body_child.get('type','') == 'application/x.ixbrl-viewer+json':
-                        self.dts.error("viewer:error", "File already contains iXBRL viewer")
+                        self.logger_model.error("viewer:error", "File already contains iXBRL viewer")
                         return False
 
                 child.append(etree.Comment("BEGIN IXBRL VIEWER EXTENSIONS"))
@@ -516,10 +518,12 @@ def __init__(self, filename, xmlDocument):
 
 class iXBRLViewer:
 
-    def __init__(self, dts):
+    def __init__(self, logger_model: ModelXbrl):
         self.files = []
         self.filingDocuments = None
-        self.dts = dts
+        # This is an arbitrary ModelXbrl used for logging only
+        self.logger_model = logger_model
+
     def addFile(self, ivf):
         self.files.append(ivf)
 
@@ -544,15 +548,15 @@ def save(self, destination: Union[io.BytesIO, str], zipOutput: bool = False, cop
                 fileMode = 'w'
             elif destination.endswith(os.sep):
                 # Looks like a directory, but isn't one
-                self.dts.error("viewer:error", "Directory %s does not exist" % destination)
+                self.logger_model.error("viewer:error", "Directory %s does not exist" % destination)
                 return
             elif not os.path.isdir(os.path.dirname(os.path.abspath(destination))):
                 # Directory part of filename doesn't exist
-                self.dts.error("viewer:error", "Directory %s does not exist" % os.path.dirname(os.path.abspath(destination)))
+                self.logger_model.error("viewer:error", "Directory %s does not exist" % os.path.dirname(os.path.abspath(destination)))
                 return
             elif not destination.endswith('.zip'):
                 # File extension isn't a zip
-                self.dts.error("viewer:error", "File extension %s is not a zip" % os.path.splitext(destination)[0])
+                self.logger_model.error("viewer:error", "File extension %s is not a zip" % os.path.splitext(destination)[0])
                 return
             else:
                 file = destination
@@ -560,50 +564,50 @@ def save(self, destination: Union[io.BytesIO, str], zipOutput: bool = False, cop
 
             with zipfile.ZipFile(file, fileMode, zipfile.ZIP_DEFLATED, True) as zout:
                 for f in self.files:
-                    self.dts.info("viewer:info", "Saving in output zip %s" % f.filename)
+                    self.logger_model.info("viewer:info", "Saving in output zip %s" % f.filename)
                     with zout.open(f.filename, "w") as fout:
                         writer = XHTMLSerializer(fout)
                         writer.serialize(f.xmlDocument)
                 if self.filingDocuments:
                     filename = os.path.basename(self.filingDocuments)
-                    self.dts.info("viewer:info", "Writing %s" % filename)
+                    self.logger_model.info("viewer:info", "Writing %s" % filename)
                     zout.write(self.filingDocuments, filename)
                 if copyScriptPath is not None:
                     scriptSrc = os.path.join(destination, copyScriptPath)
-                    self.dts.info("viewer:info", "Writing script from %s" % scriptSrc)
+                    self.logger_model.info("viewer:info", "Writing script from %s" % scriptSrc)
                     zout.write(scriptSrc, os.path.basename(copyScriptPath))
         elif os.path.isdir(destination):
             # If output is a directory, write each file in the doc set to that
             # directory using its existing filename
             for f in self.files:
                 filename = os.path.join(destination, f.filename)
-                self.dts.info("viewer:info", "Writing %s" % filename)
+                self.logger_model.info("viewer:info", "Writing %s" % filename)
                 with open(filename, "wb") as fout:
                     writer = XHTMLSerializer(fout)
                     writer.serialize(f.xmlDocument)
             if self.filingDocuments:
                 filename = os.path.basename(self.filingDocuments)
-                self.dts.info("viewer:info", "Writing %s" % filename)
+                self.logger_model.info("viewer:info", "Writing %s" % filename)
                 shutil.copy2(self.filingDocuments, os.path.join(destination, filename))
             if copyScriptPath is not None:
                 self._copyScript(destination, copyScriptPath)
         else:
             if len(self.files) > 1:
-                self.dts.error("viewer:error", "More than one file in input, but output is not a directory")
+                self.logger_model.error("viewer:error", "More than one file in input, but output is not a directory")
             elif destination.endswith(os.sep):
                 # Looks like a directory, but isn't one
-                self.dts.error("viewer:error", "Directory %s does not exist" % destination)
+                self.logger_model.error("viewer:error", "Directory %s does not exist" % destination)
             elif not os.path.isdir(os.path.dirname(os.path.abspath(destination))):
                 # Directory part of filename doesn't exist
-                self.dts.error("viewer:error", "Directory %s does not exist" % os.path.dirname(os.path.abspath(destination)))
+                self.logger_model.error("viewer:error", "Directory %s does not exist" % os.path.dirname(os.path.abspath(destination)))
             else:
-                self.dts.info("viewer:info", "Writing %s" % destination)
+                self.logger_model.info("viewer:info", "Writing %s" % destination)
                 with open(destination, "wb") as fout:
                     writer = XHTMLSerializer(fout)
                     writer.serialize(self.files[0].xmlDocument)
                 if self.filingDocuments:
                     filename = os.path.basename(self.filingDocuments)
-                    self.dts.info("viewer:info", "Writing %s" % filename)
+                    self.logger_model.info("viewer:info", "Writing %s" % filename)
                     shutil.copy2(self.filingDocuments, os.path.join(os.path.dirname(destination), filename))
                 if copyScriptPath is not None:
                     outDirectory = os.path.dirname(os.path.join(os.getcwd(), destination))
@@ -612,5 +616,5 @@ def save(self, destination: Union[io.BytesIO, str], zipOutput: bool = False, cop
     def _copyScript(self, directory: str, scriptPath: str):
         scriptSrc = os.path.join(directory, scriptPath)
         scriptDest = os.path.join(directory, os.path.basename(scriptPath))
-        self.dts.info("viewer:info", "Copying script from %s to %s" % (scriptSrc, scriptDest))
+        self.logger_model.info("viewer:info", "Copying script from %s to %s" % (scriptSrc, scriptDest))
         shutil.copy2(scriptSrc, scriptDest)

From a5bded1bd6df40bfc79b08f5538151980b2ecc6c Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Fri, 6 Oct 2023 22:18:06 +0100
Subject: [PATCH 28/32] Simplify fact deep link.

---
 iXBRLViewerPlugin/viewer/src/js/inspector.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index d4f8a1644..4c8eeb0db 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -148,13 +148,14 @@ export class Inspector {
      *
      * Legacy format: #f-FACT_ID
      * New format: #fN-FACT_ID where N is report index
+     * For N == 0, we use the legacy format.
      *
      */
     handleFactDeepLink() {
-        const match = location.hash.match(/^#f(-|([0-9]+)-)(.*)$/);
+        const match = location.hash.match(/^#f([0-9]+)?-(.*)$/);
         if (match !== null) {
-            const reportId = match[1] === "-" ? 0 : match[2];
-            const id = viewerUniqueId(reportId, match[3]);
+            const reportId = match[1] ?? 0;
+            const id = viewerUniqueId(reportId, match[2]);
             if (this._reportSet.getItemById(id) !== undefined) {
                 this.selectItem(id);
             }

From afede45e82f53713262cf35fb7b8dc082f96c23b Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 9 Oct 2023 19:36:30 +0100
Subject: [PATCH 29/32] Fix localId().

---
 iXBRLViewerPlugin/viewer/src/js/fact.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/fact.js b/iXBRLViewerPlugin/viewer/src/js/fact.js
index d52b74109..e9d439a57 100644
--- a/iXBRLViewerPlugin/viewer/src/js/fact.js
+++ b/iXBRLViewerPlugin/viewer/src/js/fact.js
@@ -19,7 +19,7 @@ export class Fact {
     }
 
     localId() {
-        localId(this.vuid);
+        return localId(this.vuid);
     }
 
     getLabel(rolePrefix, withPrefix) {

From 46886af5b885bcfe26bb7859e0df858b09b28419 Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 9 Oct 2023 19:39:14 +0100
Subject: [PATCH 30/32] Fix tests.

---
 tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py b/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
index 1b129048b..98b6d2da6 100644
--- a/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
+++ b/tests/unit_tests/iXBRLViewerPlugin/test_iXBRLViewer.py
@@ -457,7 +457,7 @@ def test_addConcept_simple_case(self):
     @patch('arelle.XbrlConst.summationItem', 'http://www.xbrl.org/2003/arcrole/summation-item')
     def test_getRelationships_simple_case(self):
         modelXbrl = Mock(baseSets=defaultdict(list), relationshipSets={})
-        builder = IXBRLViewerBuilder(modelXbrl)
+        builder = IXBRLViewerBuilder([modelXbrl])
         result = builder.getRelationships(modelXbrl)
         self.assertDictEqual(result, {})
 

From e9f066a4818f8696516ebccdce17e8adb753455c Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Mon, 9 Oct 2023 21:12:48 +0100
Subject: [PATCH 31/32] Fix approach to setting "keepOpen"

---
 iXBRLViewerPlugin/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iXBRLViewerPlugin/__init__.py b/iXBRLViewerPlugin/__init__.py
index 70eab7750..baf330d4d 100644
--- a/iXBRLViewerPlugin/__init__.py
+++ b/iXBRLViewerPlugin/__init__.py
@@ -84,7 +84,7 @@ def iXBRLViewerCommandLineOptionExtender(parser, *args, **kwargs):
 
     # Force "keepOpen" to true, so that all models are retained.  Needed for
     # multi-instance viewers.
-    next(o for o in parser.option_list if o.dest == 'keepOpen').default=True
+    parser.set_defaults(keepOpen = True)
 
     featureGroup = OptionGroup(parser, "Viewer Features",
                             "See viewer README for information on enabling/disabling features.")

From 5296e738f68935d95f43409e0ccde753a0aba99d Mon Sep 17 00:00:00 2001
From: Paul Warren <pdw@ex-parrot.com>
Date: Wed, 11 Oct 2023 20:41:47 +0100
Subject: [PATCH 32/32] Rename getUsedPrefixes

---
 iXBRLViewerPlugin/viewer/src/js/inspector.js   | 2 +-
 iXBRLViewerPlugin/viewer/src/js/reportset.js   | 2 +-
 iXBRLViewerPlugin/viewer/src/js/search.test.js | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/iXBRLViewerPlugin/viewer/src/js/inspector.js b/iXBRLViewerPlugin/viewer/src/js/inspector.js
index 4c8eeb0db..e9913f137 100644
--- a/iXBRLViewerPlugin/viewer/src/js/inspector.js
+++ b/iXBRLViewerPlugin/viewer/src/js/inspector.js
@@ -355,7 +355,7 @@ export class Inspector {
                 .text(this._search.periods[key])
                 .appendTo('#search-filter-period select');
         }
-        for (const prefix of this._reportSet.getUsedPrefixes()) {
+        for (const prefix of this._reportSet.getUsedConceptPrefixes()) {
             $("<option>")
                 .attr("value", prefix)
                 .text(`${prefix} (${this._reportSet.prefixMap()[prefix]})`)
diff --git a/iXBRLViewerPlugin/viewer/src/js/reportset.js b/iXBRLViewerPlugin/viewer/src/js/reportset.js
index 229e1157c..fc5680cbb 100644
--- a/iXBRLViewerPlugin/viewer/src/js/reportset.js
+++ b/iXBRLViewerPlugin/viewer/src/js/reportset.js
@@ -110,7 +110,7 @@ export class ReportSet {
         return prefixes;
     }
 
-    getUsedPrefixes() {
+    getUsedConceptPrefixes() {
         if (this._usedPrefixes === undefined) {
             this._usedPrefixes = new Set(Object.values(this._items)
                     .filter(f => f instanceof Fact)
diff --git a/iXBRLViewerPlugin/viewer/src/js/search.test.js b/iXBRLViewerPlugin/viewer/src/js/search.test.js
index 34c56e791..129a40fab 100644
--- a/iXBRLViewerPlugin/viewer/src/js/search.test.js
+++ b/iXBRLViewerPlugin/viewer/src/js/search.test.js
@@ -247,7 +247,7 @@ describe("Search namespaces filter", () => {
     const reportSearch = getReportSearch(report)
 
     test("Namespaces filter only shows used prefixes", () => {
-        const prefixes = Array.from(report.getUsedPrefixes()).sort();
+        const prefixes = Array.from(report.getUsedConceptPrefixes()).sort();
         expect(prefixes).toEqual(['a', 'b', 'c']);
     });
 
@@ -274,7 +274,7 @@ describe("Search namespaces filter", () => {
 
     test("Namespaces filter works with all selections", () => {
         const spec1 = testSearchSpec();
-        spec1.namespacesFilter = Array.from(report.getUsedPrefixes());
+        spec1.namespacesFilter = Array.from(report.getUsedConceptPrefixes());
         const results1 = reportSearch.search(spec1).map(r => r.fact.localId()).sort();
         const spec2 = testSearchSpec();
         spec2.namespacesFilter = [];