Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message timestamps and order by newest #1

Open
samcamwilliams opened this issue Apr 12, 2019 · 15 comments
Open

Add message timestamps and order by newest #1

samcamwilliams opened this issue Apr 12, 2019 · 15 comments
Labels
enhancement New feature or request gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue.

Comments

@samcamwilliams
Copy link
Contributor

samcamwilliams commented Apr 12, 2019

We need to add a tag to each of the mail transactions with the current Unix timestamp at the moment of signing, then order the messages on the inbox screen by these timestamps.

The transaction creation code, where the timestamp tag needs to be added, can be found here.

The inbox rendering code, where the txs need to be ordered, can be found here.

@samcamwilliams samcamwilliams added enhancement New feature or request gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue. labels Apr 12, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.609 ETH (100.04 USD @ $164.27/ETH) attached to it as part of the ArweaveTeam fund.

@gitcoinbot
Copy link

gitcoinbot commented Apr 12, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 11 months from now.
Please review their action plans below:

1) jong86 has applied to start work (Funders only: approve worker | reject worker).

-clone the repo
-add code that tags mail txs with UNIX timestamps when they are signed
-add code that orders the inbox messages by timestamp

Learn more on the Gitcoin Issue Details page.

2) rafagwy has applied to start work (Funders only: approve worker | reject worker).

I am interested in doing this, but your transaction code URL is invalid.

Learn more on the Gitcoin Issue Details page.

3) codi45 has been approved to start work.

I add a Unixtimestamp in compose.js.
then i sort the inbox messages using the timestamp.
Tested OK.

Learn more on the Gitcoin Issue Details page.

@codi45
Copy link
Contributor

codi45 commented Apr 12, 2019

Hi is there an test adr to test solution?
Also in how would like to order the msgs?
Is it possible to use another array to sort them?

@ldmberman
Copy link
Member

@codi45 you can create one or more wallets using our Web Extension. You would also need to get a wallet with some free tokens to be able to send messages, check README for more details.

Also in how would like to order the msgs?

Are you asking about ascending vs descending? Makes sense to have the newest messages on top.

Is it possible to use another array to sort them?

Sure.

@codi45
Copy link
Contributor

codi45 commented Apr 17, 2019

@ldmberman I can provide a PR and then we see from there. Mails are ordered by timestamps.

@samcamwilliams
Copy link
Contributor Author

Hey @codi45 ,

Thanks for sending a PR! Unfortunately, we are having a problem with Gitcoin at the moment and cannot officially accept the work request. We are in contact with the Gitcoin founders, so hopefully we should be able to get this sorted quickly. Worst case, if you send us an Ethereum address we can send you the tokens directly :).

For now, I will leave it to @ldmberman to review the patch.

All the best,
Sam

@vs77bb
Copy link

vs77bb commented Apr 18, 2019

Hi @codi45 - V from Gitcoin here, just approved you for work. You can make a submission against this bounty now, whenever, which can be paid out after review 🙂

@codi45
Copy link
Contributor

codi45 commented Apr 18, 2019

hi @vs77bb Thanks i will submit @samcamwilliams Thanks

@ldmberman
Copy link
Member

Done - #7.

@gitcoinbot
Copy link

gitcoinbot commented Apr 22, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.609 ETH (104.32 USD @ $171.3/ETH) has been submitted by:

  1. @codi45

@samcamwilliams please take a look at the submitted work:


@gitcoinbot
Copy link

Relase Early And Often ⚡️ A *Relase Early And Often* Kudos has been sent to @codi45 for this issue from @samcamwilliams. ⚡️

The sender had the following public comments:

Thanks!

Nice work @codi45!
Your Kudos has automatically been sent in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.609 ETH (106.05 USD @ $174.15/ETH) attached to this issue has been approved & issued to @codi45.

@codi45
Copy link
Contributor

codi45 commented May 2, 2019

@samcamwilliams Thanks for kudo

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@codi45 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


@codi45 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gitcoin-bounty A bounty (in ETH) is available on gitcoin.co for fixing this issue.
Projects
None yet
Development

No branches or pull requests

5 participants