Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See who is working to prevent collisions #4

Open
GenieTim opened this issue Aug 27, 2019 · 4 comments
Open

See who is working to prevent collisions #4

GenieTim opened this issue Aug 27, 2019 · 4 comments
Labels
nice to have This will be worked on only if there is time

Comments

@GenieTim
Copy link

Prevent multiple people to work on the same file.

@GenieTim GenieTim added the nice to have This will be worked on only if there is time label Aug 27, 2019
@greeffm
Copy link
Collaborator

greeffm commented Aug 28, 2019

This is a test comment

@EntomologicalZivi
Copy link

dazu sagen wir nicht nein ;)

@GenieTim
Copy link
Author

GenieTim commented Jan 27, 2021

There are multiple ways to achieve this, of various difficulty and sensibility.
The first distinction to make is:

  1. Do the users get informed of the open specimen of someone else when opening a specimen themselfs...
  2. ...when trying to edit a field...
  3. ...or when saving changes?

The first idea might be annoying if all you want to do is check, open or look at the specimen. Additionally, technologically, it is much more difficult as it either needs a pessimistic lock on the database entry (with the additional disadvantage that this lock needs to be released; how to do that if the app crashes etc.) or some form of network communication between the DataShot instances, which in turn is not the safe choice in terms of security. Additional questions would arise, what to do e.g. when a user goes to eat lunch with a specimen still open.

The third approach is easier. But it also brings new questions:

a. should the changes of the first one to press save be successful and the others gets an error message and need to restart editing?
b. should the changes of the first one to press save be successful and the others be informed of the changes in order to overwrite, merge or cancel their changes?

@yvessavoy
Copy link

I understand the concerns and we think we close this issue for now. We will coordinate on who is doing which species and we think this should solve the problem for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have This will be worked on only if there is time
Projects
None yet
Development

No branches or pull requests

4 participants