Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'compress=NA' in AtomicList constructors #48

Open
hpages opened this issue Apr 19, 2023 · 0 comments
Open

Support 'compress=NA' in AtomicList constructors #48

hpages opened this issue Apr 19, 2023 · 0 comments
Assignees

Comments

@hpages
Copy link
Contributor

hpages commented Apr 19, 2023

It would do compress=TRUE if the input is not too big, otherwise it would fallback to compress=FALSE. For example:

RleList(Rle(8, 2e9), Rle(5, 200), compress=NA)

would do RleList(Rle(8, 2e9), Rle(5, 200), compress=TRUE) i.e. return a CompressedRleList object.

But:

RleList(Rle(8, 2e9), Rle(5, 2e9), compress=NA)

would do RleList(Rle(8, 2e9), Rle(5, 2e9), compress=FALSE) i.e. return a SimpleRleList object.

Then compress=NA should probably be made the new default (right now it's compress=TRUE, which is problematic because it fails when the input is too big).

See Bioconductor/VariantAnnotation#71 (comment) for some background.

@hpages hpages self-assigned this Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant