Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few suggestions #35

Open
sodiumchl opened this issue Sep 23, 2020 · 1 comment
Open

A few suggestions #35

sodiumchl opened this issue Sep 23, 2020 · 1 comment

Comments

@sodiumchl
Copy link

Thanks for the script!

Here are a few suggestions:
1> /dev/null should be > /dev/null
Otherwise, there is an error when running on MacOS.

Include correct email in key. Add the following in createKey():
KNAME=$(basename $KEY)
grep -q '@' <<< $KNAME || KNAME=$KNAME@$HOSTNAME
KEYEMAIL="-C $KNAME"

    COMMAND="$COMMAND $TYPE $BITS $KEYEMAIL $OUTPUT_DIR $PASS"
@BrendanThompson
Copy link
Owner

@sodiumchl thanks for the feedback mate! Feel free to submit a PR on this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants