Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gst pipeline node as a composable node #57

Open
rawnam opened this issue Oct 2, 2023 · 2 comments
Open

gst pipeline node as a composable node #57

rawnam opened this issue Oct 2, 2023 · 2 comments

Comments

@rawnam
Copy link

rawnam commented Oct 2, 2023

Hi,

I was wondering if it would be possible to run the pipeline node as a composable node which can then be composed within a multi-threaded executor. Would it be possible to do so? How could we go about it? Will it be possible to move the pointers from the ros-image-sink element to any downstream application?

Do we need to compose the pipeline node for this?

Would love to hear some thoughts on this.

Thanks

@BrettRD
Copy link
Owner

BrettRD commented Oct 3, 2023

Hi,

Take a look at the feature/param_plugin branch

Node composition wasn't possible under rclpy, so I re-wrote the pipeline handler in C++, and added tools to pass external node-interfaces into the bridge plugins, so that the bridge plugins create their publishers and subscribers on the pipeline-node's node interfaces.

In theory, this allows the bridge elements to operate as a composable node by piggybacking on the new C++ pipeline-node. I don't yet have tests for it, so there's a chance the multi-threaded executor might break it.

I'm expecting to properly release this feature branch by the end of the year and fully deprecate the python node, I'd love to hear if it works for you or what breaks when you try it.

Cheers

@BrettRD
Copy link
Owner

BrettRD commented Mar 17, 2024

update: this is now on the develop branch, fully functional, but still waiting on a proper shake-down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants