Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gonna refactor setsave(), it doesn't need to modify global instance #3

Open
tactu1 opened this issue Feb 28, 2022 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@tactu1
Copy link
Collaborator

tactu1 commented Feb 28, 2022

Part of refactoring to separate UI code from logic, first road block is the set save function.
I'm going to have it returning the lists that it needs (currently)
global VarSmodules
global DoubleModules
global VarPistols

as a list of lists
and then you can set the output of the function to a variable and then assign them. This will let you declare those lists in a better spot and it will let us create a unit test for the function.

@tactu1 tactu1 added the enhancement New feature or request label Feb 28, 2022
@tactu1 tactu1 self-assigned this Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant