-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Improve Add Dialog #384
Comments
do we really need this change? please confirm it, so that i will start working on it |
@D-extremity , I have assigned it to you. PS. |
#410 Link this as well |
@D-extremity keep the changes of this PR #399 |
@D-extremity maybe even consider #414 ? |
Okay okay i will do consider those PR and issues |
Hey @D-extremity , |
Here's another rough mockup of a new and improved Add Dialog, hope you like it. I'm sure the colors and fonts and outlines and rounded corners above are not yet following the theme, but that's okay, tweak away! What I like about this layout is;
Thanks for considering all this @SGI-CAPP-AT2 , have fun with it! |
ok @linuxcaffe, let me work on this with following notes
|
@linuxcaffe I am really happy that I could contribute.. It would be great if you merge the PR |
@SGI-CAPP-AT2 yeah, looks good! @arjav1528 that's great! .. but I don't think I have auth to actually merge stuff ;-) |
Storing the previously used tags in something like SharedPreferences, or a simple SQFlite DB would be easy to implement for tags |
Yep, at first I was thinking about chips but the problem with chips is
But if we show as in filter sidebar, the problem is height of the dialogue
there's already a method to get previous tags which is used for filters |
Assuming we are also implementing similar UI for TW3.0/CCSync, and as adding/editing Tags are not a feature in that yet. Maybe you can try implementing separate storage of task tags in the same DB, for 3.0 /CCSync (other than the method mentioned by you for 2.0), as the CCSync integration generally works on SQFlite only, that would keep things separate, and we can then update the data models in the API as well as the Filter Drawer similarly, for 3.0/CCSync. |
I'm not suggesting separate set of "previously used tags" I'm talking about the existing tags in the user's current data set. Just like entering "task tags" at the taskwarrior CLI. No extra storage required. |
I agree that showing a set of chips without affecting the height of the dialog is a challenge, but I think it's worth attempting. In my last mock-up I limit the chip space to 3 closely packed lines, and if the user has more than that, perhaps the bottom chips are could allow scrolling to show the rest?
Seperate DB for tags is (IMHO) not required, a bad idea, don't do it! ;-)
The advantage of showing a set of tag chips, especially if sorted by most-used-first (ie. most-numerous-in-the-user's-current-data-set) is the ability to select common tags with a single click, and that the user doesn't have to remember them all before typing tag names. |
Hey @SGI-CAPP-AT2 , you're right, tag chips integrated at the bottom of the dialog is problematic. Here's an idea for a compromise, maybe best of both worlds!? So text autocomplete, yes! and a dropdown option? Instead of a vertical list, which could be too long, a chip box! Ideal for those tags you should have assigned, but almost forgot! |
Hey I found this solution, |
@SGI-CAPP-AT2 that looks like just the thing! Good find! I'm thinking the chip box can be as big as needed, but the bottom edge should connected to the top edge of tag input field, sort of like the mock-up above? |
@arjav1528 not too duplicate effort, this looks good for the #421 tag chip box too? Slightly different layout, very similar behavior, same Library? |
@linuxcaffe yep, looks great, will surely checkout |
Hey @linuxcaffe, AddTaskDialogChanges.mp4 |
Hey! Just add a project field, and that looks usable! |
Oh I forgot project field |
Describe your improvement idea or feature request
Improve and extend Add Task Dialog
How would you like to see it implemented?
(see screenshot)
Put here any screenshots or videos (optional)
How can we contact you (optional)
No response
Would you like to work on this issue?
None
By submitting this issue, I have confirmed that:
The text was updated successfully, but these errors were encountered: