Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FireFox extension scrolls to the top whenever you click a control color picker or toggle #59

Open
martynchamberlin opened this issue Dec 7, 2016 · 2 comments
Open

FireFox extension scrolls to the top whenever you click a control color picker or toggle #59

martynchamberlin opened this issue Dec 7, 2016 · 2 comments

Comments

@martynchamberlin
Copy link
Member

Super annoying. Wish I knew what the trouble was. Can't help but think we need an event.preventDefault() or something.
@martynchamberlin
Copy link
Member Author

Actually. If I had to guess what's going on here, it might be the fact that the click is triggering a setState, which is in turn triggering a DOM refresh. For a fraction of a second, the DOM height gets really short while it is getting refreshed, which removes the need for the vertical scrollbar, and then once the new DOM is inserted, you aren't re-scrolled to where you were.

@emilgoldsmith
Copy link
Contributor

#71 could maybe fix this as well if we're lucky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martynchamberlin @emilgoldsmith