Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug: eslint not configured for typescript #412

Open
1 task done
adityanandanx opened this issue Jan 20, 2025 · 3 comments · May be fixed by #416
Open
1 task done

🐞 Bug: eslint not configured for typescript #412

adityanandanx opened this issue Jan 20, 2025 · 3 comments · May be fixed by #416
Assignees
Labels
🐞 bug Something isn't working

Comments

@adityanandanx
Copy link

adityanandanx commented Jan 20, 2025

Is there an existing issue for this?

  • I have searched the existing issues.

Describe the bug

Image

Image

  • Various eslint errors while using typescript

Steps to Reproduce

  1. Setup the project using the installation guide in the readme
  2. temporarily change the lint script in package.json to not write any changes and to include typescript files -
    "lint": "eslint --ext .js,.vue,.ts --ignore-path .gitignore --no-fix src",
    
  3. run npm run lint
  4. see many problems
    Image

Expected Behavior

Ideally, no eslint errors. But since this can be a really big change, we can atleast start by letting eslint know that there will be typescript code in the project by using the eslint-typescript plugin.

Screenshots

Image

Is the faced issue/bug related to the Vue simulator?

Yes

Used Vue simulator with or without backend?

Without Backend

Is the bug present only on the dev server, the build, or both?

Dev Server Only

Device Information

OS: Arch Linux
Browser: Chrome
Version: 130.0.6723.91 (Official Build) (64-bit)

Additional Context

My first approach to solve this issue would be to add the eslint-typescript plugin to allow eslint to recognize typescript. There's also some globalVariables involved so there must be a global declaration file global.d.ts which declares the types for the appropriate global variables. I don't know what is the status of adopting typescript in this project is, but things seem to be all over the place with variables with any declarations and js being used at various places. This issue may just be redundant as this may be something which goes rather deep, but I can atleast start clearing the top of the rabbithole and do my part. Thanks

Are you working on this issue?

Yes

@adityanandanx adityanandanx added pending triage issue yet to be reviewed by maintainers 🐞 bug Something isn't working labels Jan 20, 2025
@adityanandanx
Copy link
Author

I would really like a confirmation before I start working on this as I stated before, this issue may just be redundant. 😄
Thanks

@niladrix719
Copy link
Member

Hi @adityanandanx I am assigning you, go for it

@niladrix719 niladrix719 removed the pending triage issue yet to be reviewed by maintainers label Jan 21, 2025
@adityanandanx
Copy link
Author

Hey @niladrix719
I just opened a PR. Let me know if anything seems out of place. I'll be more than happy to go back and forth till our requirements are met. 😄
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants