Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

YouTube handler debt #150

Closed
sr229 opened this issue Jan 5, 2018 · 4 comments
Closed

YouTube handler debt #150

sr229 opened this issue Jan 5, 2018 · 4 comments
Labels
bug Critical
Milestone
0.4.2

Comments

@sr229
Copy link
Contributor

sr229 commented Jan 5, 2018

apparently the YT handler can be related to #74 since its the only handler that makes the bot stream drop or jump.
@sr229 sr229 added this to the 0.4.2 milestone Jan 5, 2018
@sr229 sr229 mentioned this issue Jan 14, 2018
Closed
@Ovyerus Ovyerus self-assigned this Feb 7, 2018
@Ovyerus
Copy link
Contributor

Ovyerus commented Feb 7, 2018

This could potentially be related to abalabahaha/eris#213, as we're using ytdl for YouTube, however that issue relates to streams, and this issue has persisted through to us caching music streams to files. Perhaps trying to cache a M4A + AAC stream instead of a WebM + Opus stream could fix the issue?

@sr229
Copy link
Contributor Author

sr229 commented Feb 7, 2018

@Ovyerus since I've noticed SoundCloud caching are basically MP3 files, this would be more fficient than a native WebM + Opus stream

@sr229
Copy link
Contributor Author

sr229 commented Feb 7, 2018

Which I mean in context, is M4A + AAC

@sr229
Copy link
Contributor Author

sr229 commented Feb 17, 2018

YouTube Handler debt complete

@sr229 sr229 closed this as completed Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Critical
Projects
None yet
Milestone
0.4.2
Development

No branches or pull requests
2 participants
@sr229 @Ovyerus