Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent values parsing #58

Open
sl4vr opened this issue May 19, 2020 · 0 comments
Open

Consistent values parsing #58

sl4vr opened this issue May 19, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@sl4vr
Copy link
Contributor

sl4vr commented May 19, 2020

There is inconsistency now:

  • values from yaml files are parsed into sage types, e.g. str, int, bool
  • values from cli arguments and env variables are always str and require type cast.

AFAICS config parsers usually use strings and cast values when they are fetched from config, e.g. configparser, confuse.

But k8t could handle values from cli arguments and env variables same way as it's done with the ones from yaml files.

@sl4vr sl4vr added the invalid This doesn't seem right label May 19, 2020
@AFriemann AFriemann added enhancement New feature or request and removed invalid This doesn't seem right labels Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants