Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigReader: merge multiple lists of targets together? #53

Open
jonathanmaw opened this issue Mar 8, 2023 · 0 comments
Open

ConfigReader: merge multiple lists of targets together? #53

jonathanmaw opened this issue Mar 8, 2023 · 0 comments
Labels
question Further information is requested

Comments

@jonathanmaw
Copy link
Contributor

We are able to load a directory full of .yml files for Lifecycle's config.

Lifecycle supports listing multiple targets and having them all update at once from a single source.

The config format supports this, by expecting:

source:
  module: ...
  ...
targets:
  - module: ...
    ...
  - module: ...
    ...

However, because ConfigReader uses dict.update() to merge config from previous files, lists of targets overwrite each other.
This means you can't have different targets as separate config files, e.g. a directory containing source.yml, target1.yml, target2.yml
Do we want to explicitly merge these lists together?
Do we want to drop support for using multiple targets at once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant