Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve anchors in path destination parameter #11

Open
alisonjo315 opened this issue May 2, 2023 · 1 comment
Open

Preserve anchors in path destination parameter #11

alisonjo315 opened this issue May 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@alisonjo315
Copy link
Contributor

alisonjo315 commented May 2, 2023

Go here:
https://fcs.cornell.edu/projects/design-standards-details/design-standards-details#test

Note that the login button URL destination parameters do not have #test in them. (If you feel like it, go through the motions: use the login buttons to log in -- you'll find yourself on the correct page, but without the #test anchor.)

Research Services requested to have the anchor link preserved in login links like these, and I agree, that'd be great!

@alisonjo315 alisonjo315 added the enhancement New feature or request label May 2, 2023
@alisonjo315
Copy link
Contributor Author

alisonjo315 commented May 3, 2023

Dang, so far what I'm reading on The Internet is that the # part of the URL is never sent to the server, so we can't access it with PHP / it's not available when you GET your current path, via PHP.

(I went part-way down a "Symfony things with the word Fragment in them" rabbit hole (just by typing random things into my IDE to see if there were suggestions that seemed promising -- FragmentListener sounded so nice!!) but I managed to stop so I can ask fancy PHP devs before proceeding.)

So, fancy PHP devs: Does what I'm saying sound right to y'all, or no? (I hope not, I hope I'm missing / misunderstanding something!)

Some links:


(If my "findings" are accurate, I guess I might have to pursue a JavaScript solution, for the customer request I'm handling right now -- but, hopefully I'm missing/misunderstanding something 🤞)

Thing is, even if you go directly to a static/hard-coded link like this, simplesamlphp makes you lose the anchor link anyway -- probably because the fragment isn't sent to the server, and simplesamlphp can't do anything about it any more than I can...

@alisonjo315 alisonjo315 transferred this issue from CornellCustomDev/cwd_custom403 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant