Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial number translation file for ideal camera #5695

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

AustinSanders
Copy link
Contributor

Description

Adds a serial number translation file for the ideal camera.

Related Issue

Fixes #5662

How Has This Been Validated?

 >> getsn from= noproj.cub
IdealSpacecraft/IdealCamera/780167287.07717

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added myself to the .zenodo.json document.
  • I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5695".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

@Kelvinrr Kelvinrr self-assigned this Jan 6, 2025
@Kelvinrr Kelvinrr merged commit 0676eb6 into DOI-USGS:dev Jan 16, 2025
2 checks passed
@github-actions github-actions bot added the bug Something isn't working label Jan 16, 2025
chkim-usgs added a commit that referenced this pull request Jan 17, 2025
Kelvinrr pushed a commit that referenced this pull request Jan 17, 2025
@chkim-usgs
Copy link
Contributor

chkim-usgs commented Jan 17, 2025

Following tests were failing:

hijitter_app_test_default (Failed)
hijitter_app_test_withCrop (Failed)

Reverted merge, will re-open issue.

@AustinSanders
Copy link
Contributor Author

The test failures here seem inconsistent. The first run of CodeBuild came back with errors, but local tests and the latest run came back clean. This definitely broke the tests when merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noproj cubes cannot be incorporated into control networks due to missing serial numbers
3 participants