New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API modules have duplicated code #55

Closed

sounmind opened this issue Nov 7, 2024 · 1 comment · Fixed by #56

Assignees

Labels

question

Member

sounmind commented Nov 7, 2024 •

edited

Loading

현재 API 모듈에 중복 코드가 있습니다! 어떤 것을 사용하고, 어떤 것을 사용하지 않아야 할까요?
예를 들어 Grade를 import 하려는 경우, 3개 파일이 나옵니다.

관련 맥락
- Feat: add draft for data module #28 (comment)

sounmind added the question label

sounmind assigned sounmind, Sunjae95 and HC-kang

Contributor

HC-kang commented Nov 7, 2024

외부에서 사용하실 타입들은 /api로 뽑아두었습니다.
type.ts와 types.ts는 마지막 네이밍 정리중에 실수했네요. 수정하겠습니다

HC-kang linked a pull request

that will close this issue

remove: unused type files #56

Merged

1 task

HC-kang closed this as completed in #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment