Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User age/metallicity bounds not respected #61

Open
kadrlica opened this issue Sep 3, 2018 · 0 comments
Open

User age/metallicity bounds not respected #61

kadrlica opened this issue Sep 3, 2018 · 0 comments

Comments

@kadrlica
Copy link
Member

kadrlica commented Sep 3, 2018

The isochrone constructor currently disregards user-specified bounds on age/metallicity and sets them to the range of the isochrone grid (see here). Possible improvements:

  1. Continue this behavior but warn the user
  2. Respect the user's bounds when they are within the isochrone grid; when outside warn the user and set to the isochrone grid bounds.
  3. Respect the user's bounds and throw and exception when they are outside the allowed grid bounds.

For both 2. and 3. above, the default isochrone grid consists of age = [10, 12] and z = [0.0001,0.0002], so the default bounds should be similarly constrained.

@kadrlica kadrlica changed the title Age/metallicity bounds not respected User age/metallicity bounds not respected Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant