Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crashtracker]: Dup fd to ensure proper ownership and lifetimes #758

Open
danielsn opened this issue Nov 25, 2024 · 0 comments
Open

[crashtracker]: Dup fd to ensure proper ownership and lifetimes #758

danielsn opened this issue Nov 25, 2024 · 0 comments

Comments

@danielsn
Copy link
Contributor 

          +1 - BorrowedFd prefferably should be use in conjuction with OwnedFd. borrow_raw - without any guarantees of FD lifetime is problematic.

Probably the safest option would be to dup the fd - and own it within the context of this function.

Otherwise the code looks like correct but "C'ish" rust :)

Originally posted by @pawelchcki in #754 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielsn