diff --git a/docs/edit/runbook.md b/docs/edit/runbook.md index ef52dd88f6..481e27fe0b 100644 --- a/docs/edit/runbook.md +++ b/docs/edit/runbook.md @@ -19,6 +19,7 @@ The impact is that these **configs are not visible** in Metabase, REDAPL, or any 1. Check the test failure to see exactly which configs are missing 2. Add config normalization rules [here](https://github.com/DataDog/dd-go/tree/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/static/) following the existing pattern 1. This can be merged with any review from [@apm-ecosystems](https://github.com/orgs/DataDog/teams/apm-ecosystems) + 2. Bonus Points: Run the auto-formatter [_format.py](https://github.com/DataDog/dd-go/blob/prod/trace/apps/tracer-telemetry-intake/telemetry-payload/static/_format.py) from the `dd-go` root via `python ./trace/apps/tracer-telemetry-intake/telemetry-payload/static/_format.py` 3. After merging, update system-tests by running [update.sh](/tests/telemetry_intake/update.sh) 1. This can be run from the root by running `./tests/telemetry_intake/update.sh` 2. This can be merged with any review from [@apm-ecosystems](https://github.com/orgs/DataDog/teams/apm-ecosystems) diff --git a/tests/test_telemetry.py b/tests/test_telemetry.py index 2029ecf022..05831379ff 100644 --- a/tests/test_telemetry.py +++ b/tests/test_telemetry.py @@ -674,7 +674,7 @@ def is_key_accepted_by_telemetry(key, allowed_keys, allowed_prefixes): if len(missing_config_keys) != 0: logger.error(json.dumps(missing_config_keys, indent=2)) raise ValueError( - "(NOT A FLAKE) Found unexpected config telemetry keys. Runbook: https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness" + "(NOT A FLAKE) Read this quick runbook to update allowed configs: https://github.com/DataDog/system-tests/blob/main/docs/edit/runbook.md#test_config_telemetry_completeness" ) @missing_feature(library="cpp")