diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 2e90f0eed03..f248264219c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -3,18 +3,36 @@ # C# code /Content.*/ @DeltaV-Station/maintainers +# Any assets +/Resources/ @DeltaV-Station/maintainers + +# Server config files +/Resources/ConfigPresets/ @MilonPL + # YML files /Resources/*.yml @DeltaV-Station/yaml-maintainers /Resources/**/*.yml @DeltaV-Station/yaml-maintainers # Sprites -/Resources/Textures/ @IamVelcroboy +/Resources/Textures/ @DeltaV-Station/direction # Lobby art and music - automatically direction issues since its immediately visible to players -/Resources/Audio/Lobby/ @DeltaV-Station/game-directors -/Resources/Textures/LobbyScreens/ @DeltaV-Station/game-directors +/Resources/Audio/Lobby/ @DeltaV-Station/direction +/Resources/Textures/LobbyScreens/ @DeltaV-Station/direction # Maps /Resources/Maps/ @DeltaV-Station/maptainers /Resources/Prototypes/Maps/ @DeltaV-Station/maptainers /Content.IntegrationTests/Tests/PostMapInitTest.cs @DeltaV-Station/maptainers + +# Server rules +/Resources/ServerInfo/Guidebook/DeltaV/Rules/ @DeltaV-Station/head-administrators + +# Tools and scripts +/Tools/ @deltanedas @MilonPL + +# Workflows, codeowners, templates, etc. +/.github/ @deltanedas @MilonPL + +# Standalone files in the root repo +/* @deltanedas diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ce9e7559682..e41221d98d4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,17 +9,16 @@ Upstream is the [space-wizards/space-station-14](https://github.com/space-wizard # Content specific to Delta-V -In general anything you create from scratch (not modifying something that exists from upstream) should go in a DeltaV subfolder. +In general anything you create from scratch (not modifying something that exists from upstream) should go in a DeltaV subfolder, `_DV`. Examples: -- `Content.Server/DeltaV/Chapel/SacrificialAltarSystem.cs` -- `Resources/Prototypes/DeltaV/ai_factions.yml` -- `Resources/Audio/DeltaV/Items/gavel.ogg` -- `Resources/Textures/DeltaV/Icons/cri.rsi` -- `Resources/Locale/en-US/deltav/shipyard/shipyard-console.ftl` - The locale subfolder is lowercase `deltav` instead of `DeltaV`. -- `Resources/ServerInfo/Guidebook/DeltaV/AlertProcedure.xml` - Note that guidebooks go in `ServerInfo/Guidebook/DeltaV` and not `ServerInfo/DeltaV`! +- `Content.Server/_DV/Chapel/SacrificialAltarSystem.cs` +- `Resources/Prototypes/_DV/ai_factions.yml` +- `Resources/Audio/_DV/Items/gavel.ogg` +- `Resources/Textures/_DV/Icons/cri.rsi` +- `Resources/Locale/en-US/_DV/shipyard/shipyard-console.ftl` +- `Resources/ServerInfo/Guidebook/_DV/AlertProcedure.xml` + Note that guidebooks go in `ServerInfo/Guidebook/_DV` and not `ServerInfo/_DV`! # Changes to upstream files diff --git a/Content.Client/Access/UI/AgentIDCardBoundUserInterface.cs b/Content.Client/Access/UI/AgentIDCardBoundUserInterface.cs index 050756fcd14..93ce5538aa1 100644 --- a/Content.Client/Access/UI/AgentIDCardBoundUserInterface.cs +++ b/Content.Client/Access/UI/AgentIDCardBoundUserInterface.cs @@ -26,6 +26,13 @@ protected override void Open() _window.OnNameChanged += OnNameChanged; _window.OnJobChanged += OnJobChanged; _window.OnJobIconChanged += OnJobIconChanged; + _window.OnNumberChanged += OnNumberChanged; // DeltaV + } + + // DeltaV - Add number change handler + private void OnNumberChanged(uint newNumber) + { + SendMessage(new AgentIDCardNumberChangedMessage(newNumber)); } private void OnNameChanged(string newName) @@ -56,6 +63,7 @@ protected override void UpdateState(BoundUserInterfaceState state) _window.SetCurrentName(cast.CurrentName); _window.SetCurrentJob(cast.CurrentJob); _window.SetAllowedIcons(cast.CurrentJobIconId); + _window.SetCurrentNumber(cast.CurrentNumber); // DeltaV } } } diff --git a/Content.Client/Access/UI/AgentIDCardWindow.xaml b/Content.Client/Access/UI/AgentIDCardWindow.xaml index 7d091e4e165..a2ddd1c417d 100644 --- a/Content.Client/Access/UI/AgentIDCardWindow.xaml +++ b/Content.Client/Access/UI/AgentIDCardWindow.xaml @@ -6,6 +6,10 @@