Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable console logging #157

Closed
JeodC opened this issue Apr 22, 2024 · 3 comments · Fixed by #159
Closed

Enable console logging #157

JeodC opened this issue Apr 22, 2024 · 3 comments · Fixed by #159
Labels
request Request for a feature suggestion Suggestion open for discussion

Comments

@JeodC
Copy link
Collaborator

JeodC commented Apr 22, 2024

Per Kevin Bentley, it may be wise to modify cmake to do -DCMAKE_BUILD_TYPE=debug or -DLOGGER. Log output to the console for better linux/mac troubleshooting. Perhaps provide instructions to the user in an issue template on how to utilize it.
@JeodC JeodC added request Request for a feature suggestion Suggestion open for discussion labels Apr 22, 2024
jcoby added a commit to jcoby/Descent3 that referenced this issue Apr 23, 2024
@jcoby
Enable console logging if MONO or LOGGER is defined
67ed7dc 
Re-enable console logging on linux and mac builds with the -DMONO
option.

Rename overloaded Debug_ConsolePrintf function to
Debug_ConsolePrintfAt to fix macro expansion.

Adds -DLOGGER alias for -DMONO.

Implements DescentDevelopers#157
@jcoby jcoby mentioned this issue Apr 23, 2024
Merged
@jcoby
Copy link
Contributor

jcoby commented Apr 23, 2024

logging was removed in #77 because the mprintf_at macro wasn't expanding to Debug_ConsolePrintf(int n, int row, int col, char *format, ...) and causing a segfault. #159 reenables the option, renames the function to Debug_ConsolePrintfAt and adds the LOGGER define as well.

jcoby added a commit to jcoby/Descent3 that referenced this issue Apr 23, 2024
@jcoby
Enable console logging if MONO or LOGGER is defined
34afd85 
Re-enable console logging on linux and mac builds with the -DMONO
option.

Rename overloaded Debug_ConsolePrintf function to
Debug_ConsolePrintfAt to fix macro expansion.

Adds -DLOGGER alias for -DMONO.

Implements DescentDevelopers#157
jcoby added a commit to jcoby/Descent3 that referenced this issue Apr 23, 2024
@jcoby
Enable console logging if MONO or LOGGER is defined
9753f83 
Re-enable console logging on linux and mac builds with the -DMONO
option.

Rename overloaded Debug_ConsolePrintf function to
Debug_ConsolePrintfAt to fix macro expansion.

Adds -DLOGGER alias for -DMONO.

Implements DescentDevelopers#157
@jcoby jcoby mentioned this issue Apr 23, 2024
Closed
21 tasks
@winterheart
Copy link
Collaborator

Perhaps this issue may be considered as solved?

@JeodC
Copy link
Collaborator Author

JeodC commented Apr 23, 2024

Perhaps this issue may be considered as solved?

That's what I'm wondering. I think it's ok to merge.

@JeodC JeodC linked a pull request Apr 24, 2024 that will close this issue
Enable console logging if MONO or LOGGER is defined #159
Merged
@JeodC JeodC closed this as completed Apr 24, 2024
JeodC pushed a commit that referenced this issue Apr 28, 2024
@jcoby
Enable console logging if MONO or LOGGER is defined
782d527 
Re-enable console logging on linux and mac builds with the -DMONO
option.

Rename overloaded Debug_ConsolePrintf function to
Debug_ConsolePrintfAt to fix macro expansion.

Adds -DLOGGER alias for -DMONO.

Implements #157
@JeodC JeodC mentioned this issue May 21, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
request Request for a feature suggestion Suggestion open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable console logging if MONO or LOGGER is defined jcoby/Descent3
3 participants
@jcoby @winterheart @JeodC