Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command GEORADIUS_RO #1251

Open
arpitbbhayani opened this issue Nov 7, 2024 · 4 comments
Open

Add support for command GEORADIUS_RO #1251

arpitbbhayani opened this issue Nov 7, 2024 · 4 comments

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the GEORADIUS_RO command in DiceDB similar to the GEORADIUS_RO command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@ankkyprasad
Copy link
Contributor

Hi, I'd like to take this up. Can you please assign this to me?

@apoorvyadav1111
Copy link
Contributor

Hi @ankkyprasad , Assigned. Thanks for contributing to DiceDB.

@vpsinghg
Copy link
Contributor

vpsinghg commented Dec 2, 2024

@ankkyprasad Are you still working on this ? If not @apoorvyadav1111 Can you please assign me this ?

@ankkyprasad ankkyprasad removed their assignment Dec 2, 2024
@c-harish
Copy link
Contributor

c-harish commented Dec 2, 2024

Hi, @vpsinghg.
GEORADIUS_RO is a sub issue of #1321, which I am working on. So, Can I pick up this issue?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants