Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection leak with frequent WATCH and UNWATCH #1343

Open
arpitbbhayani opened this issue Nov 28, 2024 · 4 comments
Open

Connection leak with frequent WATCH and UNWATCH #1343

arpitbbhayani opened this issue Nov 28, 2024 · 4 comments

Comments

@arpitbbhayani
Copy link
Contributor

  1. we need to log the total number of clients watching the query
  2. log this during every new watch and unwatch

When I did this with regular fmt.Println and randomly tried to watch and unwatch the same key using CLI, but the number of clients in map did not match the active clients. This implies there is some leaked obj reference that is not getting cleaned up during unwatch.

@N3XT14
Copy link

N3XT14 commented Nov 28, 2024

@arpitbbhayani . Can I take this up?

@arpitbbhayani
Copy link
Contributor Author

@N3XT14 assigned it to you. Thanks for taking this up.

@vansh845
Copy link

vansh845 commented Dec 15, 2024

@arpitbbhayani If you are talking about tcpSubscriptionMap , no. of clients are same as active clients watching the query for me. Maybe I am wrong, can you clarify a bit more?

@Kannav02
Copy link
Contributor

Kannav02 commented Jan 7, 2025

@arpitbbhayani is this issue still being worked on by someone, if not can I take this up?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants