Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: DiceDB cannot handle multiple commands in a single request #1415

Open
4 tasks
arpitbbhayani opened this issue Jan 24, 2025 · 2 comments · May be fixed by #1417
Open
4 tasks

Bug: DiceDB cannot handle multiple commands in a single request #1415

arpitbbhayani opened this issue Jan 24, 2025 · 2 comments · May be fixed by #1417

Comments

@arpitbbhayani
Copy link
Contributor

DiceDB cannot handle multiple commands when passed in a single request, we need to support this. Check the file commandhandler.go and there we have explicitly added a check of the length of the commands coming post-parsing stage.

I think this is very closely related to the concept of PIPELINING, but double-check and see how we can support this.

Steps to patch

  1. setup DiceDB server locally from the source - instructions
  2. setup DiceDB CLI locally from the source - instructions

Follow the contribution guidelines

These are general guidelines to follow before you submit a patch. Please mark them as done
once you complete them

@helios2003
Copy link
Contributor

Hi @arpitbbhayani, can I take up this issue?

@raashidanwar
Copy link

raashidanwar commented Jan 24, 2025

Hey @arpitbbhayani 👋 ,

Created a draft PR #1417.
Let me know if these are the changes you are expecting (Haven't spent time understanding the flow, jumped directly) so I can start the review process.
Didn't find any test cases for commandhandler.go to test the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants