Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge "testing" periods into one #207

Open
2 of 4 tasks
sydneyli opened this issue Mar 8, 2019 · 0 comments
Open
2 of 4 tasks

Merge "testing" periods into one #207

sydneyli opened this issue Mar 8, 2019 · 0 comments

Comments

@sydneyli
Copy link
Contributor

sydneyli commented Mar 8, 2019

Accept a "weeks" parameter that indicates when individuals want to move from testing to enforce periods. This will merge our current system of having two "testing" periods-- one invisible and one visible (on the policy list), and ask people submitting via the form to commit to an "enforce" period in a finite period of time.

I'm in the process of splitting this up into PRs. Generally, I think this will be:

  • Small Validator refactor (Use go-y config object)
  • DB => DomainStore refactor (Stop using DB interface for everything-- break this chunk out)
  • Accept "weeks" variable in queue/ API
    ^ These have no dependencies and can each be merged individually! The final PR, however, depends on all three being merged:
  • Alter Queued Validator to promote/fail domains automagically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant