Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LILAC fails at build phase because of some changes needed for the rpointer handling #2905

Open
ekluzek opened this issue Dec 10, 2024 · 3 comments
Assignees
Labels
bfb bit-for-bit bug something is working incorrectly

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 10, 2024

Brief summary of bug

ctsm5.3.015 includes #2757 which includes changes to lnd_comp_nuopc.F90 that need to be moved to lnd_comp_esmf.F90 for LILAC.

https://github.com/ESCOMP/CTSM/pull/2757/files#diff-f2434c2fccfe6f177f22d26b605bd0f9698f51e85348e9cfdd8a13e4a66a09da

General bug information

CTSM version you are using: ctsm5.3.015 (to be made)
Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: LILAC

Important details of your setup / configuration so we can reproduce the bug

This test:

LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac

fails at the BUILD Step because of this.

@ekluzek ekluzek self-assigned this Dec 10, 2024
@ekluzek ekluzek added bug something is working incorrectly bfb bit-for-bit labels Dec 10, 2024
@ekluzek ekluzek added this to the CESM3 Answer changing freeze milestone Dec 10, 2024
@wwieder
Copy link
Contributor

wwieder commented Dec 11, 2024

Thanks for creating this issue, @ekluzek. I'm curious what we're thinking about the prioritization of maintaining LILAC functionality vs. holding up the rpointer CESM tag? @billsacks, @dlawrenncar, @briandobbins do you have thought here?

Ultimately, I'm guessing it likely comes down to effort. Do you have an estimate for how big a lift is to to address this issue, Erik?

@briandobbins
Copy link
Contributor

For the immediate future, we're going to get the rpointer tag in at the expense of LILAC - this is for two primary reasons. One, the CTSM tag is needed for the CAM tag, so things are piling up on their side, and two, we need to make another tag by the end of the year, though admittedly one with just a one-line change to input data. That's on a hard deadline due to an NCAR IT rule.

Other than that, I think it's entirely up to how things look for the LMWG and CESM3. I expect we'll have time, but you know better than I do here, Will. I'd even say if it's just two hours or so, we can do it now, I just want to make sure we're not in the 'days' territory right now, given how fast the holidays are coming up and that end-of-year deadline.

@dlawrenncar
Copy link
Contributor

dlawrenncar commented Dec 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit bug something is working incorrectly
Projects
None yet
Development

No branches or pull requests

4 participants