-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config_pes.xml updates #215
base: main
Are you sure you want to change the base?
Conversation
remove unnecessary blocks: no need to distinguish T62 and TL319 increase NTASKS_OCN for cases with WW3. '
- Introduce MOM6_WW3_CPL_METHOD xml variable controlling which wave coupling method gets used: most, legacy, or none - For B cases, set MIN_SALINITY to 1.0e-6 - For t232, set Laplacian to False - For t232, remove MEKE_ALPHA_RHINES, MEKE_ALPHA_DEFORM, MEKE_ALPHA_FRICT, MEKE_ALPHA_GRID, MEKE_CT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great, I think combining the TL319 and T62 decompositions cuts down the file size and makes this much easier to read. I only had one comment about a specific change you made, but also have a general comment: in the fully coupled PE layouts, Jim uses the <comment>
tags to provide expected throughput. For example, lines 280 and 281 in cime_config/config_pes.xml
are
<pes pesize="M" compset="CAM.*%LT.*MOM6(?!.*%MARBL-BIO)">
<comment>10 ypd/ 5500 pe-hrs/simyr expected</comment>
Could we do something similar? If you do the common derecho layouts (C/G, SWAV / WW3), I can update the MARBL compsets in a future PR. (Or we can create a separate issue for this and do it all later.)
cime_config/config_pes.xml
Outdated
@@ -184,7 +184,7 @@ | |||
<ntasks_rof>128</ntasks_rof> | |||
<ntasks_cpl>128</ntasks_cpl> | |||
<ntasks_ice>128</ntasks_ice> | |||
<ntasks_ocn>384</ntasks_ocn> | |||
<ntasks_ocn>1024</ntasks_ocn> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little surprised that we give MOM more tasks (1024) when running with WW3 than we do with SWAV (896, see line 121). Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I just set NTASKS_OCN to 896 instead of 1024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave the comment discussion for another time, this looks good to me
Partially fixes: #211
(We still need to update PEs for fully coupled cases)