Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change banner text to point to Whitepaper #564

Closed
brianking opened this issue Jun 29, 2021 · 4 comments
Closed

Change banner text to point to Whitepaper #564

brianking opened this issue Jun 29, 2021 · 4 comments

Comments

@brianking
Copy link

Our compliance work is done for now, so let's utilize the banner to promote the Open VSX Whitepaper.
https://outreach.eclipse.foundation/openvsx

For reference, see #337 for last change.

@croundy
Copy link

croundy commented Jun 29, 2021

My thoughts on the banner text:

Download this FREE white paper to learn more about Open VSX and why open source tools to support VS Code extensions are gaining in popularity.

Open VSX Registry: A Vendor Neutral, Open Source Marketplace for VS Code Extensions

Link to https://outreach.eclipse.foundation/openvsx

@brianking
Copy link
Author

@spoenemann I am going to make a PR for this. What do I need to do about the cookie? The current value is:

cookie: {
                    key: 'post-compliance-cut-off',
                    value: 'closed',
                    path: '/'
                }

@spoenemann
Copy link
Contributor

You can change the key to ensure that users who already dismissed the previous banner will see the new one. The key is used to identify which banner has been dismissed.

brianking pushed a commit to brianking/open-vsx.org that referenced this issue Jul 1, 2021
brianking pushed a commit to brianking/open-vsx.org that referenced this issue Jul 2, 2021
mbarbero added a commit that referenced this issue Jul 8, 2021
Issue #564 : Change banner text to point to Whitepaper
@brianking
Copy link
Author

This is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants