Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data flux and vignettes #45

Open
NPJuncal opened this issue Mar 8, 2024 · 3 comments
Open

Data flux and vignettes #45

NPJuncal opened this issue Mar 8, 2024 · 3 comments

Comments

@NPJuncal
Copy link
Collaborator

NPJuncal commented Mar 8, 2024 •
edited
Loading

The name of the variables generated from one function should be the default name for those variables in the next function (as by the flow diagram of the library). This do not happen now, at least between decompact_linear and estimate_oc_stock.
NPJuncal pushed a commit that referenced this issue Mar 8, 2024
changed default name of depth columns to use same name generated in d…
a9a7df0 
…ecompact_linear function

#45
@NPJuncal
Copy link
Collaborator Author

Change function flux figures in main page, flux estimation comes from test extrapolatino when it should come from estimate_h.

@NPJuncal
Copy link
Collaborator Author

-Correct the workflow image in readme
-homogenize the definitions of variables in ROxygen params

@Julenasti
Copy link
Collaborator

It will also be good to homogenise the warnings Nerea :)

NPJuncal added a commit that referenced this issue Sep 5, 2024
@NPJuncal
homogenized parametres and warnings for all functions
f94b045 
#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Julenasti @NPJuncal