Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Allow player to set their death link status if the game does not have a death link option #22

Open
ScipioWright opened this issue Sep 29, 2024 · 4 comments

Comments

@ScipioWright
Copy link

As titled.

Some games have death link as an entirely client-side option (Jak & Daxter, Tunic), so there's no way to display the intent to use death link on the site.

Unless that exists already and I missed it then sorry about the invalid issue

@Eijebong
Copy link
Owner

A workaround for that would be to just put death_link: true in the YAML. The website would extract that as deathlink enabled and the world would ignore it.

A solution would be to mark those worlds as deathlink enabled all the time, but I definitely want to avoid adding more buttons for this. Happy to take ideas in if you have any.

@ScipioWright
Copy link
Author

Gotcha, didn't realize that would work o:

Yeah, that seems like the only reasonable option here, I can't think of another one that isn't super finicky

@Eijebong
Copy link
Owner

Eijebong commented Sep 29, 2024

Yeah deathlink is somewhat special, because there's no standard for it, I just "try my best" and on every YAML check for death_link, deathlink and DeathLink. It's the only attribute like that at the moment, see

impl FeatureExtractor for DefaultExtractor {
and
fn extract_features_from_yaml<'a>(

@ScipioWright
Copy link
Author

Yeahhh, it's more of a "suggested" feature than anything. imo it belongs client-side, but unless your site connects to the room then you can't exactly check the tags so there's no reasonable way to get that working nicely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants