Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.2 is semver breaking? #68

Closed
Lorak-mmk opened this issue Jul 31, 2024 · 3 comments
Closed

0.12.2 is semver breaking? #68

Lorak-mmk opened this issue Jul 31, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Lorak-mmk
Copy link

I didn't have a lot of time to investigate it, but when I try to cargo install cargo-semver-checks v0.33.0 I get the following error:

   Compiling cargo-semver-checks v0.33.0
error[E0433]: failed to resolve: could not find `RemoteGitIndex` in `index`
   --> /home/karolbaryla/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-semver-checks-0.33.0/src/rustdoc_gen.rs:633:38
    |
633 |                 let mut rgi = index::RemoteGitIndex::new(git, &lock)
    |                                      ^^^^^^^^^^^^^^ could not find `RemoteGitIndex` in `index`
    |
note: found an item that was configured out
   --> /home/karolbaryla/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tame-index-0.12.2/src/index.rs:24:21
    |
24  | pub use git_remote::RemoteGitIndex;
    |                     ^^^^^^^^^^^^^^
    = note: the item is gated behind the `__git` feature

error[E0412]: cannot find type `ComboIndex` in module `tame_index::index`
   --> /home/karolbaryla/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-semver-checks-0.33.0/src/rustdoc_gen.rs:586:31
    |
586 |     index: tame_index::index::ComboIndex,
    |                               ^^^^^^^^^^ not found in `tame_index::index`
    |
note: found an item that was configured out
   --> /home/karolbaryla/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tame-index-0.12.2/src/index.rs:21:16
    |
21  | pub use combo::ComboIndex;
    |                ^^^^^^^^^^

error[E0412]: cannot find type `ComboIndex` in module `index`
   --> /home/karolbaryla/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-semver-checks-0.33.0/src/rustdoc_gen.rs:630:27
    |
630 |         let index: index::ComboIndex = match index_cache {
    |                           ^^^^^^^^^^ not found in `index`
    |
note: found an item that was configured out
   --> /home/karolbaryla/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tame-index-0.12.2/src/index.rs:21:16
    |
21  | pub use combo::ComboIndex;
    |                ^^^^^^^^^^

error[E0599]: no variant or associated item named `Git` found for enum `tame_index::Error` in the current scope
   --> /home/karolbaryla/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-semver-checks-0.33.0/src/rustdoc_gen.rs:784:32
    |
784 |         Err(tame_index::Error::Git(err)) => {
    |                                ^^^ variant or associated item not found in `Error`

error[E0599]: no variant or associated item named `Git` found for enum `tame_index::Error` in the current scope
   --> /home/karolbaryla/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-semver-checks-0.33.0/src/rustdoc_gen.rs:788:40
    |
788 |                 Err(tame_index::Error::Git(err).into())
    |                                        ^^^ variant or associated item not found in `Error`

it was working recently, and I see that tame-index v0.12.2 did something with features: #66 so I suspect that it is semver-breaking (because it renamed feature or moved some item behind feature) so should not be released as 0.12.2 but as 0.13.

It is braking cargo-semver-checks installation in CI for us :(

@Lorak-mmk Lorak-mmk added the bug Something isn't working label Jul 31, 2024
@Jake-Shadle
Copy link
Member

Yanked.

@Lorak-mmk
Copy link
Author

Lorak-mmk commented Jul 31, 2024

Hmm... it looks like I may have made a mistake, now it's not possible to install it too. Could you unyank the version, and I'll open the issue in cargo-semver-checks? Sorry for the trouble @Jake-Shadle

@Jake-Shadle
Copy link
Member

Ok, unyanked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants