Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in definition of 'ocean' (ENVO:00000015) #1550

Closed
dillerm opened this issue Nov 7, 2024 · 4 comments
Closed

Typos in definition of 'ocean' (ENVO:00000015) #1550

dillerm opened this issue Nov 7, 2024 · 4 comments

Comments

@dillerm
Copy link

dillerm commented Nov 7, 2024

Current definition: "A marine water body which is constitutes the majority of an astronomical body's hydrosphere." (emphasis mine)

Proposed fix: "A saline water body which constitutes the majority of an astronomical body's hydrosphere."

@cmungall
Copy link
Member

cmungall commented Nov 7, 2024

Thanks for noticing the typo!

Regarding marine vs saline, can you say more about the motivation? Is it because "marine" is more circular?

  • Many definitions of "marine" are something like "sea or ocean"
  • ENVO's own definition of "marine water body" is "A lentic water body which is composed primarily of marine water.", but we have no term "marine water" in ENVO

There are some other oddities here. In ENVO, marine WB and saline WB are sibs, but surely it should be child-parent

Here are the terms in context:

image

@dillerm
Copy link
Author

dillerm commented Nov 7, 2024

Ah, whoops, I had not noticed that this class had 'marine water body' as a parent class (I was only looking at 'saline water body'). Ignore that suggestion.

@pbuttigieg
Copy link
Member

Hm, some clean up required

In ENVO, marine WB and saline WB are sibs, but surely it should be child-parent

Should work with the primary composition axiom, as freshwater lenses etc can be permitted

pbuttigieg added a commit that referenced this issue Dec 9, 2024
pbuttigieg added a commit that referenced this issue Dec 9, 2024
@pbuttigieg
Copy link
Member

In #1564, I've reworked these semantics to focus on the origin of the ocean/sea water via oceanogenesis.

oceanogenesis =def. "A water accumulation process which results in the formation of an ocean by the outgassing, capture, and subsequent condensation of water vapour during the formation of an astronomical body."

I've obsoleted 'marine water body', and seawater is now a subclass of ocean water, the former being modified by terrestrial processes.

ocean water =def. "Saline water which has has been formed as a result of oceanogenesis and which has its composition and properties maintained through processes including hydrological cycling, continental weathering, porewater burial, mineral deposition, ion exchange reactions, and ecological processes."

seawater =def. "Ocean water which is part of a sea and which has its properties and composition more strongly influenced by terrestrial processes - such as river runoff, groundwater seepage, aeolian transport of dust - than waters of the open ocean."

Where ocean and sea are now siblings:

ocean =def. "A lentic water body which has been formed as a result of oceanogenesis and constitutes the majority of an astronomical body's hydrosphere."

sea =def. "A lentic water body which is wholly or partly surrounded by land and either connected to or derived from a part of an ocean."

pbuttigieg added a commit that referenced this issue Dec 9, 2024
* Closes #1514

* Closes #1549

* Closes #1518

* Closes #1525

* addressing #1550

* attempt to fix odd unsatisfiables

* clean up for #1550

* terms for #1536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants