Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to MapLibre GL JS v5.0 #231

Open
gavinr-maps opened this issue Jan 2, 2025 · 1 comment
Open

Update to MapLibre GL JS v5.0 #231

gavinr-maps opened this issue Jan 2, 2025 · 1 comment

Comments

@gavinr-maps
Copy link
Contributor

gavinr-maps commented Jan 2, 2025

Describe the problem

v5.0 was released recently: https://github.com/maplibre/maplibre-gl-js/releases/tag/v5.0.0 (maplibre/maplibre-gl-js#5272)

Describe the proposed solution

  1. Test using v5 with Esri Leaflet Vector
  2. If all tests pass, include v5 as packaged in the next release. See here for an example of the expected package.json changes: https://github.com/Esri/esri-leaflet-vector/pull/219/files

Alternatives considered

No response

Additional Information

Note: possibly look into this issue at the same time: #152

@gavinr-maps
Copy link
Contributor Author

gavinr-maps commented Jan 2, 2025

I've started the process here: #232. I'm getting errors on startup and when I try to pan:

  • Startup: MaplibreGLLayer.js:187 Uncaught TypeError: Cannot set property latRange of #<Dt> which has only a getter
  • Pan: MaplibreGLLayer.js:254 Uncaught TypeError: Cannot set property center of #<Dt> which has only a getter

... which seems to be consistent with this error that is an issue in maplibre-gl-leaflet: maplibre/maplibre-gl-leaflet#64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant