Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We may need to separate "subscriptions/search" into two separate endpoints? #90

Open
bibinss opened this issue Mar 21, 2019 · 1 comment
Open

We may need to separate "subscriptions/search" into two separate endpoints? #90

bibinss opened this issue Mar 21, 2019 · 1 comment
Labels
question Further information is requested

Comments

@bibinss
Copy link
Contributor

bibinss commented Mar 21, 2019 •
edited
Loading

Currently "subscriptions/search" endpoint supports both search by user id and reverse lookup for label conditions. Both dont sit together. So we may need to separate them into two

  • subscriptions/search
  • subscriptions/match
@bibinss bibinss added the question Further information is requested label Mar 21, 2019
@bibinss
Copy link
Contributor Author

bibinss commented Apr 4, 2019

I have created a new endpoint - "subscriptions/match". This will return all the subscription whose conditional expression matches the given input labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bibinss