[HOLD for payment 2025-01-18] [$125] card-No space between "other" card feed and next button

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.81-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap settings -- workspace settings - more features
3. Enable company cards
4. Open company card
5. Scroll down the page and select "other"

Expected Result:

There must be space between "other" card feed and next button.

Actual Result:

There is no space between "other" card feed and next button.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6707689_1736208348369.Screenrecorder-2025-01-07-05-29-25-954.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876632229679213396
• Upwork Job ID: 1876632229679213396
• Last Price Increase: 2025-01-07
• Automatic offers:
• nkdengineer | Contributor | 105595694

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no space between "other" card feed and next button.

What is the root cause of that problem?

We don't add the confirm button style then there's no space between the confirm button and the selection list

App/src/pages/workspace/companyCards/addNew/SelectBankStep.tsx

Line 84 in 2e2fd1c

<SelectionList

App/src/components/SelectionList/BaseSelectionList.tsx

Line 855 in 2e2fd1c

style={[styles.w100, confirmButtonStyles]}

What changes do you think we should make in order to solve the problem?

Add confirmButtonStyles={styles.mt5} to the selection list here

App/src/pages/workspace/companyCards/addNew/SelectBankStep.tsx

Line 84 in 2e2fd1c

<SelectionList

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[parasharrajat]

@nkdengineer's proposal looks good.

I can help review as C+. @bfitzexpensify

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No space between "other" card feed and next button

What is the root cause of that problem?

We use the default style without spacing if confirmButtonStyles is not added.

App/src/components/SelectionList/BaseSelectionList.tsx

Line 846 in 8bccfc0

style={[styles.w100, confirmButtonStyles]}

This issue will also occur in other places where the BaseSelectionList component is used.

What changes do you think we should make in order to solve the problem?

To resolve this issue, I think we should update the BaseSelectionList to create space for the confirm button to other place use BaseSelectionList no need to update. We can then overwrite it if confirmButtonStyles has the same style.

App/src/components/SelectionList/BaseSelectionList.tsx

Line 846 in 8bccfc0

style={[styles.w100, confirmButtonStyles]}

update to:

  <Button
      success={!shouldUseDefaultTheme}
      large
      style={[styles.w100, styles.pt5, confirmButtonStyles]} // add this line or use styles.mt5,
      text={confirmButtonText || translate('common.confirm')}
      onPress={onConfirm}
      pressOnEnter
      enterKeyEventListenerPriority={1}
  />

Optional: Add a new flag to toggle this default style on or off.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a UI bug and does not require unit testing

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dukenv0307]

It belongs to WS feed, should we open it for other contributors? @mountiny

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No space between last item with the next button.

What is the root cause of that problem?

There is simply no style added to add the space between the last item and the button.

What changes do you think we should make in order to solve the problem?

Looking at other lists such as new chat page, we don't add any spacing too between the list and the footer. If we want to add the spacing here, instead of adding margin to the button, we can add a padding to the list content container style.

If we add margin to the button, the spacing affect the whole list.

A better way is to add a padding bottom to the content container style.

App/src/pages/workspace/companyCards/addNew/SelectBankStep.tsx

Lines 84 to 86 in a530d9f

	<SelectionList
	ListItem={RadioListItem}
	onSelectRow={({value}) => {

contentContainerStyle={styles.pb5}

a.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876632229679213396

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[mountiny]

@dukenv0307 has worked on the project so assigned them

Can you please pick which proposal to go with?

[melvin-bot]

Upwork job price has been updated to $125

[dukenv0307]

@nkdengineer's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @mountiny is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.83-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: No space between other card feed and next button #54950

If no regressions arise, payment will be issued on 2025-01-18. 🎊

For reference, here are some details about the assignees on this issue:

• @dukenv0307 requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@dukenv0307 @bfitzexpensify @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]