Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [$125] iOS - Unable to add attachment to chat and upload avatar #54970

Open
2 of 8 tasks
IuliiaHerets opened this issue Jan 8, 2025 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 8, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.82-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.2
App Component: Other

Action Performed:

Bug 1:

  1. Launch ND or hybrid app.
  2. Open chat.
  3. Tap + > Add attachment .
  4. Tap Choose from gallery.
  5. Select an image.

Bug 2:

  1. Launch ND or hybrid app.
  2. Go to Account settings > Profile.
  3. Tap on the avatar.
  4. Tap Choose from gallery.
  5. Select any photo.

Expected Result:

Bug 1:
Device gallery will open.

Bug 2:
Avatar edit page will open.

Actual Result:

Bug 1:
Device gallery does not open. Composer is not responsive.

Bug 2:
Avatar edit page does not open.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6709216_1736352770521.ScreenRecording_01-09-2025_00-11-49_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021877043910943152016
  • Upwork Job ID: 1877043910943152016
  • Last Price Increase: 2025-01-10
  • Automatic offers:
    • nkdengineer | Contributor | 105640040
Issue OwnerCurrent Issue Owner: @VictoriaExpensify
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 8, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 8, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 8, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@marcochavezf marcochavezf added the External Added to denote the issue can be worked on by a contributor label Jan 8, 2025
@melvin-bot melvin-bot bot changed the title iOS - Unable to add attachment to chat and upload avatar [$250] iOS - Unable to add attachment to chat and upload avatar Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021877043910943152016

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@marcochavezf
Copy link
Contributor

Seems it's coming from this PR, I tested out the the ad-hoc build and was able to reproduce the issue there

@marcochavezf
Copy link
Contributor

PR to fix it was merged. Requested CP here

@marcochavezf
Copy link
Contributor

Tested out the version 9.0.82-5 and bug is gone

@marcochavezf marcochavezf removed the DeployBlockerCash This issue or pull request should block deployment label Jan 9, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Hourly KSv2 labels Jan 10, 2025
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Jan 10, 2025
@melvin-bot melvin-bot bot changed the title [$250] iOS - Unable to add attachment to chat and upload avatar [HOLD for payment 2025-01-17] [$250] iOS - Unable to add attachment to chat and upload avatar Jan 10, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 10, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 10, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 10, 2025

@rushatgabhane @VictoriaExpensify @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny reopened this Jan 10, 2025
@mountiny mountiny changed the title [HOLD for payment 2025-01-17] [$250] iOS - Unable to add attachment to chat and upload avatar [HOLD for payment 2025-01-17] [$125] iOS - Unable to add attachment to chat and upload avatar Jan 10, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

Upwork job price has been updated to $125

@nkdengineer
Copy link
Contributor

@mountiny I'm here.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 10, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny
Copy link
Contributor

@nkdengineer helped a lot in this thread to find the root cause so I think they should get partial reward https://expensify.slack.com/archives/C01GTK53T8Q/p1736446380828509?thread_ts=1736355446.166919&cid=C01GTK53T8Q

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 11, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-01-17] [$125] iOS - Unable to add attachment to chat and upload avatar [HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] [$125] iOS - Unable to add attachment to chat and upload avatar Jan 11, 2025
Copy link

melvin-bot bot commented Jan 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.83-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-18. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 11, 2025

@marcochavezf @VictoriaExpensify @nkdengineer The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants