-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Chat - After sending user suggestions, if any text deleted, LHN displays "this chat is with.." #55057
Comments
Triggered auto assignment to @jliexpensify ( |
Job added to Upwork: https://www.upwork.com/jobs/~021877637446096588180 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
I don't think this fits into any of the major projects (maybe #quality, but it's not a consistency thing). I think it would go into #expense |
ProposalPlease re-state the problem that we are trying to solve in this issue.After sending user suggestions, if any text deleted, LHN displays "this chat is with.." What is the root cause of that problem?This requires a App/src/libs/actions/Report.ts Lines 1598 to 1609 in 219e66d
What changes do you think we should make in order to solve the problem?So we need to set the successData for the const successData: OnyxUpdate[] = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${originalReportID}`,
value: {
[reportActionID]: {
pendingAction: null,
previousMessage: null,
},
},
},
{
onyxMethod: Onyx.METHOD.MERGE,
key: `${ONYXKEYS.COLLECTION.REPORT}${originalReportID}`,
value: {
lastMessageText,
},
},
]; What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?What alternative solutions did you explore? (Optional) |
In case of email address BE return empty value but in other case it is working fine. So this issue can be fixed from BE only, FE automatically update the data once delete completes. no explicit changes required in FE. |
@eh2077 - let me know if this should be an |
@jliexpensify, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@jliexpensify Yes, I agree that this should be internal. Note that it works as expected in offline mode Screen.Recording.2025-01-13.at.8.08.20.PM.mov |
@jliexpensify, @eh2077 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue, just waiting for an Internal Engineer to follow up. |
Not overdue, this is internal |
@jliexpensify Can you add hot pick label on this? |
Backend PR is up: https://github.com/Expensify/Auth/pull/13892 |
PR deployed, closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.83-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Chat Report View
Action Performed:
Expected Result:
After sending user suggestions, if any text deleted, LHN must display the previous message.
Actual Result:
After sending user suggestions, if any text deleted, LHN displays "this chat is with.." instead of previous message.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6710694_1736497087619.Screenrecorder-2025-01-10-13-39-53-640.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @eh2077The text was updated successfully, but these errors were encountered: