Feat/change device during call #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmen237
force-pushed
the
feat/change-device-during-call
branch
from
6282142 to
a01a15f
Compare
malmen237
force-pushed
the
feat/change-device-during-call
branch
from
a01a15f to
bc266fe
Compare
LucasMaupin
approved these changes
Dec 9, 2024
martinstark
reviewed
Dec 9, 2024
Saelmala
approved these changes
Dec 9, 2024
… for mobile and links
…new state-structure
…dundant join-production
…new state-structure
Co-authored-by: Lucas Maupin <[email protected]>
…-saved-prod-id from globalstate
malmen237
changed the base branch from
development
to
feat/multiple-sessions-one-window
…nection with new audio-inputs
Base automatically changed from
feat/multiple-sessions-one-window
to
development
December 13, 2024 14:32
…evice has been changed
malmen237
force-pushed
the
feat/change-device-during-call
branch
from
04ee700 to
6c3a9ae
Compare
Saelmala
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR enables the possibility to trigger the device-fetch, both from the main-page and from the call. This also makes it possible to change the device connected to the call. It will create a small pause in the call due to the fact that the user needs to be disconnected and re-connected in order to switch, but the user should only experience it like a small "reload" in the UI.
Reload-button on the main-page
Update device-button on the call-page
When pressing "change device" there will be a refetch of all devices connected. If the user adds a new device after the button has been pressed there also is a manual button for reloading the device-list.
When pressing "save" the call will disconnect the previous device and re-connect with the new device connected.
Re-fetch devices not working for Firefox-users
It is not possible to reset permissions for users with firefox-browsers, therefore it is not possible to find new devices connected to the computer.
When pressing the reload devices-button, the firefox user is shown a modal instead:
When changing device during a call the firefox-user is shown a warning that any new devices won't show and instructions how to solve this:
Some minor fixes
Also added a small "word-wrap" to break up long-names, if the production or line is given a name that is too long for the screen